1. 28 Jun, 2018 3 commits
    • Debarshi Ray's avatar
      base-item: Use the correct stride value · c3ef33ea
      Debarshi Ray authored
      The stride with which the Cairo surface is created should be the same
      as the one with which data was written to it. The Cairo surface and its
      underlying memory buffer were being created based on the stride
      specified by Cairo, while data was being written to it based on a
      potentially smaller stride value, which could have caused visual
      glitches.
      
      GEGL_AUTO_ROWSTRIDE represents the product of the bytes per pixel of
      the Babl format with the requested width. This might not match the
      value specified by the Cairo surface because it might be more
      performant to have extra padding at the end of each row to satisfy
      alignment requirements, etc..
      
      There are no known bugs caused by this, possibly because a
      CAIRO_ARGB32 pixel has a nicely rounded length of 32 bits, which makes
      a mismatch unlikely. However, the possibility cannot be ruled out.
      There was a similar bug in gegl:pixbuf [1] where the stride with which
      a GdkPixbuf was created didn't match the one with which data was read
      from it.
      
      [1] GEGL commit aaf2477caec750
          https://bugzilla.gnome.org/show_bug.cgi?id=779135
      c3ef33ea
    • Debarshi Ray's avatar
      image-view: Use the correct stride value · 15542a14
      Debarshi Ray authored
      Multiplying the bytes per pixel of the Babl format with the requested
      width is the same as GEGL_AUTO_ROWSTRIDE. Therefore, it makes no sense
      to pass an explicit stride if that's just the same thing as
      GEGL_AUTO_ROWSTRIDE.
      
      The correct value would be the one specified by the Cairo surface
      because ultimately the size of the allocated memory is defined by the
      product of the stride and height. Any mismatch between Cairo and
      GEGL_AUTO_ROWSTRIDE, due to extra padding at the end of each row to
      satisfy alignment requirements, etc., would affect performance.
      
      It's hard to know the performance impact of the current code, and
      a CAIRO_ARGB32 pixel has a nicely rounded length of 32 bits, which
      makes a mismatch unlikely. Still, it is wise to make this change
      because the Cairo documentation recommends this. For what it's worth,
      GIMP also uses the Cairo stride value when copying pixels out of a
      GeglBuffer into a Cairo surface.
      15542a14
    • Daniel Șerbănescu's avatar
      Update Romanian translation · d9da5902
      Daniel Șerbănescu authored
      d9da5902
  2. 24 Jun, 2018 1 commit
  3. 21 Jun, 2018 1 commit
  4. 19 Jun, 2018 1 commit
  5. 18 Jun, 2018 2 commits
  6. 17 Jun, 2018 1 commit
  7. 15 Jun, 2018 3 commits
  8. 12 Jun, 2018 2 commits
  9. 11 Jun, 2018 1 commit
  10. 01 Jun, 2018 2 commits
  11. 28 May, 2018 1 commit
  12. 24 May, 2018 4 commits
  13. 21 May, 2018 1 commit
  14. 20 May, 2018 1 commit
  15. 19 May, 2018 1 commit
  16. 15 May, 2018 1 commit
  17. 06 May, 2018 1 commit
  18. 28 Apr, 2018 1 commit
  19. 27 Apr, 2018 2 commits
  20. 25 Apr, 2018 1 commit
  21. 22 Apr, 2018 2 commits
  22. 20 Apr, 2018 1 commit
  23. 19 Apr, 2018 1 commit
  24. 16 Apr, 2018 1 commit
  25. 06 Apr, 2018 1 commit
  26. 27 Mar, 2018 2 commits
  27. 21 Mar, 2018 1 commit