1. 02 Oct, 2018 4 commits
  2. 01 Oct, 2018 1 commit
  3. 29 Sep, 2018 1 commit
  4. 28 Sep, 2018 4 commits
  5. 27 Sep, 2018 2 commits
    • Debarshi Ray's avatar
      flatpak: Switch to Meson · d8f0be29
      Debarshi Ray authored
      The Autotools build didn't use --disable-dogtail, even though the SDK
      doesn't have Dogtail. It only worked because configure.ac doesn't
      actually check for the presence of Dogtail. The Meson build doesn't
      check for it either, but merely to imitate the Autotools build.
      
      It's better to spell out exactly what's going on.
      d8f0be29
    • Debarshi Ray's avatar
      build: Add the remaining -Wextra warnings in GCC 8 to the Meson build · 4e0a1502
      Debarshi Ray authored
      The Autotools build uses -Wextra because it's on the AX_COMPILER_FLAGS
      list. However, using -Wextra directly is problematic because newer
      compilers can add more warnings to the -Wextra umbrella, and some of
      them might not be fit for this codebase. eg., GCC 8 added
      -Wcast-function-type, which can't be sanely used with the GNOME
      platform (see commit bb290a1e). This is why the Meson build
      tries to avoid -Wextra. Instead, it is better to explicitly list out
      the desired warnings from the -Wextra umbrella.
      
      The warnings that were explicitly listed out in AX_COMPILER_FLAGS were
      already present in the initial port to Meson. This fills in the rest
      that weren't explicitly listed but were still enabled by -Wextra.
      4e0a1502
  6. 26 Sep, 2018 4 commits
  7. 25 Sep, 2018 5 commits
  8. 24 Sep, 2018 1 commit
  9. 18 Sep, 2018 2 commits
    • Debarshi Ray's avatar
      Make photos_base_item_download return a GFile instead of a path · e651e8d7
      Debarshi Ray authored
      It's prudent to standardize around GFile across the code because:
        * Being a reference counted object, it's cheaper to pass around. No
          need to allocate little memory buffers to copy strings around.
        * Supports both paths and URIs. Even though, in this particular case,
          it's always going to be a local path, that's not true for other
          areas of the code.
        * Encapsulates all GIO operations that can be performed on a file.
          Rarely, if ever, does the code directly use UNIX system calls or
          the C standard library to operate on files because of the need for
          asynchronous operations, support for cancellation, and nicer error
          handling.
      
      For all these reasons, the new codec API for GeglBuffer is also based
      around GFile.
      
      Exceptions when raw paths or URIs are useful:
        * Serializing and deserializing across D-Bus, databases, etc..
        * Logging error or debug messages.
        * Interacting with GIO-unfriendly APIs like Exiv2.
      
      https://gitlab.gnome.org/GNOME/gnome-photos/issues/63
      e651e8d7
    • Debarshi Ray's avatar
      base-item: Rename a variable · c84f289a
      Debarshi Ray authored
      This will make the subsequent commit easier to read.
      
      https://gitlab.gnome.org/GNOME/gnome-photos/issues/63
      c84f289a
  10. 17 Sep, 2018 2 commits
  11. 14 Sep, 2018 3 commits
  12. 13 Sep, 2018 7 commits
  13. 09 Sep, 2018 1 commit
  14. 06 Sep, 2018 2 commits
  15. 03 Sep, 2018 1 commit