This function was introduced in Flatpak 1.15.6. It is effectively the
combination of flatpak_transaction_add_rebase() and
flatpak_transaction_add_uninstall(), handling the NOT_INSTALLED case
itself, and with the improvement that if installing the new app fails,
the old app is not uninstalled.

While 1.15.6 is a pre-release, it is actually shipped in some stable
distros, notably Fedora 39.

Fixes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2140

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Closes #2487

Fix arrows direction in OS updates page for RTL.

Closes #2487

See merge request GNOME/gnome-software!1911

This reverts merge request !1911

PackageKit can block packages from update, thus respect that and not show
neither prepare blocked packages for update.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2485

flatpak: Use flatpak_transaction_add_rebase_and_uninstall() if available

Closes #2140

See merge request GNOME/gnome-software!1901

Helps https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1746

The `components_by_id` hash table borrowed component id-s from the libxmlb,
which works as long as the silo is not refreshed, when the old strings are
freed and new are created. Copy the id-s to avoid the crash.

Fix direction of versions without letters in OS updates page for RTL.

Closes #2487

See merge request GNOME/gnome-software!1912

flatpak: Fix a crash during app installation

See merge request GNOME/gnome-software!1915

Resolve "Blocked packages are listed in `Updates` page."

Closes #2485

See merge request GNOME/gnome-software!1913

review-row: Display tooltip for review summary text

See merge request GNOME/gnome-software!1914

Just in case an icon theme won't provide it.

Even the icon should be available, it not always is, thus always verify
the icon existence, to not return a non-existent icon.

The "application-x-executable" seems to be more suitable as a fallback
when the app's icon could not be found for some reason.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2353

The update can add/remove/update packages, thus classify the apps accordingly
with corresponding app state, which will show the apps in the correct section
in the Updates page.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2307

Resolve "Removal shown as update in Updates Tab"

Closes #2307

See merge request GNOME/gnome-software!1918

Resolve "Provide new scalable default app icon"

Closes #2353

See merge request GNOME/gnome-software!1917

This was broken in commit ca481d16, due to reusing a `tmp` variable
which happened to contain the license data.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Fixes: #2495

We can short-circuit the entire loop if the kudo is set already. This
introduces no functional changes.

Spotted while working on #2495.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

This was broken in commit 0655f358 for any gnome-software built
against libappstream 1.0 or later, as the commit completely removed the
code paths which set `mobile_relation_kind_out` or
`desktop_relation_kind_out`.

This fixes the mobile/desktop support always being ‘no’ on the hardware
support context dialog.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Backport !1926 “gs-appstream: Fix locale variant lookup for translation warnings” to gnome-46

See merge request GNOME/gnome-software!1928

Backport !1924 “gs-hardware-support-context-dialog: Fix desktop/mobile support” to gnome-46

See merge request GNOME/gnome-software!1929

The refine thread accesses the self->silo, but does not hold the read
locker, thus add it for thread safety.

Possibly related to a downstream report:
https://bugzilla.redhat.com/show_bug.cgi?id=2272028

The gs_plugin_flatpak_find_app_by_ref() simply returns the first match,
but it's not correct when looking for the alternatives, thus skip
the alternate_of app to really return another version of the app.

Also add both the found alternative and the alternate_of apps into
the result for an app with a local file, thus they are always both
available in the GUI.

Related to https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2488

It can be the plugins returned either the app_local_file itself or
a new instance pointing to the same app, thus check for it to not
have duplicates in the source selector.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2488

Backport !1931 “gs-plugin-appstream: Add missing silo read locker” to gnome-46

See merge request GNOME/gnome-software!1934

Backport !1919 “flatpak: Lookup for an alternate app skipping the alternate_of app” to gnome-46

See merge request GNOME/gnome-software!1935

Small-caps was causing rendering issues with some fonts; instead, style
the origin-rounded-box's label's size, weight, and text case with CSS.

While we're here, tweak the padding to use origin-rounded-box to use
font-relative sizing.

Closes #2504

Backport !1938 “origin-popover: remove small-caps, style with CSS” to gnome-46

See merge request GNOME/gnome-software!1939

The function throws a runtime warning when a NULL is passed to it.
The app's summary can be NULL for bare package updates.

Backport !1945 “gs-app-details-page: Do not pass NULL into g_markup_escape_text()” to gnome-46

See merge request GNOME/gnome-software!1946

The "updatable" state means "downloaded locally, ready to be installed", which
is not the case here. The upgrade is either "available" (to be downloaded), or
"unavailable" (end of life). The other states are determined by the other plugins.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2514

Backport !1949 “fedora-pkgdb-collections: Incorrect state set on the upgrade app” to gnome-46

See merge request GNOME/gnome-software!1951

Remove an unnecessary quote symbol at the end of the line
776, which was causing GNOME Builder to show a warning saying
"element child has extra content: object".

Backport !1961 “gs-details-page: Remove unnecessary quote symbol” to gnome-46

See merge request GNOME/gnome-software!1962

Backport !1960 “gs-review-dialog: Allow closing the window with ESC” to gnome-46

See merge request GNOME/gnome-software!1963

In `block_scheduler_schedule_cb`, a `GCancellable::cancelled` signal
handler was connected to a tasks's cancellable, with a pointer to the
task itself as data. However, this was done without incrementing the
reference count for the task, resulting in an error due to the task
being prematurely freed when `g_cancellable_disconnect` was called.

In addition to resolving that, we will change `block_check_cb` to
increment the task's reference count while it is in use.

Closes #2516

gs-metered: Count all references to task in block_scheduler_schedule_cb

See merge request GNOME/gnome-software!1969

They are always cleared in the finalize() function, but not always
initialized here, when the rpm-ostree plugin is auto-disabled.
While it does not cause any obvious harm in runtime, better to
do the things as they are supposed to be done.

The changelogs can be long, hundred kilobytes, then waiting for
the process end and read the stdout of it afterwards can cause
an indefinite waiting, due to no read of the stdout.

GtkLabel (and Pango) has a hard time to process several KB of text,
thus cut the history log at arbitrary chosen 4KB length.

Backport !1947 “rpm-ostree: Several fixes related to historical updates” to gnome-46

See merge request GNOME/gnome-software!1974