Signed-off-by: Philip Withnall <pwithnall@gnome.org>

A PkPackage can have 'PK_INFO_ENUM_AVAILABLE' when there is an update
available to be installed or when the package is available remotely
but yet to be installed. So, set the update version of the app only in
the former case, and actual version in the later.

Refer https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2575

packagekit: Set update version only when package is updateable

See merge request GNOME/gnome-software!2119

The gs_dkms_got_secureboot_state_cb() expects a GTask as its user data,
but the gs_plugin_dkms_reload() passed a GsPlugin instead. That could
cause a crash.

Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=2312882

dkms: Fix callback user data in a reload() function

See merge request GNOME/gnome-software!2122

This is mostly useful for OOT plugins or siguations where some of
the non-core plugins do not build, but tests still need to run. This
is, however, most likely a sensible split.

packagekit already has a RUN_BEFORE on generic-updates

Else, found will be set unconditionally to TRUE, and the calling
function, refine_thread_cb, will not go into refine_from_pkgname,
despite nothing having been found.

We have identified this during testing of an OOT plugin.

Fixes 5dd59c4a

This is also some small fallout from
5dd59c4a

Discovered by Milan Crha

Appstream plugin fixes

See merge request GNOME/gnome-software!2123

Add initial Indonesian translation of user guide

See merge request GNOME/gnome-software!2124

Show the error message using AdwStatusPage:description, otherwise
the "Unable to Show App Details" title will be overriden.

Backport !2126 “gs-details-page: Don't override the "page_failed" AdwStatusPage title” to gnome-47

See merge request GNOME/gnome-software!2127

Refer https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1944#note_2234645

With this we also show the 'empty' stack page if the removed review is
the only app review.

When 'fetch' request for an app fails due to some io / server issues,
we might not have the 'user_skey' available. So, we just ignore
sending 'user_skey' to the server than crashing, as it's not a
mandatory field for a 'submit' request.

Review deletion before then next successful 'fetch' request will still
fail with a "missing data, expected user_skey" message from ODRS
server. That needs doing an async fetch which is more work, but should
be done at some point in future.

Fixes the following crash:
--------------------------

16:35:38:283 GLib g_ref_string_new_intern: assertion 'str != NULL' failed
Trace/breakpoint trap (core dumped)

Backtrace:
----------

 #5  0x00007fd204dc441c in as_review_add_metadata (review=0x55745174e7a0 [AsReview], key=0x7fd204ee778e "user_skey", value=0x0) at ../src/as-review.c:837
 #6  0x00007fd204ea6acf in gs_odrs_provider_submit_review
    (self=0x55744cb327e0 [GsOdrsProvider], app=0x7fd1cdff7700 [GsApp], review=0x55745174e7a0 [AsReview], cancellable=0x55744d380bc0 [GCancellable], error=0x7fff5928b7a0) at ../lib/gs-odrs-provider.c:1690

'parent' attribute was removed during 'libadwaita' port.

Fixes the following crash:
-------------------------

17:16:31:885 GLib-GObject invalid cast from 'GsAppReviewsDialog' to 'GtkWindow'
Trace/breakpoint trap (core dumped)

1. Click 'Write Review' button in app details page.
2. Run 'gnome-software --details=app-id'
3. 'Write Review' dialog will stay open without this commit.

Note: This should be done to all dialogs which can be opened from
details page.

Backport !2135 “ODRS review fixes” to gnome-47

See merge request GNOME/gnome-software!2136

All the systemd-offline logic was unused, and so removed.

Backport !2137 “fwupd: Do not use API removed from fwupd 2.0.x” to gnome-47

See merge request GNOME/gnome-software!2138

Fixes: https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2675

Backport !2143 “snap: Fix crash when launching non-snap app” to gnome-47

See merge request GNOME/gnome-software!2145