Signed-off-by: Philip Withnall <pwithnall@gnome.org>

'app_data' is an argument to both the actual and progress
callbacks. In this case, using `g_steal_pointer` on one of them will
render the other one to be NULL, causing the crash. Follow the same
convention used in install.

Backport !2147 “snap: Fix crash when uninstalling snap” to gnome-47

See merge request GNOME/gnome-software!2148

The `blobfn` variable can be set when the `reload` is invoked, leading
to a memory leak.

This had been discovered by a Coverity Scan.

Backport !2150 “gs-plugin-appstream: Fix a possible memory leak” to gnome-47

See merge request GNOME/gnome-software!2151

GtkWidget:width-request=360 breaks adaptiveness of the
"Uninstal [app]" alert dialog, preventing it to be
properly resized when the parent window is smaller than
360px. Also, GtkWidget:halign and GtkWidget:hexpand do
nothing, so they are unnecessary.

Also, remove AdwActionRow:title/subtitle-lines=1, as
this makes the row title and subtitle to ellipsize when
the dialog width is small, making the text unreadable.
Remove these properties to make the text wrap instead.

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2713

Backport "gs-page: Fix "Uninstall [app]?" alert dialog not being adaptive"

See merge request GNOME/gnome-software!2157

packagekit: Use pk_task_generic_finish() for pk_task_*async() calls

Closes #2720

See merge request GNOME/gnome-software!2159

(cherry picked from commit fadf0bcc)

031ec49e packagekit: Use pk_task_generic_finish() for pk_task_*async() calls

Merge branch 'use_pk_task_generic_finish' into 'main'

See merge request GNOME/gnome-software!2160

Do nothing when the markup text is broken and starts with a closing element.
It might not happen when it's taken from a well-formatted Appstream data XML,
but better to stay on a safe side.

This had been reported by a GCC analyzer.

Backport !2165 “gs-description-box: Handle broken text” to gnome-47

See merge request GNOME/gnome-software!2166

When the user upgrades the machine, or when for example PackageKit
is updated and switches the appstream data installation from
/var/cache/app-info/ to /var/cache/swcatalog/, then the app-info path
might not be cleared, causing stale data being saved there, while
the swcatalog path is properly updated.

Switch the order of the scanned directories, to have precedence the data
in the swcatalog over the app-info data, if both exist.

gs-appstream: Prefer swcatalog over app-info

See merge request GNOME/gnome-software!2169

Regression from 2016 commit 6f7d1f17 during GsReview ->
AppStream::AsReview switch.

Related: https://gitlab.gnome.org/GNOME/glib/-/issues/3540

Now that https://github.com/ximion/appstream/pull/448 is merged
(available from appstream v0.15.6).

Also refer previous commit which makes this commit possible.

(Cherry pick to gnome-47: fixed minor conflicts)

Backport !2170 “gs-review-row: Fix incorrect signal detail (AsReview::state -> AsReview::flags)” to gnome-47

See merge request GNOME/gnome-software!2172