Make js::MovableCellHasher<JSObject*>::* symbols visible under GCC
These are meant to be exported, but as per a GCC bug this doesn't happen.
This has been merged upstream already, tracked by bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1560064
Will also be backported to esr60 soon.
The underlying GCC bug triggering this is: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90942
mozjs doesn't track symbols in debian right now, this should be added.
IRC discussion about this:
14:52 <smcv> Trevinho: I know very little about the finer points of mozjs60. has the change been accepted upstream? 14:52 <Trevinho> smcv: yes 14:52 <Trevinho> merged already 14:52 <smcv> in a release? 14:52 <Trevinho> no, will be in firefox 69 14:53 <smcv> (I know mozjs60 and releases don't go together amazingly well...) 14:53 <Trevinho> I asked upstream for that... 14:53 <Trevinho> you can see details at https://bugzilla.mozilla.org/show_bug.cgi?id=1560064 14:53 <smcv> please leave details on the MR, I'll try to get to it 14:53 <Trevinho> k 14:54 <Trevinho> there are no functional changes though... We don't track symbols in mozjs AFAIS, so... we can't really check things there 14:54 <Trevinho> but would be nice to have although a bit complicated maybe 14:55 <smcv> if symbols are being added then it really ought to generate a versioned dependency, somehow 14:55 <smcv> maybe the dependency is already versioned, I don't know 14:55 <Trevinho> smcv: the weird thing in this case is that compiling with clang would had the symbols, while are not when using cc 14:55 <smcv> even so 14:55 <smcv> buildds use gcc 14:56 <smcv> old version doesn't have symbol, new version does have symbol, rdep compiled against new version might use symbol => needs a versioned dependency 14:57 <KGB-0> mozjs60 debian/master Marco Trevisan * [update] merge request !4: Make js::MovableCellHasher<JSObject*>::* symbols visible under GCC * https://deb.li/3B7SN 14:58 <Trevinho> yep... 14:58 <smcv> Package: libgjs0g 14:58 <Trevinho> smcv: how are those symbols tracked though? from what I see we don't have a .symbols file in mozjs 14:58 <smcv> Depends: ... libmozjs-60-0, ... 14:58 <smcv> that's... probably bad 14:59 <smcv> it should use dh_makeshlibs -VUpstream-Version at least 14:59 <Trevinho> eh, that's why I was mentioning this 14:59 <Trevinho> otherwise I'd have updated it and added new version 14:59 <Trevinho> probably better to leave to you those steps then :) 15:00 <smcv> and with your proposed change, probably -V"libmozjs-60-0 (>= VERSION)" until the next upstream version 15:00 <Trevinho> so add the symbols, then merge, and then add that 15:00 <smcv> please could you leave a note of all this on the MR? 15:00 <Trevinho> ok