In Alpine Linux, the compiler:

C compiler for the host machine: gcc (gcc 12.2.1 "gcc (Alpine 12.2.1_git20220924-r3) 12.2.1 20220924")
C linker for the host machine: gcc ld.bfd 2.39
Vala compiler for the host machine: valac (valac 0.56.3)

ended up including stdio.h into the C code generated from Vala.
This produced the following (and similar) errors due to
stderr and stdout being #define in stdio.h:

ninja: job failed: gcc -Issh/libseahorse-ssh.a.p -Issh -I../ssh -Icommon -I../common -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gcr-3 -I/usr/include/gck-1 -I/usr/include/p11-kit-1 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/libhandy-1 -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -O0 -DGCR_API_SUBJECT_TO_CHANGE -DGCK_API_SUBJECT_TO_CHANGE -DSECRET_WITH_UNSTABLE -include config.h -Wno-unused-parameter -Wno-missing-field-initializers -Os -fomit-frame-pointer -Os -fomit-frame-pointer -fPIC -pthread -MD -MQ ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o -MF ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o.d -o ssh/libseahorse-ssh.a.p/meson-generated_operation.c.o -c ssh/libseahorse-ssh.a.p/operation.c
In file included from /usr/include/fortify/stdio.h:22,
                 from /usr/include/pango-1.0/pango/pango-utils.h:25,
                 from /usr/include/pango-1.0/pango/pango.h:51,
                 from /usr/include/gtk-3.0/gdk/gdktypes.h:35,
                 from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-3.0/gdk/gdk.h:32,
                 from /usr/include/gtk-3.0/gtk/gtk.h:30,
                 from common/seahorse-common.h:11,
                 from ssh/seahorse-ssh.h:6,
                 from ssh/libseahorse-ssh.a.p/operation.c:25:
ssh/libseahorse-ssh.a.p/operation.c: In function 'seahorse_ssh_operation_operation_async_co':
ssh/libseahorse-ssh.a.p/operation.c:621:17: error: expected identifier before '(' token
  621 |         _data_->stdout = NULL;
      |                 ^~~~~~
ssh/libseahorse-ssh.a.p/operation.c:622:17: error: expected identifier before '(' token
  622 |         _data_->stderr = NULL;
      |                 ^~~~~~

Fix the problem by naming the variables std_out and std_err, as it
was before commit e60e5fd4

Fixes e60e5fd4

Coauthored-by: psykose <alice@ayaya.dev>

(cherry picked from commit 95d9cccfc03ff692043abd84119f115abcaae8b8)

(cherry picked from commit 79fd2fc8e0e2aa1931141c1cada2e40b492a43b9)

Move the prototype for seahorse_pkcs11_backend_initialize into the
header file, so C code generated from Vala sources will use it.
This avoids an implicit function declaration during the C-build
of src/application.vala, and resulting build failures with future
compilers.

Sabri Ünal authored Apr 27, 2023 and Niels De Graef committed May 01, 2023

Use action-name properties to avoid repeating shortcut assignments.

Fix several issues in the SSH Key parsing code, and directly use a
`GInputStream` we can (asynchronously) read from. Take the opportunity
also to add some unit tests that we can run to make sure we're not
regressing on anything.

When seahorse is installed on the host system, you can search for "seahorse" in the GNOME shell overview and the app will appear due to the match on the Exec= line of the desktop file. But when seahorse is installed via flatpak, the Exec= line gets rewritten and there is no keyword match. Adding the app name to the list of keywords will help those of us who rely on old muscle memory to launch the app.

When not logged in, the New Issue URL only redirects to an unhelpful
login page while the Issues page allows you to search for existing
issues and still offers a "New Issue" button.

The icon is called 'org.gnome.seahorse.Application', not 'seahorse'.

Using the application ID for prgname ensures that Wayland compositors could
match the window with the application and show the appropriate icon for
them.

"GPL2+" is not a valid SPDX identifier, so let's fix that.

This should allow us to at least show the icon if Evolution is
installed.

Related: https://gitlab.gnome.org/GNOME/seahorse/-/issues/389

It stores its passwords with a `org.remmina.Remmina` name, so let's map
to that.

Related: https://gitlab.gnome.org/GNOME/seahorse/-/issues/390

If the app uses the network password scheme and doesn't set a label,
we might get into an awkward situation where we set the details, but not
the label (while the latter is searchable, the former isn't).

In that case, set the server URL as the label instead of the details.

Related: https://gitlab.gnome.org/GNOME/seahorse/-/issues/388

A very minor update to fixup the release notes