Respect the allowed output file formats set by apps.

Both can trigger an Unix print dialog, and have the same options. Handle
that too.

When delegating the Access call to GNOME Shell, users can take an
arbitrary amount of time to respond. Having a timeout is detrimental
to that.

Remove the timeout.

Remove the inline struct declaration, and connect to signals manually.
Also make sure to connect to AdwStyleManager signal using the safer
g_signal_connect_object(), since AdwStyleManager can outlive the widget.

(cherry picked from commit caa8d521)

This will allow us to use it in a listmodel

This sets the groundwork for allowing windows to update
their titles dynamically.  At this point we are still
refreshing all of the window (and creating new objects)
on any window change.

Using a listmodel internally will benefit the primary
consumer, screencastwidget.  This way, shellintrospect
will be in charge of all of the window add/remove/changes.

Rather than trying to recreate what shellintrospect is doing,
simply attach the listmodel to the listbox. Use a filter list
model to filter out some of the windows as we were previously
manually doing.

Besides the code benefits, this fixes a user visible issue
where the list completely recreates on any window changes.
This is particularly problematic when a window is selected
(and becomes unselected) on the window change.

That means we'll avoid first emptying the list, then filling it.

This avoids deselecting selected windows.

This makes unselecting a window work again.

It gets too much in the way, and makes it hard to impossible to
implement click-to-toggle as well as not resetting the selection when
using keyboard navigation.

Instead rely on the GtkListBox cursor to navigate, and track selection
state ourself. A tiny CSS class is added to deal with making it look the
same as before.

Closes: https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/93

Automeris naranja authored Apr 30, 2024 and Georges Basile Stavracas Neto committed May 25, 2024

This dialog is now using AdwToolbarView, so it must use
AdwHeaderBar. Also, remove the "titlebar" widget from the C
code, as it's currently not used by any function.

Automeris naranja authored Apr 30, 2024 and Georges Basile Stavracas Neto committed May 25, 2024

This simplifies the code.

Fixes the following warning when cancelling a screen cast dialog.

==343654== Invalid read of size 8
==343654==    at 0x48486A: screen_cast_dialog_handle_free (screencast.c:103)
==343654==    by 0x4848F9: screen_cast_dialog_handle_close (screencast.c:113)
==343654==    by 0x48640D: screen_cast_session_close (screencast.c:916)
==343654==    by 0x489BE6: session_close (session.c:87)
==343654==    by 0x489C7B: handle_close (session.c:117)
==343654==    by 0x410696: _g_dbus_codegen_marshal_BOOLEAN__OBJECT (xdg-desktop-portal-dbus.c:444)
==343654==    by 0x436254: xdp_impl_session_method_marshal_close (xdg-desktop-portal-dbus.c:28756)
==343654==    by 0x4CF9567: g_closure_invoke (gclosure.c:833)
==343654==    by 0x4D0C5FB: signal_emit_unlocked_R.isra.0 (gsignal.c:3928)
==343654==    by 0x4D1311A: signal_emitv_unlocked (gsignal.c:3212)
==343654==    by 0x4D1311A: g_signal_emitv (gsignal.c:3112)
==343654==    by 0x43772F: _xdp_impl_session_skeleton_handle_method_call (xdg-desktop-portal-dbus.c:29485)
==343654==    by 0x4C24D21: g_dbus_interface_method_dispatch_helper (gdbusinterfaceskeleton.c:618)
==343654==  Address 0x1c5acb10 is 16 bytes inside a block of size 40 free'd
==343654==    at 0x4845B2C: free (vg_replace_malloc.c:985)
==343654==    by 0x4848DE: screen_cast_dialog_handle_free (screencast.c:107)
==343654==    by 0x4848F9: screen_cast_dialog_handle_close (screencast.c:113)
==343654==    by 0x484C9C: on_request_handle_close_cb (screencast.c:216)
==343654==    by 0x410696: _g_dbus_codegen_marshal_BOOLEAN__OBJECT (xdg-desktop-portal-dbus.c:444)
==343654==    by 0x42EE5A: xdp_impl_request_method_marshal_close (xdg-desktop-portal-dbus.c:24008)
==343654==    by 0x4CF9567: g_closure_invoke (gclosure.c:833)
==343654==    by 0x4D0BFC8: signal_emit_unlocked_R.isra.0 (gsignal.c:3888)
==343654==    by 0x4D1311A: signal_emitv_unlocked (gsignal.c:3212)
==343654==    by 0x4D1311A: g_signal_emitv (gsignal.c:3112)
==343654==    by 0x42FE83: _xdp_impl_request_skeleton_handle_method_call (xdg-desktop-portal-dbus.c:24590)
==343654==    by 0x4C24D21: g_dbus_interface_method_dispatch_helper (gdbusinterfaceskeleton.c:618)
==343654==    by 0x4C0A837: call_in_idle_cb (gdbusconnection.c:5013)

(cherry picked from commit 887f1d0410be692c4bf57c305438905a4bccd6e9)

This will avoid the base image used for building and in the future
testing potentially changing every pipeline, it will avoid needing to
download and install build dependencies every run, while still making it
convenient to change the contents of the images.

The meson install script is copied from mutter.

Julian Sparber authored Jun 21, 2024 and Georges Basile Stavracas Neto committed Jul 11, 2024

The code is mostly taken from xdg-desktop-portal-gtk.

Julian Sparber authored Jun 21, 2024 and Georges Basile Stavracas Neto committed Jul 11, 2024

GNOME Shell's private API wasn't able to handle the ActionInvoked signal
now that it was added there we can use it to implement the ActionInvoked
signal.

(cherry picked from commit 77ef3febe566f4cea5d4a212f09be2f82fc2f36b)

António Fernandes authored Jul 28, 2024 and Georges Basile Stavracas Neto committed Aug 06, 2024

Non-sandboxed apps are encouraged to use the portal API as well, so
this comment is no longer relevant.

António Fernandes authored Jul 29, 2024 and Georges Basile Stavracas Neto committed Aug 06, 2024

So far we have been using GtkFileChooserDialog to provide the UI for
the FileChooser portal, as inherited from xdg-desktop-portal-gtk.

But GtkFileChooserDialog is deprecated and for various other reasons
nautilus is now providing a FileChooser portal implementation.

Ideally, nautilus could provide the implementation directly and we
could drop ours. Unfortunately, due to a bug around the color-scheme
setting involving portals in libadwaita, if nautilus itself presents
is declared as a portal implementation with a .portal file, then it
will not follow the dark mode setting.

So, for the time being, we still act as the backend implementing the
FileChooser portal, but relay messages into/from nautilus instead,
almost unchanged.

"Almost" because, for convenience, we keep the responsibility of
saving and restoring the previously used folders for each app. We
also keep the responsibility of adding files to recents for now.

Part of: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3401