Skip to content

Brainstorm (import_)merge_request.md test improvements

I didn't want to file a MR yet, but first ask for ideas on what the template https://salsa.debian.org/go-team/flight-deck/-/blob/main/web/templates/merge_request.md and https://salsa.debian.org/go-team/flight-deck/-/blob/main/web/templates/import_merge_request.md should be saying and how people testing out Flight Deck perceive it.

  • Should it be shorter? There is some repetition, what actually is the core message?
  • Should it emphasize that most important part in the MR review is to check that the config change translates into correct changes in the plan-mr job output?
  • Shuld the template say something about who should review the MR? Is the intent that Go team members review their own MRs and merge them? We are not really reviewing human submissions, but checking correctness of autogenerated changes, so the person who initiated the MR can also review and merge it?
    • Only if the submitter is a new contributor and not a Go team member, they need to get a Go team member to approve it. Should the template say where to ask for review? Probably no one wants to just approve a repository creation, but instead review a new package and sponsor it, so maybe just say "Notify your mentor so they can approve this" etc?