Commit 9e1934dc authored by Nigel Tao's avatar Nigel Tao

go.crypto/sha3: fix typo; remove 4 million map lookups (5% of "go test"

time); delete some comments that didn't add much and were incorrect
anyway (the test specification was tc, not t).

R=jcb
CC=agl, golang-dev
https://codereview.appspot.com/7665045
parent 97102e29
......@@ -86,7 +86,7 @@ var shortKeccakTestVectors = []testVector{
// ExtremelyLongMsgKAT taken from http://keccak.noekeon.org/.
var longKeccakTestVectors = []testVector{
{
desc: "long-1GiB",
desc: "long-64MiB",
input: []byte("abcdefghbcdefghicdefghijdefghijkefghijklfghijklmghijklmnhijklmno"),
repeat: 1024 * 1024,
want: map[string]string{
......@@ -106,13 +106,12 @@ func TestKeccakVectors(t *testing.T) {
}
for _, tc := range testCases {
for alg, want := range tc.want {
testDigests[alg].Reset()
// Write input data each digests, based on the test specification t.
d := testDigests[alg]
d.Reset()
for i := 0; i < tc.repeat; i++ {
testDigests[alg].Write(tc.input)
d.Write(tc.input)
}
// Verify that each algorithm version produced the expected output.
got := strings.ToUpper(hex.EncodeToString(testDigests[alg].Sum(nil)))
got := strings.ToUpper(hex.EncodeToString(d.Sum(nil)))
if got != want {
t.Errorf("%s, alg=%s\ngot %q, want %q", tc.desc, alg, got, want)
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment