1. 25 Oct, 2013 2 commits
  2. 24 Oct, 2013 1 commit
    • Dave Cheney's avatar
      go.crypto/ssh: ensure {Server,Client}Conn do not expose io.ReadWriter · a2a307ee
      Dave Cheney authored
      Transport should not be a ReadWriter. It can only write packets, i.e. no partial reads or writes. Furthermore, you can currently do ClientConn.Write() while the connection is live, which sends raw bytes over the connection. Doing so will confuse the transports because the data is not encrypted.
      
      As a consequence, ClientConn and ServerConn stop being a net.Conn
      
      Finally, ensure that {Server,Client}Conn implement LocalAddr and RemoteAddr methods that previously were exposed by an embedded net.Conn field.
      
      R=hanwen
      CC=golang-dev
      https://codereview.appspot.com/16610043
      a2a307ee
  3. 10 Oct, 2013 1 commit
  4. 24 Sep, 2013 1 commit
  5. 13 Sep, 2013 1 commit
  6. 09 Sep, 2013 1 commit
  7. 05 Sep, 2013 1 commit
  8. 27 Aug, 2013 1 commit
  9. 21 Jun, 2013 1 commit
  10. 10 Jun, 2013 1 commit
  11. 07 Jun, 2013 1 commit
  12. 06 Jun, 2013 2 commits
  13. 15 Dec, 2012 1 commit
  14. 10 Dec, 2012 1 commit
  15. 29 Jun, 2012 1 commit
  16. 20 Apr, 2012 1 commit
    • Adam Langley's avatar
      ssh: cosmetic cleanups · bdd74271
      Adam Langley authored
      These are the cosmetic cleanups from the bits of code that I
      rereviewed.
      
      1) stringLength now takes a int; the length of the string. Too many
         callers were allocating with stringLength([]byte(s)) and
         stringLength only needs to call len().
      
      2) agent.go now has sendAndReceive to remove logic that was
         duplicated.
      
      3) We now reject negative DH values
      
      4) We now reject empty packets rather than crashing.
      
      R=dave, jonathan.mark.pittman
      CC=golang-dev
      http://codereview.appspot.com/6061052
      bdd74271
  17. 01 Apr, 2012 1 commit
  18. 23 Feb, 2012 1 commit
  19. 25 Jan, 2012 1 commit