Fix EXTRACTOR_OVERRIDE: parameter not set

Gianfranco Costamagnarequested to merge
locutusofborg/debootstrap:master into master

On Ubuntu 22.04 (jammy):

$ cat test.yaml
---
name: test
mmdebstrap:
  suite: jammy
  target: root.squashfs
  variant: minbase
$  bdebstrap -c test.yaml
I: automatically chosen mode: unshare
I: chroot architecture amd64 is equal to the host's architecture
sh: 48: /usr/share/debootstrap/scripts/gutsy: EXTRACTOR_OVERRIDE: parameter not set
Can't exec "tar2sqfs": No such file or directory at /usr/bin/mmdebstrap line 5178.
E: cannot exec tar2sqfs --version: No such file or directory
E: failed to start tar2sqfs --version
2022-05-06 10:22:50,438 bdebstrap ERROR: mmdebstrap failed with exit code 2. See above for details.

Following command will succeed now:

sudo DEBOOTSTRAP_DIR=`pwd` sh -u ./debootstrap unstable ./unstable-chroot

dp/p: Drop unused support for changing increment

The functions dp and p are always called without parameters. To simplify the code and fix shellcheck, drop support for specifying the increment.

Fix several shellcheck complaints

Fix several shellcheck complaints except for those where word splitting is desired:

shellcheck -e SC1090,SC1091,SC2034,SC2046,SC2086,SC2089,SC2090,SC2119,SC2153,SC2209,SC3043 \
    -s sh -x debootstrap functions scripts/gutsy scripts/kali scripts/sid

LP: #1971951 Signed-off-by: Benjamin Drung bdrung@ubuntu.com

Merge request reports