Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • H httpcomponents-client
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Debian Java MaintainersDebian Java Maintainers
  • httpcomponents-client
  • Merge requests
  • !1

Use system suffix list

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Andrius Merkys requested to merge merkys/httpcomponents-client:use-system-suffix-list into master Dec 13, 2019
  • Overview 1
  • Commits 6
  • Changes 4

I suggest using system-provided list of domain name suffixes instead of downloading it from publicsuffix.org each time the upstream package is updated.

Advantages:

  • More frequently updated domain name suffixes list;
  • No need to repackage the source via orig-tar.sh.

However, there seem to be no tests covering this piece of code. Thus I'd be happy if someone could verify that the PublicSuffixMatcherLoader.java works as expected.

Edited Dec 13, 2019 by Andrius Merkys
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: use-system-suffix-list