1. 06 Aug, 2019 2 commits
  2. 05 Aug, 2019 2 commits
    • Felix Lechner's avatar
      Proper fix for the null improperly addressed by commit d55f56ec. · 1283833e
      Felix Lechner authored
      Thanks to Guilhem Moulin for the fix!
      
      Gbp-Dch: ignore
      1283833e
    • Felix Lechner's avatar
      Revert "Fix use of uninitialized value in checks/files.pm." · 244f7624
      Felix Lechner authored
      This reverts commit d55f56ec.
      
      Commit d55f56ec broke the following semantics:
      
        $ perl -we 'my $p = "usr/sbin/foo"; print "/$1bin/$2\n" if $p =~ m,^(usr/)?sbin/(.+),;'
        /usr/bin/foo
        $ perl -we 'my $p = "sbin/foo"; print "/$1bin/$2\n" if $p =~ m,^(usr/)?sbin/(.+),;'
        Use of uninitialized value $1 in concatenation (.) or string at -e line 1.
        /bin/foo
      
      So if $fname starts with usr/sbin/ (resp. sbin/) a corresponding name
      with the /usr/bin/ (resp. /bin/) prefix is appended to @bin_binaries.
      It also spews a warning for sbin/; I guess the desired outcome is to
      silence that warning but preserve the overall behavior, right?  This
      is no longer what happens: while names starting with usr/sbin/ are
      dealt with like before, those starting with sbin/ are now ignored.
      
      More information may be available here:
      
        lintian/lintian!235 (comment 100475)
      
      Thanks to Guilhem Moulin for pointing it out!
      
      Gbp-Dch: ignore
      244f7624
  3. 04 Aug, 2019 5 commits
    • Felix Lechner's avatar
      Mark the test 'changelog-file-become-native' is non-native in the changelog-file check. · 84b9e71a
      Felix Lechner authored
      Per the test's description, it is designed for when a maintainer
      forgets to add Debian revision to an upstream version in the Debian
      changelog. Such a package is always non-native, but the test used a
      native skeleton.  Instead uses a non-native skeleton for the test.
      
      The inconsistency showed up when version parsing was centralized.
      
      Also adjusts the test's expected tags for related changes.
      
      Gbp-Dch: ignore
      84b9e71a
    • Felix Lechner's avatar
      Use non-native skeleton in test changelog-file-experimental for check changelog-file. · e6c34703
      Felix Lechner authored
      The tag non-consecutive-debian-revision is intended for non-native
      packages, but the test for it uses a native skeleton. The
      inconsistency showed up when version parsing was centralized, and the
      tag disappeared. Instead uses the non-native skeleton to trigger the
      non-native tag.
      
      Also adjusts the expected tags for related changes.
      
      Gbp-Dch: ignore
      e6c34703
    • Felix Lechner's avatar
      In the test runner, improve error output for tag-related and literal tests. · 95a27afe
      Felix Lechner authored
      For literal tests, the runner now also shows a diff. For tag-related
      tests, the runner highlights missing and unexpected tags in addition
      to showing a diff. The highlighted tags are carefully calculated based
      on the declared checks and disregard unrelated nuisance tags.
      
      Reuses some code between match strategies for better clarity,
      consistency and maintainability.
      
      Gbp-Dch: ignore
      95a27afe
    • Felix Lechner's avatar
      In Test::Lintian::Output::Universal, return unique tag names. · 50946fca
      Felix Lechner authored
      Somehow these names were no longer unique. Perhaps that part was
      dropped by code changes. This commit enables better error reporting
      for tag mismatches in the test runner.
      
      Gbp-Dch: ignore
      50946fca
    • Felix Lechner's avatar
      Update t/scripts/harness/check_result.t to newer test format. · c3a3400a
      Felix Lechner authored
      The test case was updated to declare a field Check, which did not
      exist when the script was written. Also, the defaults are properly
      parsed in addition to the test specification.
      
      The changes are not essential but will make the test work better in
      the future.
      
      Gbp-Dch: ignore
      c3a3400a
  4. 03 Aug, 2019 23 commits
  5. 31 Jul, 2019 1 commit
  6. 30 Jul, 2019 2 commits
    • Chris Lamb's avatar
      Correct multiple "gobject-introspection" typos. Thanks to Simon McVittie... · 40632738
      Chris Lamb authored
      Correct multiple "gobject-introspection" typos. Thanks to Simon McVittie (smcv) for the kindly pointer. (Closes: #933394)
      40632738
    • Felix Lechner's avatar
      Eliminate stray message from internal harness test. · d1bd76a9
      Felix Lechner authored
      On occasion, tests printed stray messages in the TAP harness. It
      happened in every test run with t/scripts/harness/check_result.t,
      which produced odd looking lines like:
      
          # +++ ../../../../tmp/en5zJjXdAX/distribution-multiple-bad/tags.nomatch
      
      Removes the command 'diag', which produced the stray message.
      
      The stray message actually appeared whenever test results did not
      match expectations. That did not normally happen, except in the
      internal test which looked for that condition. When other tests failed
      during Lintian development, the stray message was probably lost among
      other more voluminous error messages.
      
      Gbp-Dch: ignore
      d1bd76a9
  7. 29 Jul, 2019 5 commits