Skip to content
Snippets Groups Projects
Commit 0defeee3 authored by Guido Günther's avatar Guido Günther
Browse files

Fix crashes due to missing initialization of the error system

parent 85c3f78f
No related branches found
No related tags found
No related merge requests found
......@@ -6,3 +6,4 @@ Autodetect-if-the-remote-nc-command-supports-the-q-o.patch
patch-qemuMonitorTextGetMigrationStatus-to-intercept.patch
Disable-CHECKSUM-rule.patch
Debianize-libvirt-guests.patch
virsh-Initialize-library-before-calling-virResetLast.patch
From: Debian Libvirt Maintainers <pkg-libvirt-maintainers@lists.alioth.debian.org>
Date: Mon, 11 Apr 2011 23:31:09 +0200
Subject: virsh: Initialize library before calling virResetLastError
so the error system gets intialized via virErrorInitialize.
Otherwise this results in crashes like:
#0 0x40567537 in raise () from /lib/libc.so.6
(gdb) bt
#0 0x40567537 in raise () from /lib/libc.so.6
#1 0x4056a922 in abort () from /lib/libc.so.6
#2 0x4059dfbd in ?? () from /lib/libc.so.6
#3 0x405a80ca in ?? () from /lib/libc.so.6
#4 0x405a9918 in ?? () from /lib/libc.so.6
#5 0x405aca5d in free () from /lib/libc.so.6
#6 0x40057803 in virFree (ptrptr=0x892e048) at util/memory.c:310
#7 0x400683cf in virResetError (err=0x892e028) at util/virterror.c:408
#8 0x40068673 in virResetLastError () at util/virterror.c:439
#9 0x4004bf53 in virEventRegisterDefaultImpl () at util/event.c:150
#10 0x08066e78 in vshInit (argc=5, argv=0xbf9c2cd4) at virsh.c:12075
#11 main (argc=5, argv=0xbf9c2cd4) at virsh.c:12751
---
tools/virsh.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 19e3449..e6a0694 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12072,6 +12072,9 @@ vshInit(vshControl *ctl)
/* set up the signals handlers to catch disconnections */
vshSetupSignals();
+ if (virInitialize() < 0)
+ return FALSE;
+
if (virEventRegisterDefaultImpl() < 0)
return FALSE;
--
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment