Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
L
libvirt
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Libvirt Packaging Team
libvirt
Commits
0defeee3
Commit
0defeee3
authored
14 years ago
by
Guido Günther
Browse files
Options
Downloads
Patches
Plain Diff
Fix crashes due to missing initialization of the error system
parent
85c3f78f
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/series
+1
-0
1 addition, 0 deletions
debian/patches/series
debian/patches/virsh-Initialize-library-before-calling-virResetLast.patch
+41
-0
41 additions, 0 deletions
...irsh-Initialize-library-before-calling-virResetLast.patch
with
42 additions
and
0 deletions
debian/patches/series
+
1
−
0
View file @
0defeee3
...
...
@@ -6,3 +6,4 @@ Autodetect-if-the-remote-nc-command-supports-the-q-o.patch
patch-qemuMonitorTextGetMigrationStatus-to-intercept.patch
Disable-CHECKSUM-rule.patch
Debianize-libvirt-guests.patch
virsh-Initialize-library-before-calling-virResetLast.patch
This diff is collapsed.
Click to expand it.
debian/patches/virsh-Initialize-library-before-calling-virResetLast.patch
0 → 100644
+
41
−
0
View file @
0defeee3
From: Debian Libvirt Maintainers <pkg-libvirt-maintainers@lists.alioth.debian.org>
Date: Mon, 11 Apr 2011 23:31:09 +0200
Subject: virsh: Initialize library before calling virResetLastError
so the error system gets intialized via virErrorInitialize.
Otherwise this results in crashes like:
#0 0x40567537 in raise () from /lib/libc.so.6
(gdb) bt
#0 0x40567537 in raise () from /lib/libc.so.6
#1 0x4056a922 in abort () from /lib/libc.so.6
#2 0x4059dfbd in ?? () from /lib/libc.so.6
#3 0x405a80ca in ?? () from /lib/libc.so.6
#4 0x405a9918 in ?? () from /lib/libc.so.6
#5 0x405aca5d in free () from /lib/libc.so.6
#6 0x40057803 in virFree (ptrptr=0x892e048) at util/memory.c:310
#7 0x400683cf in virResetError (err=0x892e028) at util/virterror.c:408
#8 0x40068673 in virResetLastError () at util/virterror.c:439
#9 0x4004bf53 in virEventRegisterDefaultImpl () at util/event.c:150
#10 0x08066e78 in vshInit (argc=5, argv=0xbf9c2cd4) at virsh.c:12075
#11 main (argc=5, argv=0xbf9c2cd4) at virsh.c:12751
---
tools/virsh.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 19e3449..e6a0694 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12072,6 +12072,9 @@
vshInit(vshControl *ctl)
/* set up the signals handlers to catch disconnections */
vshSetupSignals();
+ if (virInitialize() < 0)
+ return FALSE;
+
if (virEventRegisterDefaultImpl() < 0)
return FALSE;
--
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment