Skip to content
Snippets Groups Projects
Commit 7302affb authored by Guido Günther's avatar Guido Günther
Browse files

New patch Make-sure-the-rundir-is-accessible-by-the-user.patch

Make sure the rundir is accessible by the user

Closes: #614210
parent 28df4357
No related branches found
No related tags found
No related merge requests found
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx@sigxcpu.org>
Date: Wed, 9 Mar 2011 14:15:48 +0100
Subject: Make sure the rundir is accessible by the user
otherwise the user might not have enough permissions to access the
socket if root's umask is 077.
http://bugs.debian.org/614210
---
daemon/libvirtd.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index f4b3327..7ce75f4 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -3225,16 +3225,20 @@ int main(int argc, char **argv) {
/* Ensure the rundir exists (on tmpfs on some systems) */
if (geteuid() == 0) {
const char *rundir = LOCALSTATEDIR "/run/libvirt";
+ mode_t old_umask;
+ old_umask = umask(022);
if (mkdir (rundir, 0755)) {
if (errno != EEXIST) {
char ebuf[1024];
VIR_ERROR(_("unable to create rundir %s: %s"), rundir,
virStrerror(errno, ebuf, sizeof(ebuf)));
ret = VIR_DAEMON_ERR_RUNDIR;
+ umask(old_umask);
goto error;
}
}
+ umask(old_umask);
}
/* Beyond this point, nothing should rely on using
--
......@@ -8,3 +8,4 @@ Disable-CHECKSUM-rule.patch
Debianize-libvirt-guests.patch
Don-t-pass-empty-arguments-to-dnsmasq.patch
Do-not-add-drive-boot-on-param-when-a-kernel-is-spec.patch
Make-sure-the-rundir-is-accessible-by-the-user.patch
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment