Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
L
libvirt
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Libvirt Packaging Team
libvirt
Commits
9a4ad478
Commit
9a4ad478
authored
1 year ago
by
Andrea Bolognani
Browse files
Options
Downloads
Patches
Plain Diff
patches: Add backport/scripts-Make-check-symfile.py-work-on-alpha.patch
Fixes compilation on alpha.
parent
6b2a7bb5
No related branches found
No related tags found
1 merge request
!215
Prepare 10.0.0-2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/backport/scripts-Make-check-symfile.py-work-on-alpha.patch
+58
-0
58 additions, 0 deletions
...ackport/scripts-Make-check-symfile.py-work-on-alpha.patch
debian/patches/series
+1
-0
1 addition, 0 deletions
debian/patches/series
with
59 additions
and
0 deletions
debian/patches/backport/scripts-Make-check-symfile.py-work-on-alpha.patch
0 → 100644
+
58
−
0
View file @
9a4ad478
From: Andrea Bolognani <abologna@redhat.com>
Date: Sat, 20 Jan 2024 18:20:21 +0100
Subject: scripts: Make check-symfile.py work on alpha
The script expects each of the symbols that it looks for to
be in one of three sections, which in nm(1) are described as
follows:
T - The symbol is in the text (code) section.
B - The symbol is in the BSS data section. This section
typically contains zero-initialized or uninitialized
data, although the exact behavior is system dependent.
D - The symbol is in the initialized data section.
When building on alpha, however, some of the symbols show up
in one of two additional sections, specifically:
S - The symbol is in an uninitialized or zero-initialized
data section for small objects.
G - The symbol is in an initialized data section for small
objects.
In other words, S is the same as B and G is the same as D,
except with some optimization for small objects that for some
reason is applied on alpha but not on other architectures.
I have confirmed that, for all the symbols that the script
complained about being missing on alpha, the section is the
expected one, that is, symbols that are reported as B on x86
are reported as S on alpha, and symbols that are reported as
D on x86 are reported as G on alpha.
Note that, while the B section doesn't seem to be used at all
on alpha, at least in our case, the D section still is.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit 2757e91c2b28b704d9a0b586fb60012450110b1a)
Forwarded: not-needed
Origin: https://gitlab.com/libvirt/libvirt/-/commit/2757e91c2b28b704d9a0b586fb60012450110b1a
---
scripts/check-symfile.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/check-symfile.py b/scripts/check-symfile.py
index 0f6e780..c2ee405 100755
--- a/scripts/check-symfile.py
+++ b/scripts/check-symfile.py
@@ -61,7 +61,7 @@
for elflib in elflibs:
for line in nm:
line = line.decode("utf-8")
- symmatch = re.search(r'''^\S+\s(?:[TBD])\s(\S+)\s*$''', line)
+ symmatch = re.search(r'''^\S+\s(?:[TBSDG])\s(\S+)\s*$''', line)
if symmatch is None:
continue
This diff is collapsed.
Click to expand it.
debian/patches/series
+
1
−
0
View file @
9a4ad478
backport/scripts-Make-check-symfile.py-work-on-alpha.patch
forward/Reduce-udevadm-settle-timeout-to-10-seconds.patch
debian/Debianize-libvirt-guests.patch
debian/apparmor_profiles_local_include.patch
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment