Commit bf0bc67e authored by Guido Günther's avatar Guido Günther
Browse files

New upstream version 5.2.0~rc2

parent 932fa9d4

ChangeLog

+104 −0
Original line number Diff line number Diff line 
2019-03-30  John Ferlan  <jferlan@redhat.com>









	tools: Tweak wording for iothreadset









	Update the wording to note the values for polling are purely dynamic









	and won't be saved across domain stop/(re)start or save/restore.

















	Reviewed-by: Laine Stump <laine@laine.org>

















2019-03-29  Ján Tomko  <jtomko@redhat.com>

















	qemu: error out on attempt to change blkiotune group name









	Check that the attribute is the same in qemuDomainDiskChangeSupported









	in case somebody tries to change it using the UpdateDevice API.

















	https://bugzilla.redhat.com/show_bug.cgi?id=1601677

















	Reviewed-by: Laine Stump <laine@laine.org>

















2019-03-29  Ján Tomko  <jtomko@redhat.com>

















	qemu: introduce CHECK_STREQ_NULLABLE in qemuDomainDiskChangeSupported









	A macro for comparing string fields of the disk.

















	https://bugzilla.redhat.com/show_bug.cgi?id=1601677

















	Reviewed-by: Laine Stump <laine@laine.org>

















2019-03-29  Ján Tomko  <jtomko@redhat.com>

















	Revert "qemu: emit error when trying to update blkiotune group_name in qemuDomainChangeDiskLive"









	https://bugzilla.redhat.com/show_bug.cgi?id=1601677

















	This reverts commit 047cfb05ee949325e77726531fd381820be8dc62









	Using numeric comparison on strings means we reject every update









	that does include the group name, even if it's unchanged.

















	Reviewed-by: Laine Stump <laine@laine.org>

















2019-03-28  Eric Blake  <eblake@redhat.com>

















	virsh: Don't infloop on snapshot/storage_vol failure









	Most of our completers used the pattern:









	if ((nITEM = virITEMListAll()) < 0)









	    return NULL;

















	but the virDomainSnapshot and virStorageVolume completers were instead









	using goto error. If the ListAll fails with -1, the cleanup label was









	running a loop of 'size_t i < int nITEM', which is an extreme waste of









	CPU cycles. Broken since their introduction in v4.1.

















	Fixes: f81f8b62









	Fixes: 4cb4b649









	Reported-by: Ján Tomko <jtomko@redhat.com>

















2019-03-28  Eric Blake  <eblake@redhat.com>

















	snapshot: Improve logic of virDomainMomentMoveChildren









	Even though Coverity can prove that 'last' is always set if the prior









	loop executed, gcc 8.0.1 cannot:

















	  CC       conf/libvirt_conf_la-virdomainmomentobjlist.lo









	../../src/conf/virdomainmomentobjlist.c: In function 'virDomainMomentMoveChildren':









	../../src/conf/virdomainmomentobjlist.c:178:19: error: 'last' may be used uninitialized in this function [-Werror=maybe-uninitialized]









	         last->sibling = to->first_child;









	         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~

















	Rewrite the loop to a form that should be easier for static analysis









	to work with.

















	Fixes: ced0898f86bf









	Reported-by: Bjoern Walk <bwalk@linux.ibm.com>









	Reviewed-by: Ján Tomko <jtomko@redhat.com>

















2019-03-28  Laine Stump  <laine@laine.org>

















	util: suppress unimportant ovs-vsctl errors when getting interface stats









	commit edaf13565 modified the stats retrieval for OVS interfaces to









	not fail when one of the fields was unrecognized by the ovs-vsctl









	command, but ovs-vsctl was still returning an error, and libvirt was









	cluttering the logs with these inconsequential error messages.

















	This patch modifies the GET_STAT macro to add "--if-exists" to the









	ovs-vsctl command, which causes it to return an empty string (and exit









	with success) if the requested statistic isn't in its database, thus









	eliminating the ugly error messages from the log.

















	Resolves: https://bugzilla.redhat.com/1683175

















2019-03-28  Peter Krempa  <pkrempa@redhat.com>

















	qemu: address: Stop reporting warning when USB address can't be released









	The warning is reported at a code path which already reports a proper









	error so it's pointless to add yet another line into logs.

















	qemu: Always use 'alias' in warning message when removing USB address









	Avoid the extra parameter passing in the disk 'dst' parameter to be









	reported instead of the device alias. Using 'dst' instead of alias does









	not add much value.

















	qemu: hotplug: Don't release USB address twice when removing disk









	qemuDomainRemoveDiskDevice calls qemuDomainReleaseDeviceAddress which









	already calls virDomainUSBAddressRelease so we don't need to call it









	again.

















2019-03-28  Michal Privoznik  <mprivozn@redhat.com>

















	qemuxml2argvtest: Drop dependency between testInfoArgName and virQEMUCapsFlags enums

























docs/devhelp/libvirt-virterror.html



+7
−3






























Original line number
Diff line number
Diff line







@@ -34,7 +34,7 @@







      <span class="refentrytitle">virterror</span>









    </h2>









    <p>virterror - error handling interfaces for the libvirt library</p>









    <p>Provides the interfaces of the libvirt library to handle errors raised while using the library.  Copyright (C) 2006-2016 Red Hat, Inc.  This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version.  This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more details.  You should have received a copy of the GNU Lesser General Public License along with this library.  If not, see &lt;http://www.gnu.org/licenses/&gt;. </p>









    <p>Provides the interfaces of the libvirt library to handle errors raised while using the library.  Copyright (C) 2006-2019 Red Hat, Inc.  This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version.  This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more details.  You should have received a copy of the GNU Lesser General Public License along with this library.  If not, see &lt;http://www.gnu.org/licenses/&gt;. </p>









    <div class="refsynopsisdiv">









      <h2>Synopsis</h2>









      <pre class="synopsis">typedef struct _virError <a href="#virError">virError</a>;








@@ -153,7 +153,8 @@ void	<a href="#virSetErrorFunc">virSetErrorFunc</a>			(void * userData, <br/>







    <a name="VIR_FROM_LIBSSH">VIR_FROM_LIBSSH</a> = 66 /* Error from libssh connection transport */









    <a name="VIR_FROM_RESCTRL">VIR_FROM_RESCTRL</a> = 67 /* Error from resource control */









    <a name="VIR_FROM_FIREWALLD">VIR_FROM_FIREWALLD</a> = 68 /* Error from firewalld */









    <a name="VIR_ERR_DOMAIN_LAST">VIR_ERR_DOMAIN_LAST</a> = 69









    <a name="VIR_FROM_DOMAIN_CHECKPOINT">VIR_FROM_DOMAIN_CHECKPOINT</a> = 69 /* Error from domain checkpoint */









    <a name="VIR_ERR_DOMAIN_LAST">VIR_ERR_DOMAIN_LAST</a> = 70









};









</pre><p/>









</div>








@@ -269,7 +270,10 @@ void	<a href="#virSetErrorFunc">virSetErrorFunc</a>			(void * userData, <br/>







    <a name="VIR_ERR_DEVICE_MISSING">VIR_ERR_DEVICE_MISSING</a> = 99 /* fail to find the desired device */









    <a name="VIR_ERR_INVALID_NWFILTER_BINDING">VIR_ERR_INVALID_NWFILTER_BINDING</a> = 100 /* invalid nwfilter binding */









    <a name="VIR_ERR_NO_NWFILTER_BINDING">VIR_ERR_NO_NWFILTER_BINDING</a> = 101 /* no nwfilter binding */









    <a name="VIR_ERR_NUMBER_LAST">VIR_ERR_NUMBER_LAST</a> = 102









    <a name="VIR_ERR_INVALID_DOMAIN_CHECKPOINT">VIR_ERR_INVALID_DOMAIN_CHECKPOINT</a> = 102 /* invalid domain checkpoint */









    <a name="VIR_ERR_NO_DOMAIN_CHECKPOINT">VIR_ERR_NO_DOMAIN_CHECKPOINT</a> = 103 /* domain checkpoint not found */









    <a name="VIR_ERR_NO_DOMAIN_BACKUP">VIR_ERR_NO_DOMAIN_BACKUP</a> = 104 /* domain backup job id not found */









    <a name="VIR_ERR_NUMBER_LAST">VIR_ERR_NUMBER_LAST</a> = 105









};









</pre><p/>









</div>
































docs/devhelp/libvirt.devhelp



+8
−0






























Original line number
Diff line number
Diff line







@@ -185,6 +185,7 @@







    <function name="VIR_MIGRATE_PARAM_GRAPHICS_URI" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_GRAPHICS_URI"/>









    <function name="VIR_MIGRATE_PARAM_LISTEN_ADDRESS" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_LISTEN_ADDRESS"/>









    <function name="VIR_MIGRATE_PARAM_MIGRATE_DISKS" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_MIGRATE_DISKS"/>









    <function name="VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS"/>









    <function name="VIR_MIGRATE_PARAM_PERSIST_XML" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_PERSIST_XML"/>









    <function name="VIR_MIGRATE_PARAM_URI" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_URI"/>









    <function name="VIR_NETWORK_EVENT_CALLBACK" link="libvirt-libvirt-network.html#VIR_NETWORK_EVENT_CALLBACK"/>








@@ -770,6 +771,7 @@







    <function name="VIR_DOMAIN_SNAPSHOT_LIST_NO_LEAVES" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_LIST_NO_LEAVES"/>









    <function name="VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA"/>









    <function name="VIR_DOMAIN_SNAPSHOT_LIST_ROOTS" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_LIST_ROOTS"/>









    <function name="VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL"/>









    <function name="VIR_DOMAIN_SNAPSHOT_REVERT_FORCE" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_REVERT_FORCE"/>









    <function name="VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED"/>









    <function name="VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING" link="libvirt-libvirt-domain-snapshot.html#VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING"/>








@@ -834,6 +836,7 @@







    <function name="VIR_ERR_INVALID_ARG" link="libvirt-virterror.html#VIR_ERR_INVALID_ARG"/>









    <function name="VIR_ERR_INVALID_CONN" link="libvirt-virterror.html#VIR_ERR_INVALID_CONN"/>









    <function name="VIR_ERR_INVALID_DOMAIN" link="libvirt-virterror.html#VIR_ERR_INVALID_DOMAIN"/>









    <function name="VIR_ERR_INVALID_DOMAIN_CHECKPOINT" link="libvirt-virterror.html#VIR_ERR_INVALID_DOMAIN_CHECKPOINT"/>









    <function name="VIR_ERR_INVALID_DOMAIN_SNAPSHOT" link="libvirt-virterror.html#VIR_ERR_INVALID_DOMAIN_SNAPSHOT"/>









    <function name="VIR_ERR_INVALID_INTERFACE" link="libvirt-virterror.html#VIR_ERR_INVALID_INTERFACE"/>









    <function name="VIR_ERR_INVALID_MAC" link="libvirt-virterror.html#VIR_ERR_INVALID_MAC"/>








@@ -856,6 +859,8 @@







    <function name="VIR_ERR_NO_CONNECT" link="libvirt-virterror.html#VIR_ERR_NO_CONNECT"/>









    <function name="VIR_ERR_NO_DEVICE" link="libvirt-virterror.html#VIR_ERR_NO_DEVICE"/>









    <function name="VIR_ERR_NO_DOMAIN" link="libvirt-virterror.html#VIR_ERR_NO_DOMAIN"/>









    <function name="VIR_ERR_NO_DOMAIN_BACKUP" link="libvirt-virterror.html#VIR_ERR_NO_DOMAIN_BACKUP"/>









    <function name="VIR_ERR_NO_DOMAIN_CHECKPOINT" link="libvirt-virterror.html#VIR_ERR_NO_DOMAIN_CHECKPOINT"/>









    <function name="VIR_ERR_NO_DOMAIN_METADATA" link="libvirt-virterror.html#VIR_ERR_NO_DOMAIN_METADATA"/>









    <function name="VIR_ERR_NO_DOMAIN_SNAPSHOT" link="libvirt-virterror.html#VIR_ERR_NO_DOMAIN_SNAPSHOT"/>









    <function name="VIR_ERR_NO_INTERFACE" link="libvirt-virterror.html#VIR_ERR_NO_INTERFACE"/>








@@ -926,6 +931,7 @@







    <function name="VIR_FROM_DEVICE" link="libvirt-virterror.html#VIR_FROM_DEVICE"/>









    <function name="VIR_FROM_DOM" link="libvirt-virterror.html#VIR_FROM_DOM"/>









    <function name="VIR_FROM_DOMAIN" link="libvirt-virterror.html#VIR_FROM_DOMAIN"/>









    <function name="VIR_FROM_DOMAIN_CHECKPOINT" link="libvirt-virterror.html#VIR_FROM_DOMAIN_CHECKPOINT"/>









    <function name="VIR_FROM_DOMAIN_SNAPSHOT" link="libvirt-virterror.html#VIR_FROM_DOMAIN_SNAPSHOT"/>









    <function name="VIR_FROM_ESX" link="libvirt-virterror.html#VIR_FROM_ESX"/>









    <function name="VIR_FROM_EVENT" link="libvirt-virterror.html#VIR_FROM_EVENT"/>








@@ -1006,6 +1012,7 @@







    <function name="VIR_MIGRATE_NON_SHARED_DISK" link="libvirt-libvirt-domain.html#VIR_MIGRATE_NON_SHARED_DISK"/>









    <function name="VIR_MIGRATE_NON_SHARED_INC" link="libvirt-libvirt-domain.html#VIR_MIGRATE_NON_SHARED_INC"/>









    <function name="VIR_MIGRATE_OFFLINE" link="libvirt-libvirt-domain.html#VIR_MIGRATE_OFFLINE"/>









    <function name="VIR_MIGRATE_PARALLEL" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PARALLEL"/>









    <function name="VIR_MIGRATE_PAUSED" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PAUSED"/>









    <function name="VIR_MIGRATE_PEER2PEER" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PEER2PEER"/>









    <function name="VIR_MIGRATE_PERSIST_DEST" link="libvirt-libvirt-domain.html#VIR_MIGRATE_PERSIST_DEST"/>








@@ -1459,6 +1466,7 @@







    <function name="virConnectGetHostname ()" link="libvirt-libvirt-host.html#virConnectGetHostname"/>









    <function name="virConnectGetLibVersion ()" link="libvirt-libvirt-host.html#virConnectGetLibVersion"/>









    <function name="virConnectGetMaxVcpus ()" link="libvirt-libvirt-host.html#virConnectGetMaxVcpus"/>









    <function name="virConnectGetStoragePoolCapabilities ()" link="libvirt-libvirt-storage.html#virConnectGetStoragePoolCapabilities"/>









    <function name="virConnectGetSysinfo ()" link="libvirt-libvirt-host.html#virConnectGetSysinfo"/>









    <function name="virConnectGetType ()" link="libvirt-libvirt-host.html#virConnectGetType"/>









    <function name="virConnectGetURI ()" link="libvirt-libvirt-host.html#virConnectGetURI"/>
































libvirt.spec



+2
−2






























Original line number
Diff line number
Diff line







@@ -216,14 +216,14 @@







Summary: Library providing a simple virtualization API









Name: libvirt









Version: 5.2.0









Release: 0rc1%{?dist}%{?extra_release}









Release: 0rc2%{?dist}%{?extra_release}









License: LGPLv2+









URL: https://libvirt.org/



















%if %(echo %{version} | grep -q "\.0$"; echo $?) == 1









    %define mainturl stable_updates/









%endif









Source: https://libvirt.org/sources/%{?mainturl}libvirt-%{version}-rc1.tar.xz









Source: https://libvirt.org/sources/%{?mainturl}libvirt-%{version}-rc2.tar.xz



















Requires: libvirt-daemon = %{version}-%{release}









Requires: libvirt-daemon-config-network = %{version}-%{release}
































libvirt.spec.in



+2
−2






























Original line number
Diff line number
Diff line







@@ -216,14 +216,14 @@







Summary: Library providing a simple virtualization API









Name: libvirt









Version: @VERSION@









Release: 0rc1%{?dist}%{?extra_release}









Release: 0rc2%{?dist}%{?extra_release}









License: LGPLv2+









URL: https://libvirt.org/



















%if %(echo %{version} | grep -q "\.0$"; echo $?) == 1









    %define mainturl stable_updates/









%endif









Source: https://libvirt.org/sources/%{?mainturl}libvirt-%{version}-rc1.tar.xz









Source: https://libvirt.org/sources/%{?mainturl}libvirt-%{version}-rc2.tar.xz



















Requires: libvirt-daemon = %{version}-%{release}









Requires: libvirt-daemon-config-network = %{version}-%{release}