Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
L
libvirt
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Libvirt Packaging Team
libvirt
Commits
e771da9e
Commit
e771da9e
authored
16 years ago
by
Guido Günther
Committed by
Guido Günther
16 years ago
Browse files
Options
Downloads
Patches
Plain Diff
drop superflous 0011-Fix-segfault-on-missing-volume-format.patch
not an issue in 0.4.6 only in 0.5.X
parent
44cb9b5b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/0011-Fix-segfault-on-missing-volume-format.patch
+0
-29
0 additions, 29 deletions
.../patches/0011-Fix-segfault-on-missing-volume-format.patch
debian/patches/series
+0
-1
0 additions, 1 deletion
debian/patches/series
with
0 additions
and
30 deletions
debian/patches/0011-Fix-segfault-on-missing-volume-format.patch
deleted
100644 → 0
+
0
−
29
View file @
44cb9b5b
From 9533ab9556ddf15435944ec03f6ab1730fb2e279 Mon Sep 17 00:00:00 2001
From: Daniel Veillard <veillard@redhat.com>
Date: Thu, 4 Dec 2008 16:26:31 +0100
Subject: [PATCH] Fix segfault on missing volume format
Closes: #507677
---
src/storage_conf.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/storage_conf.c b/src/storage_conf.c
index f0d2b94..c22889f 100644
--- a/src/storage_conf.c
+++ b/src/storage_conf.c
@@ -752,6 +752,11 @@
virStorageVolDefParseDoc(virConnectPtr conn,
ret->target.path = virXPathString(conn, "string(/volume/target/path)", ctxt);
if (options->formatFromString) {
char *format = virXPathString(conn, "string(/volume/target/format/@type)", ctxt);
+ if (format == NULL) {
+ virStorageReportError(conn, VIR_ERR_XML_ERROR,
+ _("cannot guess missing format type for target"));
+ goto cleanup;
+ }
if ((ret->target.format = (options->formatFromString)(conn, format)) < 0) {
virStorageReportError(conn, VIR_ERR_XML_ERROR,
_("unknown volume format type %s"), format);
--
1.6.0.3
This diff is collapsed.
Click to expand it.
debian/patches/series
+
0
−
1
View file @
e771da9e
...
...
@@ -8,4 +8,3 @@
0008-Increase-initial-qemu-monitor-read-timeout.patch
0009-Open-qemu-monitor-log-O_APPEND-instead-of-O_TRUNC.patch
0010-raise-error-on-invalid-volume-format.patch
0011-Fix-segfault-on-missing-volume-format.patch
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment