Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
L
libvirt
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Libvirt Packaging Team
libvirt
Commits
f6ffda7a
Commit
f6ffda7a
authored
10 years ago
by
Guido Günther
Browse files
Options
Downloads
Patches
Plain Diff
vbox: fix a bug in _machineStateInactive
Closes: #770202
parent
66a3ca68
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
debian/patches/series
+1
-0
1 addition, 0 deletions
debian/patches/series
debian/patches/upstream/vbox-fix-a-bug-in-_machineStateInactive.patch
+28
-0
28 additions, 0 deletions
...es/upstream/vbox-fix-a-bug-in-_machineStateInactive.patch
with
29 additions
and
0 deletions
debian/patches/series
+
1
−
0
View file @
f6ffda7a
...
...
@@ -23,3 +23,4 @@ security/CVE-2014-8136-qemu-migration-Unlock-vm-on-failed-ACL.patch
upstream/qemu-Fix-crash-in-tunnelled-migration.patch
lxc-Move-setting-ifname_guest_actual-to-virLXCSetupI.patch
lxc-Don-t-crash-on-NULL-ifname_guest_actual.patch
upstream/vbox-fix-a-bug-in-_machineStateInactive.patch
This diff is collapsed.
Click to expand it.
debian/patches/upstream/vbox-fix-a-bug-in-_machineStateInactive.patch
0 → 100644
+
28
−
0
View file @
f6ffda7a
From: Yohan BELLEGUIC <yohan.belleguic@diateam.net>
Date: Wed, 19 Nov 2014 09:53:15 +0100
Subject: vbox: fix a bug in _machineStateInactive
This function returned non-inactive domains instead of active
domains. This broke virConnectNumOfDefinedDomains() and
virConnectListDefinedDomains() functions.
Closes: #770202
---
src/vbox/vbox_tmpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index e5d6d66..c42e186 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -6081,8 +6081,8 @@
static bool _machineStateOnline(PRUint32 state)
static bool _machineStateInactive(PRUint32 state)
{
- return ((state > MachineState_FirstOnline) &&
- (state < MachineState_LastOnline));
+ return ((state < MachineState_FirstOnline) ||
+ (state > MachineState_LastOnline));
}
static bool _machineStateNotStart(PRUint32 state)
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment