Commit 256c8713 authored by Chris Lamb's avatar Chris Lamb

Warn about packages that use vendor-specific patch series files since the CTTE decision in #904302.

parent 6b90635b
Pipeline #25726 passed with stage
in 0 seconds
......@@ -228,3 +228,18 @@ Info: Lintian found a spelling or capitalization error in the description
.
Patch filenames or descriptions that refer to "spelling" or "typo" (or
similar) are ignored by Lintian.
Tag: package-uses-vendor-specific-patch-series
Severity: important
Certainty: certain
Info: The specified series file is a vendor-specific patch series file.
.
This is feature of dpkg that can be used to apply a different series of
quilt patches when the source package is unpacked on different systems.
However, since Debian source packages are usually treated as a pure
transport format this can cause confusion and frustration.
.
Please migrate away from such series files and consider alternatives
such differing source packages or modify the build process to behave
conditionally or to conditionally patch files explicitly.
Ref: #904302, https://lists.debian.org/debian-devel-announce/2018/11/msg00004.html
......@@ -241,6 +241,9 @@ sub run {
$known_files{$1}++ if m{^\s*(?:#+\s*)?(\S+)};
}
close($fd);
tag 'package-uses-vendor-specific-patch-series', $file
if $file =~ /\.series$/;
}
foreach my $file ($dpdir->children('breadth-first')) {
......
......@@ -12,6 +12,9 @@ lintian (2.5.113) UNRELEASED; urgency=medium
and update the description to make the distinction between the LSB
(where it is required) and Debian Policy (where currently it is not).
Thanks to Andreas Henriksson for the suggestion. (Closes: #913466)
* checks/patch-systems.{desc,pm}:
+ [CL] Warn about packages that use vendor-specific patch series files
since the CTTE decision in #904302.
* checks/shared-libs.pm:
+ [CL] Apply a patch from James McCoy to fix a regression that was
causing Lintian to incorrectly report the
......
......@@ -11,4 +11,5 @@ Test-For:
patch-system-but-direct-changes-in-diff
quilt-patch-with-non-standard-options
quilt-series-references-non-existent-patch
package-uses-vendor-specific-patch-series
patch-file-present-but-not-mentioned-in-series
E: patch-systems-quilt-general source: package-uses-vendor-specific-patch-series debian/patches/vendorname.series
E: patch-systems-quilt-general source: patch-modifying-debian-files some-file debian/some-file
E: patch-systems-quilt-general source: quilt-series-references-non-existent-patch ../../debian-patch
E: patch-systems-quilt-general source: quilt-series-references-non-existent-patch some-nonexistent-patch
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment