Commit 2611ce48 authored by Chris Lamb's avatar Chris Lamb 💬

Don't emit latest-debian-changelog-entry-changed-to-native if the latest...

Don't emit latest-debian-changelog-entry-changed-to-native if the latest changelog entry references "native package".
parent 275261fb
Pipeline #70752 passed with stage
in 63 minutes and 17 seconds
......@@ -430,7 +430,9 @@ sub binary {
or $entries[0]->Distribution =~ /-security$/i
or $entries[0]->Source ne $entries[1]->Source;
tag 'latest-debian-changelog-entry-changed-to-native'
if $native_pkg and $second_version =~ m/-/;
if $native_pkg
and $second_version =~ m/-/
and $entries[0]->Changes !~ /\bnative package\b/im;
}
my $first_version_without_epoch = $first_version =~ s/^([^:]+)://r;
foreach my $entry (@entries[1..$#entries]) {
......
  • @lamby This edit was superseded by commit 14643612 and others around it. The tag was removed.

    Lintian is unable to detect this condition without querying the archive. Lintian can only tell if current or past versions in changelog comply with the current nativeness in a source package.

  • Lintian can only tell if current or past versions in changelog comply with the current nativeness in a source package.Lintian can only tell if current or past versions in changelog comply with the current nativeness in a source package.

    … which IMHO is enough for me (despite it not being 100% reliable) and catches 99% of these typo-based errors. I'm thus -1 on this tags removal.

  • Which scenarios do you think typically triggered the tag? When it was a typo, shouldn't dpkg-buildpackage refuse to package a non-native source package natively?

  • shouldn't dpkg-buildpackage refuse to package a non-native source package natively?

    Ah, indeed. Ignore this...

Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment