Commit b83197ef authored by Josh Triplett's avatar Josh Triplett Committed by Chris Lamb

checks/debhelper.desc: Discuss debhelper's existing optimizations.

debhelper already includes optimizations to avoid running commands when
unnecessary, but people might not know that. Mention that in the help
for debhelper-excessive-overrides, and encourage people to improve those
optimizations in debhelper if needed.
Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
parent 50d03a65
Pipeline #20079 passed with stage
in 0 seconds
......@@ -485,9 +485,15 @@ Info: The <tt>debian/rules</tt> file appears to include a suspiciously
However, whilst using overrides are not a problem per-se, such a list
is usually subject to constant revision, prevents future debhelper
versions fixing archive-wide problems, adds unnecessary
noise/distraction for anyone reviewing the package, increases the
package's "bus factor" and is typically a premature optimisation. It
is, in addition, aesthetically displeasing.
noise/distraction for anyone reviewing the package, and increases the
package's "bus factor". It is, in addition, aesthetically displeasing.
.
Furthermore, this is typically a premature optimisation. debhelper already
includes optimizations to avoid running commands when unnecessary. If you find
a debhelper command taking unnecessarily long when it has no work to do,
please work with the debhelper developers to help debhelper skip that command
in more circumstances, optimizing not only your package build but everyone
else's as well.
.
Please remove the unnecessary overrides.
Ref: debhelper(7), dh(1)
......@@ -5,6 +5,9 @@ lintian (2.5.107) UNRELEASED; urgency=medium
* checks/changes-file.{desc,pm}:
+ [CL] Don't emit changelog-empty-entry if distribution is UNRELEASED.
(Closes: #909674)
* checks/debhelper.desc:
+ [CL] Apply patch from Josh Triplett to improve the long description
of excessive-debhelper-overrides.
-- Chris Lamb <lamby@debian.org> Wed, 26 Sep 2018 16:31:48 +0100
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment