Commit c20e79a8 authored by Chris Lamb's avatar Chris Lamb

Stop recommending that packages with repacked tarballs specify a get-orig-source…

Stop recommending that packages with repacked tarballs specify a get-orig-source target; this was removed in Debian Policy 4.1.4 in favour of uscan(1) and debian/watch.
parent 4b539458
......@@ -60,16 +60,6 @@ Info: The <tt>debian/rules</tt> file for this package does not provide
These targets will be required by policy in the future, so should be
added to prevent future breakage.
Tag: debian-rules-missing-good-practice-target-dfsg
Severity: wishlist
Certainty: certain
Ref: policy 4.9, devref 6.7.8.2
Info: The <tt>debian/rules</tt> file for this package does not provide
one of the good practice targets.
.
If your packaged is repacked from non-dfsg source, you should add a
get-orig-source target.
Tag: debian-rules-uses-deprecated-makefile
Severity: normal
Certainty: certain
......
......@@ -409,10 +409,6 @@ sub run {
tag 'debian-rules-missing-required-target', $target;
} elsif ($typerule eq 'recommended_allindep') {
tag 'debian-rules-missing-recommended-target', $target;
} elsif ($typerule eq 'goodpractice_dfsg') {
tag 'debian-rules-missing-good-practice-target-dfsg',
$target
if $info->repacked;
} else {
$typerule ||= '<N/A>';
croak(
......
......@@ -5,8 +5,6 @@
# - "required" => For required rules (prior to 3.9.4)
# - recommended_allindep => For the new required targets in 3.9.4
# (these used to just be recommended)
# - goodpractice_dfsg => Target recommended for repacked packages
# (e.g. packages with non-free files removed)
build required
binary required
binary-arch required
......@@ -14,4 +12,3 @@ binary-indep required
clean required
build-arch recommended_allindep
build-indep recommended_allindep
get-orig-source goodpractice_dfsg
......@@ -27,6 +27,10 @@ lintian (2.5.81) UNRELEASED; urgency=medium
+ [CL] Avoid false-positives in Mallard XML files; <link href="...">
tags are anchor element and not followed automatically. Thanks to
Simon McVittie for the report. (Closes: #894690)
* checks/rules.{desc,pm}:
+ [CL] Stop recommending that packages with repacked tarballs specify a
get-orig-source target; this was removed in Debian Policy 4.1.4 in
favour of uscan(1) and debian/watch.
* checks/testsuite.{desc,pm}:
+ [CL] Apply patch from Georg Faerber to add missing "needs-reboot" to
the list of known autopkgtest restrictions. (Closes: #894817)
......
......@@ -10,7 +10,6 @@ Test-For:
config-does-not-load-confmodule
debhelper-but-no-misc-depends
debian-changelog-file-contains-invalid-email-address
debian-rules-missing-good-practice-target-dfsg
debian-watch-file-in-native-package
debian-watch-file-should-mangle-version
debian-watch-file-unknown-version
......
......@@ -36,7 +36,6 @@ E: maintainer-scripts: read-in-maintainer-script prerm:64
E: maintainer-scripts: read-in-maintainer-script prerm:65
E: maintainer-scripts: read-in-maintainer-script prerm:66
E: maintainer-scripts: wrong-debian-qa-group-name QA group <packages@qa.debian.org>
I: maintainer-scripts source: debian-rules-missing-good-practice-target-dfsg get-orig-source
I: maintainer-scripts source: debian-watch-uses-insecure-uri http://domain.tld/foo-(.+)\.tar\.gz
I: maintainer-scripts: no-md5sums-control-file
I: maintainer-scripts: output-of-updaterc.d-not-redirected-to-dev-null bar postrm
......
......@@ -14,7 +14,6 @@ Test-For:
copyright-file-lacks-pointer-to-perl-license
debhelper-but-no-misc-depends
debhelper-compat-file-is-missing
debian-rules-missing-good-practice-target-dfsg
debian-watch-file-declares-multiple-versions
debian-watch-file-should-dversionmangle-not-uversionmangle
debian-watch-file-should-use-sf-redirector
......
......@@ -25,7 +25,6 @@ E: scripts: script-without-interpreter control/prerm
E: scripts: shell-script-fails-syntax-check usr/bin/sh-broken
E: scripts: wrong-path-for-interpreter usr/bin/lefty-foo (#!/usr/local/bin/lefty != /usr/bin/lefty)
E: scripts: wrong-path-for-interpreter usr/bin/rubyfoo (#!/bin/ruby1.8 != /usr/bin/ruby1.8)
I: scripts source: debian-rules-missing-good-practice-target-dfsg get-orig-source
I: scripts source: debian-watch-file-should-dversionmangle-not-uversionmangle line 5
I: scripts source: dpatch-missing-description 02_i_dont_have_a_description.patch
I: scripts source: dpatch-missing-description 04_i_dont_have_a_description_either.patch
......
......@@ -3,5 +3,4 @@ Version: 1.0+dfsg-1
Type: non-native
Description: Test for missing targets in debian/rules
Test-For:
debian-rules-missing-good-practice-target-dfsg
debian-rules-missing-recommended-target
I: rules-missing-targets source: debian-rules-missing-good-practice-target-dfsg get-orig-source
W: rules-missing-targets source: debian-rules-missing-recommended-target build-arch
W: rules-missing-targets source: debian-rules-missing-recommended-target build-indep
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment