1. 09 Dec, 2018 3 commits
  2. 07 Dec, 2018 3 commits
  3. 05 Dec, 2018 17 commits
  4. 04 Dec, 2018 17 commits
    • Felix Lechner's avatar
      Fix maximum existing version of Java class file format. (MR: !86) · a18093bf
      Felix Lechner authored
      The fix to #912292 (in commit f48c9236) makes several updates to the
      known Java class file versions but appears to require, in addition, an
      upward adjustment of 'max-bytecode-existing-version'. Otherwise, the
      test 'java-class-format' produces the following regression:
      
      @@ -1,2 +1,2 @@
      -W: libtest-java: incompatible-java-bytecode-format Java12 version (Class format: 56)
       W: libtest-java: unknown-java-class-version usr/share/java/testa-1.0.jar (org/debian/lintian/TestA.class -> 42)
      +W: libtest-java: unknown-java-class-version usr/share/java/testb-1.0.jar (org/debian/lintian/TestB.class -> 56)
      fail tests::java-class-format: output differs!
      
      An inspection of 'TestB.class' shows that the major version is being
      read correctly. It is just not interpreted right. This commit causes
      the test to pass without errors.
      
        Last modified Dec 4, 2018; size 278 bytes
        MD5 checksum d41318995b87081fd003c4da42f3562d
        Compiled from "TestB.java"
      public class org.debian.lintian.TestB
        minor version: 0
        major version: 56
        flags: (0x0021) ACC_PUBLIC, ACC_SUPER
        this_class: #2                          // org/debian/lintian/TestB
        super_class: #3                         // java/lang/Object
        interfaces: 0, fields: 0, methods: 1, attributes: 1
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      a18093bf
    • Chris Lamb's avatar
      Replace FIXME with MR reference. · 51832812
      Chris Lamb authored
      51832812
    • Felix Lechner's avatar
      Use safe_qx() instead of qx{} in test runner. (MR: !85) · cc6e3e24
      Felix Lechner authored
      In this instance, it may not be any safer but it is probably good
      practice.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      cc6e3e24
    • Chris Lamb's avatar
      Apply a patch series from Felix Lechner to provide a generalised facility to... · 143e08ea
      Chris Lamb authored
      Apply a patch series from Felix Lechner to provide a generalised facility to make any test template set independent of the package format. (MR: !82)
      143e08ea
    • Felix Lechner's avatar
      Simplify test cruft-empty-diff; use only templates; no copies in ./orig. · c92295b0
      Felix Lechner authored
      The test 'cruft-empty-diff' replicated all standard templates in
      ./orig. Here we instead use the script ./pre_upstream to copy all
      filled Debian files into the package directory before the orig.tar.gz
      is created. It also renders the diff empty, but is probably more fool-
      and future-proof.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      c92295b0
    • Felix Lechner's avatar
      Fix test generic-dh-make-2005 to work without external templates. · ac89c5fc
      Felix Lechner authored
      test to remain undisturbed "as a test of Lintian's handling of old ...
      template packages". This commit stops the use of standard templates,
      which in the past provided missing files.
      
      During the build process, dh_clean is called. It errors out when no
      compat file is present. To get the test to run, a compat file is now
      generated through the pre_build script. This is done dynamically so
      that the set of static files is not modified, as requested by the
      original author.
      
      Some tags appeared when the use of default templates was discontinued.
      Those tags were added.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      ac89c5fc
    • Felix Lechner's avatar
      Fix test generic-dh-make-2008 to work without external templates. · bf735013
      Felix Lechner authored
      Judging from the file orig/README the original author intended this
      test to remain undisturbed "as a test of Lintian's handling of old ...
      template packages". This commit stops the use of standard templates,
      which in the past provided missing files.
      
      During the build process, dh_clean is called. It errors out when no
      compat file is present. To get the test to run, a compat file is now
      generated through the pre_build script. This is done dynamically so
      that the set of static files is not modified, as requested by the
      original author.
      
      Some tags appeared when the use of default templates was discontinued.
      Those tags were added.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      bf735013
    • Felix Lechner's avatar
      Add a builder-only skeleton; does not supply any Debian templates. · aad4a2db
      Felix Lechner authored
      This skeleton only installs (and fills) build files, but it does not
      supply any Debian templates (although it will fill them).  Tests like
      generic-dh-make-* were meant to be snapshots in time. In the past,
      they were seeded with standard template sets like other tests. That
      may conflict with the intentions of their original authors. This
      commit creates a more suitable skeleton for their use.
      
      This skeleton also allows the script pre_build to be generated from a
      template. That functionality is needed to supply debian/compat to both
      tests mentioned above without modifying any of their static Debian
      files.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      aad4a2db
    • Felix Lechner's avatar
      Execute post-template adjustment script in t/runtests. · eaa9032e
      Felix Lechner authored
      This commit will execute a post-template script, if present. It is
      part of a new mechanism to ensure that native packages are not
      supplied with watch files.
      
      With this commit, we can restore the two tests generic-dh-make-2005
      and generic-dh-make-2008 to their original functionality: when they
      were conceived, dh-make did not create watch files. Until now, neither
      test showed the associated warnings because a template set supplied
      the missing file. Very soon the two tests will no longer draw on
      external Debian template sets. Instead they will trigger all the
      warnings their original authors intended.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      eaa9032e
    • Felix Lechner's avatar
      Remove dynamic generation of watch file from builder Makefile. · b499aaf9
      Felix Lechner authored
      For a long time, the Lintian test suite automatically created watch
      files for non-native packages. That worked well, except in some corner
      cases. Some tests compensated by removing the file in the pre_build
      script.
      
      This commit is part of a series that changes that mechanism. The watch
      file is now supplied by a template set and removed right after the
      templates are copied into a test's work directory.  The processing
      takes place earlier. It allows tests deal with watch files like they
      do with any other file that is (or is not) supplied by template sets.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      b499aaf9
    • Felix Lechner's avatar
      Add empty watch files to the template sets for tests. · 5717411e
      Felix Lechner authored
      Watch files were previously created in builder Makefiles. For some
      tests, that was too late in the process. Now they are supplied as part
      of template sets. For native packages, the watch files supplied herein
      will be removed by post-template scripts. That script is supplied
      elsewhere.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      5717411e
    • Felix Lechner's avatar
      Add a default post-template command; it is post_template. · d60498b1
      Felix Lechner authored
      Some templates require adjustment after they were copied to a test's
      work directory. For native packages, a post-template script will
      remove any watch files that may have been shipped as part of a
      template. This commit only sets the name of the script. The script is
      provided by a template set.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      d60498b1
    • Felix Lechner's avatar
      Add post-template script to the template set 'make-builder' for tests. · c9d4838c
      Felix Lechner authored
      This script causes any watch file (or its template) that was shipped
      as part of other template sets to be deleted, if a package is native.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      c9d4838c
    • Felix Lechner's avatar
      Transfer file permissions from templates to generated files. · c7d30038
      Felix Lechner authored
      The templating system does not preserve file permissions, but scripts
      must be executable to run. This commit applies the file permissions of
      the template to any generated file. Going forward, scripts generated
      from templates can also run.
      
      This change is important for a new mechanism to generate debian/watch
      and is also used to supply compat files to the tests
      generic-dh-make-*, which were created without it. Modern Debian tools
      require compat. The script was a way to add it without modifying the
      debian files originally created by dh-make.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      c7d30038
    • Felix Lechner's avatar
      Remove pre-existing metadata in the upstream-metadata-is-not-a-file test. (MR: !84) · 4a2880af
      Felix Lechner authored
      The test does not remove debian/upstream/metadata before generating it
      as a FIFO. That causes an error if the file exists, for example when
      it is supplied by a template like 'pedantic'. Here the file is removed
      before the FIFO is created.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      4a2880af
    • Chris Lamb's avatar
      Apply a patch from Felix Lechner to remove an incorrect line number in the... · 2b4ac946
      Chris Lamb authored
      Apply a patch from Felix Lechner to remove an incorrect line number in the output of the fields-bugs-field-does-not-refer-to-debian-infrastructure tag. (MR: !83)
      2b4ac946
    • Felix Lechner's avatar
      Adjust test tags to new emitted format. · 420323d8
      Felix Lechner authored
      The expected tags for the test
      fields-bugs-field-does-not-refer-to-debian-infrastructure changed as a
      result of a previous commit. This is the adjustment.
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      420323d8