Gbp-Dch: ignore

Remove "busses" as a false-positive plural for "bus". Thanks to Jörg Frings-Fürst for the report. (Closes: #934452)

Felix Lechner authored Aug 06, 2019 and Chris Lamb committed Aug 11, 2019

This does not bring the documentation in line with all recent changes,
but will hopefully avoid the worst vitriol from readers for its poor
state.

Fixes the instructions on how to run the test suite.

Also marks the tutorials for writing tests and checks as out of date.

Gbp-Dch: ignore

Felix Lechner authored Aug 06, 2019 and Chris Lamb committed Aug 11, 2019

The field 'Check' in tag definitions is new and mandatory, but the
enforcing script t/scripts/tags/desc_fields.t does not run early
enough to prevent problems even in other scripts (vs. tag-related
tests). A proper solution requires a re-ordering of test scripts.

As a start, this aborts Lintian and emits a meaningful error message.

Gbp-Dch: ignore

Felix Lechner authored Aug 05, 2019 and Chris Lamb committed Aug 11, 2019

As lamby pointed out, the package matlab-gdf that gave rise to the bug
belongs to the section 'contrib/science'. The section is somewhat
unusual because it uses a slash.

No slash was present in the HTML page source (as one might expect for
an unescaped character) and the output looked a little different from
what was reported in the bug. (The version and the section were both
absent.)  Nonetheless, this patch seemed like a reasonable attempt to
resolve the bug. It is supposed to escape forward slashes to the HTML
sequence '/' but it is untested.

It looks like the archive component for individual packages runs
through the routine html_quote, which is changed here, before being
passed to Text::Template:

https://salsa.debian.org/lintian/lintian/blob/master/commands/reporting-html-reports.pm#L1062

This commit may or may not close the bug. It needs to be tested.

Gbp-Dch: ignore

These statements have an effect only during test selection. The normal
course of action should be, after editing a check, to use the check:
selector to ensure your changes work as expected.

You can also use the tag: selector, but that normally just invokes
check: for the check the tag belongs to. Since the other tags in the
check could interact with your selected tag, there is a reasonable
assumption that they might interfere. To locate false positives, it is
therefore best to run all related tests.

The Test-Against: statements change that behavior. They are a holdover
from when the test suite was focused on tags rather than checks. In an
ideal situation, tests are specific to one tag and checks group only
narrowly related tags. (Broad checks like 'files' and unfocused tests
like 'manpages-general' are antithetical to the new design.) The
Test-Against statements change which tests are run when a tag: is
selected. That is all they do.

Broad checks like 'files' group many unrelated tags. The tests
intended for them are usually, but not always, a bit narrower. A
Test-Against: statement says that the test at hand is a good indicator
for false positives only for the listed tags. It prevents the test
from running to find false positives for tags that do not appear in
either 'tags' or Test-Against.

The author would prefer to remove all Test-Against: statements. For
that to happen, broad checks must be split into smaller pieces. An
example would be to remove nodejs-related tags from the check 'files'.
During that effort, Test-Against statements can be helpful to identify
related tags. That's why Test-Against: is still around.

Empty Test-Against statements do not serve that purpose. They only
prevent tests from being run to look for false positive for tags other
then the small subset calculated above.  Without it, all tests are run
if they relate to the check the selected tag is in. Removing
Test-Against simply results in more tests being run when the tag:
selector is used. They do nothing else.

Unfortunately, the content of the Test-Against: statements was never
properly verified.  The semantics are unclear perhaps to anyone except
the auther. The field is also of limited utility. Finally, the field's
function is not what people may think from looking at old surviving
documentation. The fields should go away when possible.

We are keeping Test-Against: fields that have values so they can aid
in debulking broad checks. The empty statements are herewith deleted.

Gbp-Dch: ignore

The tags layout in separate files broke custom profiles in other
packages. The packages pkg-perl-tools and pkg-js-tools use custom
profiles that no longer work with recent version of Lintian.

The reason is the separation of tags from checks in commit 083e8396
and others.

Both packages adjusted their custom profiles in recent uploads.
Acknowledges the prior breakage in d/control.

Please see Bug#934100 and Bug#934144 for details.

Gbp-Dch: ignore

Two tests fail to build in unstable because a new debhelper version
there dropped support for manual sequencing. The relevant changelog
entry is:

  * dh: Retroactively remove support for manual dh sequence
    operators (--until, --after, --before and --remaining).
    This breaks about 8 source packages that still rely on this
    feature and have not yet migrated away.  (Closes: #932537)
    Please see the debhelper bug for relevant bug numbers and
    package names.

Two tests for the tag 'dh-manual-sequence-control-obsolete' could no
longer built due to build failure. Removed the manual sequencing and
adjusted the expected tags in both.

If the tag 'dh-manual-sequence-control-obsolete' cannot be tested in
another way, it will probably be removed from Lintian.

Gbp-Dch: ignore

Remove tag 'dh-manual-sequence-control-obsolete' from Lintian; cannot be tested due to debhelper changes.

Debhelper 12.4 dropped support for manual sequencing. The relevant
changelog entry is:

  * dh: Retroactively remove support for manual dh sequence
    operators (--until, --after, --before and --remaining).
    This breaks about 8 source packages that still rely on this
    feature and have not yet migrated away.  (Closes: #932537)
    Please see the debhelper bug for relevant bug numbers and
    package names.

Source packages using the mechanism are now FTBFS. The mechanism was
obsolete for some time and can no longer be used. It is untestable.

Removes the tag and its check from Lintian.

Yadd authored Aug 06, 2019 and Chris Lamb committed Aug 14, 2019

Add a "nodejs-module-installed-in-usr-lib" tag to check if Node.JS modules are installed in the (correct) new location.

Release lintian/2.18.0 into unstable.

Format: 1.8
Date: Wed, 14 Aug 2019 15:56:02 +0000
Source: lintian
Architecture: source
Version: 2.18.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 934452 934748
Changes:
 lintian (2.18.0) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - nodejs-module-installed-in-usr-lib
     + Removed:
       - dh-manual-sequence-control-obsolete
 .
   [ Chris Lamb ]
   * Don't emit package-name-doesnt-match-sonames for udebs.
     (Closes: #934748)
   * Remove "busses" as a false-positive plural for "bus". Thanks to Jörg
     Frings-Fürst for the report. (Closes: #934452)
   * Recommend that maintainers do not override the
     "latest-debian-changelog-entry-changed-to-native" tag.
   * Don't emit changelog-file-missing-explicit-entry for uploads to the
     security archive (Re: #934026).
 .
   [ Felix Lechner ]
   * Remove the "dh-manual-sequence-control-obsolete" tag as it cannot
     be tested due to debhelper changes.
 .
   [ Xavier ]
   * Add a "nodejs-module-installed-in-usr-lib" tag to check if Node.js
     modules are installed in the (correct) new location.
   * Update the node-package-install-in-nodejs-rootdir test to search in all
     Node.js module directories.
Checksums-Sha1:
 e377be7d51f167d0e533cfd0e5f4873ee1bf92ee 3047 lintian_2.18.0.dsc
 1a6a66d6d5ee7054622ce2a64c066953f64b60ec 1767468 lintian_2.18.0.tar.xz
 98db02ab7b026c896b4104428b1de98d4e4997bf 17644 lintian_2.18.0_amd64.buildinfo
Checksums-Sha256:
 4b05b1fedf317edcd8af3d596cd5fd4e09d95c2987c0c74c0f305d44dd9f2d2c 3047 lintian_2.18.0.dsc
 b1bfa01db82910da8fb7e87e2d914d8fc59ee6c546a6f85ad1b84236a8c2f06e 1767468 lintian_2.18.0.tar.xz
 97de2e20d7322a3b2bd943cd6e8b77f85cc352f7c991268696a91114180366bc 17644 lintian_2.18.0_amd64.buildinfo
Files:
 89c66b0e98b8ced1d4e0f0264ff9a750 3047 devel optional lintian_2.18.0.dsc
 dd796d558469f5322ad9616575141b81 1767468 devel optional lintian_2.18.0.tar.xz
 f6d0a7169e4e7750d83da2440517abed 17644 devel optional lintian_2.18.0_amd64.buildinfo

* tag '2.18.0':
  Release lintian/2.18.0 into unstable.
  Don't emit package-name-doesnt-match-sonames for udebs. (Closes: #934748)
  Add a "nodejs-module-installed-in-usr-lib" tag to check if Node.JS modules are installed in the (correct) new location.
  Update the node-package-install-in-nodejs-rootdir test to search in all Node.JS module directories.
  Remove tag 'dh-manual-sequence-control-obsolete' from Lintian; cannot be tested due to debhelper changes.
  Fix two tests for debhelper update 12.4, which dropped manual sequencing commands.
  Acknowledge prior breakage due to new separate tags layout in d/control.
  Remove empty Test-Against: statements in test descriptions.
  Attempt to fix irregular HTML display of package matlab-gdf in HTML output. (Re. #907425)
  Abort lintian when tag definition is missing a 'Check:' stanza.
  Fix instructions on how to run the test suite.
  Remove "busses" as a false-positive plural for "bus". Thanks to Jörg Frings-Fürst for the report. (Closes: #934452)
  Don't emit changelog-file-missing-explicit-entry for uploads to the security archive (re. #934026).
  Recommend that maintainers do not override latest-debian-changelog-entry-changed-to-native.
  Open new changelog entry.