checks/binaries.pm

@@ -298,7 +298,7 @@ sub run {
     }
 
     tag 'package-name-doesnt-match-sonames', "@sonames"
-      if @sonames && !$match_found;
+      if @sonames && !$match_found && $type ne 'udeb';
 
     # process all files in package
     foreach my $file ($info->sorted_index) {

checks/changelog-file.pm

@@ -346,7 +346,8 @@ sub run {
                 my $expected = substr($first_version, 0, -length($1));
                 tag 'changelog-file-missing-explicit-entry',
                   "$second_version -> $expected (missing) -> $first_version"
-                  unless $second_version eq $expected;
+                  unless $second_version eq $expected
+                  or $entries[0]->Distribution =~ /-security$/i;
             }
 
             if (    $first_upstream eq $second_upstream

checks/debhelper.pm

@@ -174,9 +174,6 @@ sub run {
                     }
                 }
             }
-            if (m/--(after|before|until|remaining)/) {
-                tag 'dh-manual-sequence-control-obsolete', 'dh', $1;
-            }
         } elsif (m,^include\s+/usr/share/cdbs/1/rules/debhelper.mk,
             or m,^include\s+/usr/share/R/debian/r-cran.mk,o) {
             $build_systems{'cdbs-with-debhelper.mk'} = 1;

checks/files.pm

@@ -821,10 +821,12 @@ sub run {
                 tag 'file-in-usr-lib-sgml', $file;
             }
             # ---------------- /usr/lib/node
-            elsif ($fname =~ m,^usr/lib/nodejs/,) {
-                if ($fname eq 'usr/lib/nodejs/package.json') {
-                    tag 'node-package-install-in-nodejs-rootdir', $fname;
-                }elsif ($fname =~m,usr/lib/nodejs/[^/]*\.js$,) {
+            elsif ($fname =~ m,^usr/(?:share|lib(?:/[^/]+)?)/nodejs/,) {
+                tag 'nodejs-module-installed-in-usr-lib', $file
+                  if $fname =~ m#usr/lib/nodejs/.*# and $file->is_file;
+                if ($fname
+                    =~ m#usr/(?:share|lib(?:/[^/]+)?)/nodejs/(?:package\.json|[^/]*\.js)$#
+                ) {
                     tag 'node-package-install-in-nodejs-rootdir', $fname;
                 }
             }

commands/reporting-html-reports.pm

@@ -1128,6 +1128,9 @@ sub html_quote {
     if (index($text, '>') > -1) {
         $text =~ s/>/\>/g;
     }
+    if (index($text, '/') > -1) {
+        $text =~ s/\//\//g;
+    }
     return $text;
 }
 

data/spelling/corrections

@@ -1280,7 +1280,6 @@ bumpded||bumped
 bumpted||bumped
 burocratic||bureaucratic
 buss||bus
-busses||buses
 cacahe||cache
 cacahes||caches
 cacheed||cached

debian/changelog

+lintian (2.18.0~bpo10+1) buster-backports; urgency=medium
+
+  * Rebuild for buster-backports.
+
+ -- Chris Lamb <lamby@debian.org>  Mon, 19 Aug 2019 12:29:40 -0700
+
+lintian (2.18.0) unstable; urgency=medium
+
+  * Summary of tag changes:
+    + Added:
+      - nodejs-module-installed-in-usr-lib
+    + Removed:
+      - dh-manual-sequence-control-obsolete
+
+  [ Chris Lamb ]
+  * Don't emit package-name-doesnt-match-sonames for udebs.
+    (Closes: #934748)
+  * Remove "busses" as a false-positive plural for "bus". Thanks to Jörg
+    Frings-Fürst for the report. (Closes: #934452)
+  * Recommend that maintainers do not override the
+    "latest-debian-changelog-entry-changed-to-native" tag.
+  * Don't emit changelog-file-missing-explicit-entry for uploads to the
+    security archive (Re: #934026).
+
+  [ Felix Lechner ]
+  * Remove the "dh-manual-sequence-control-obsolete" tag as it cannot
+    be tested due to debhelper changes.
+
+  [ Xavier ]
+  * Add a "nodejs-module-installed-in-usr-lib" tag to check if Node.js
+    modules are installed in the (correct) new location.
+  * Update the node-package-install-in-nodejs-rootdir test to search in all
+    Node.js module directories.
+
+ -- Chris Lamb <lamby@debian.org>  Wed, 14 Aug 2019 15:56:02 +0000
+
 lintian (2.17.0~bpo10+1) buster-backports; urgency=medium
   * Rebuild for buster-backports.

debian/control

@@ -146,7 +146,8 @@ Suggests:
  libtext-template-perl,
 Breaks:
  funny-manpages (<< 1.3-5.1),
- pkg-perl-tools (<< 0.23),
+ pkg-perl-tools (<< 0.53),
+ pkg-js-tools (<< 0.9.4),
 Replaces:
  funny-manpages (<< 1.3-5.1),
 Multi-Arch: foreign

doc/tutorial/Lintian/Tutorial/TestSuite.pod

@@ -6,6 +6,8 @@ Lintian::Tutorial::TestSuite -- Quick intro to running the Lintian testsuite
 
 =head1 SYNOPSIS
 
+Warning: This document may be out of date.
+
 This guide will quickly introduce you to running the Lintian test
 suite and some tricks.  The Lintian test suite is fairly large and
 accordingly it can take a substantial amount of time to run.  To speed
@@ -20,34 +22,21 @@ The Lintian test suite is an extensive collection of various test
 cases.  The test suite is divided into 4 "sub-suites".  The majority
 of tests are currently located in the "tests" sub-suite.
 
-To run the full suite in all its glory, simply invoke:
-
- $ debian/rules runtests
-
- OR
+To run the full suite:
 
- $ mkdir -p debian/test-out
- $ t/bin/runtests -k --dump-logs t debian/test-out
+ $ rm -rf debian/test-out; t/bin/build-test-packages; t/bin/runtests
 
 While writing a new tag (or check) you probably only want to run a
 particular (subset of the) test(s).  See L</Running a subset of the
 tests> for the available options.
 
-When run via I<debian/rules>, the test suite respects
-"DEB_BUILD_OPTIONS=parallel=N". When using I<t/bin/runtests> directly, use
-I<-jN> to choose the number of threads.  Note that "N" denotes the
-amount of "worker" threads.  The test runner will generally have 2
-threads more than that.  Also each "worker" will run lintian, which
-runs multiple unpacking jobs in parallel as well.
+=head2 Running a subset of the tests
 
-In case you are wondering about the 2 extra threads in the test
-runner, the first of them is the "coordinator" thread (which will
-generally be waiting when the workers are active) and the second one
-is the "output" thread (which handles the fancy output).
+First, you have to build the test packages with:
 
-=head2 Running a subset of the tests
+ $ rm -rf debian/test-out; t/bin/build-test-packages;
 
-The following options are available:
+Then, the following options are available:
 
 =over 4
 
@@ -55,59 +44,31 @@ The following options are available:
 
 To run a single test by its name, use:
 
- $ debian/rules runtests onlyrun=$name
-
- OR
-
- $ t/bin/runtests --dump-logs t debian/test-out $name
+ $ t/bin/runtests --onlyrun=test:$name
 
 =item Running all tests for a check
 
 To run all tests for a given check, use:
 
- $ debian/rules runtests onlyrun=$check
-
- OR
-
- $ t/bin/runtests --dump-logs -k t debian/test-out $check
+ $ t/bin/runtests --onlyrun=check:$name
 
 $check must be the name of a check (it will test for
 checks/$check.desc) or "legacy".  This will run all tests that start
 with "$check-".
 
-Note: The "changes" sub-suite in the new test suite does not support
-this.
-
-=item Running all tests in a sub-suite
-
-To run all tests in a given sub-suite, use:
-
- $ debian/rules runtests onlyrun=suite:$suites
-
- OR
-
- $ t/bin/runtests --dump-logs -k t debian/test-out suite:$suites
-
-$suites is a comma-separated list of names of sub-suites to run.
-
-Note: this cannot be used to influence the order in which the sub-suites
-are run.
-
 =item Running all tests designed for a specific tag
 
 To run all tests that have a "Test-For" or a "Test-Against" for a given
 tag, use:
 
- $ debian/rules runtests onlyrun=tag:$tag
-
- OR
-
- $ t/bin/runtests --dump-logs -k t debian/test-out tag:$tag
+ $ t/bin/runtests --onlyrun=tag:$name
 
 =back
 
 =head2 Running tests under coverage
 
+This feature is currently untested.
+
 It is possible to run most of the tests under L<Devel::Cover>.  This is
 done by passing I<--coverage> to I<t/bin/runtests>.  Example:
 

doc/tutorial/Lintian/Tutorial/WritingChecks.pod

@@ -6,6 +6,8 @@ Lintian::Tutorial::WritingChecks -- Writing checks for Lintian
 
 =head1 SYNOPSIS
 
+Warning: This tutorial may be outdated.
+
 This guide will quickly guide you through the basics of writing a
 Lintian check.  Most of the work is in writing the two files:
 

doc/tutorial/Lintian/Tutorial/WritingTests.pod

@@ -6,6 +6,8 @@ Lintian::Tutorial::WritingTests -- Short tutorial on writing tests
 
 =head1 SYNOPSIS
 
+Warning: This document may be out of date.
+
 This document attempts to be a short / quick tutorial to the Lintian
 test suite from a test-writer's perspective.  As such, it will only
 cover the standard type of tests (from the "tests" suite).
@@ -32,18 +34,25 @@ They are B<not> used for testing Lintian tags.
 
 =item -
 
-changes / debs / source
+tags
+
+These tests all test for the presence of tags after building test
+packages using skeletons. For most cases, we recommend
 
-These suites are small test suites that test some particular tags for
+ Skeleton: upload-non-native
+
+suites are small test suites that test some particular tags for
 I<.changes>, I<.deb> or I<.dsc> files.  Typically, you will find the
 more exotic tags here, which require some special fiddling and cannot
 be built by a "standard" dh7 + dpkg build.
 
 =item -
 
-tests
+literal
 
-This suite is the standard test suite for testing Lintian tags.
+These tests look to match the literal output of Lintian. These tests
+are useful as general false positives. They also catch Lintian messages
+unrelated to tags.
 
 =back
 
@@ -51,6 +60,8 @@ With this in mind, let us move on to the scope.
 
 =head2 Scope of the tutorial
 
+WARNING: THE REMAINDER OF THIS TUTORIAL IS OUT OF DATE.
+
 The "tests" suite alone is fairly complex on its own.  To keep things
 simple, the tutorial will limit itself to creating a "native"
 package with no special requirements in the "tests" suite.

lib/Lintian/Profile.pm

@@ -158,6 +158,9 @@ sub new {
             my $taginfo = Lintian::Tag::Info->new;
             $taginfo->load($tagpath);
 
+            die "Tag in $tagpath is not associated with a check"
+              unless length $taginfo->script;
+
             unless (exists $self->{'known-tags'}{$taginfo->tag}) {
                 $self->{'known-tags'}{$taginfo->tag} = $taginfo;
                 push(

t/tags/checks/apache2/apache2-modules-general/desc

@@ -2,5 +2,4 @@ Skeleton: upload-native
 Testname: apache2-modules-general
 Version: 1.0
 Description: Several tests related to Apache2 module packages
-Test-Against:
 Check: apache2

t/tags/checks/apache2/apache2-webapplications-general/desc

@@ -2,5 +2,4 @@ Skeleton: upload-native
 Testname: apache2-webapplications-general
 Version: 1.0
 Description: Several tests related to Apache2 web application packages
-Test-Against:
 Check: apache2

t/tags/checks/appstream-metadata/appstream-metadata/desc

@@ -2,5 +2,4 @@ Skeleton: upload-native
 Testname: appstream-metadata
 Version: 1.0
 Description: Test AppStream and udev metadata in binary package
-Test-Against:
 Check: appstream-metadata

t/tags/checks/binaries/binaries-development-package-ships-elf-binary-in-path/desc

@@ -4,5 +4,4 @@ Version: 1.0
 Description: Test for development packages shipping ELF binaries in $PATH
 Default-Build-Depends: debhelper (>= 9.20160114~)
 Dh-Compat-Level: 9
-Test-Against:
 Check: binaries

t/tags/checks/binaries/binaries-doesnt-match-sonames/desc

@@ -4,5 +4,4 @@ Version: 1.0
 Default-Build-Depends: debhelper (>= 9.20151004~)
 Dh-Compat-Level: 9
 Description: Test for library package that does not match SONAME
-Test-Against:
 Check: binaries

t/tags/checks/binaries/binaries-embedded-libs/desc

@@ -3,5 +3,4 @@ Testname: binaries-embedded-libs
 Package-Architecture: any
 Version: 1.0
 Description: Package with binary with library-unique strings
-Test-Against:
 Check: binaries

t/tags/checks/binaries/binaries-from-other-arch/desc

@@ -4,5 +4,4 @@ Test-Architectures: amd64 i386
 Package-Architecture: any
 Version: 1.0
 Description: Test package with a pseudo binary from a different architecture
-Test-Against:
 Check: binaries

t/tags/checks/binaries/binaries-general/desc

@@ -3,5 +3,4 @@ Testname: binaries-general
 Version: 1.0
 Description: Misc errors related to binaries
 Package-Architecture: any
-Test-Against:
 Check: binaries