• Felix Lechner's avatar
    In check menus, split file lists without generating extra spaces. · ee239cdb
    Felix Lechner authored
    Commit f3ca0a90 causes a test to fail, but the extra tags generated do
    not name any files. This is presumably because the split operator may
    work differently than intended.
    
    According to https://perldoc.perl.org/functions/split.html, split
    expects regular expressions as the split operator, except in special
    cases. One such case is a string containing a single space, which may
    be of use here. (The logical alternative /\s+/ did not work, but I did
    not try together with 'next unless length $file'.) The special string
    with one space strips any leading spaces first and therefore prevents
    any strings from being generated, which may cause the issue here.
    
    Converts the separator expression to a string (but not a regular
    expression) containing a single string. Also removes a condition for
    empty strings further below that is no longer needed.
    
    Here is the test failure that shows tags without file names, which was
    probably not intended:
    
    Failed test 'Lintian tags match for legacy-binary'
      at /lcl/lechner/lintian/git/lib/Test/Lintian/Run.pm line 385.
    Tags do not match
    --- debian/test-out/tags/checks/menus/legacy-binary/tags.specified.calibrated.universal
    +++ debian/test-out/tags/checks/menus/legacy-binary/tags.actual.parsed.sorted.universal
    +binary (binary): doc-base-file-references-wrong-path binary:39
    +binary (binary): doc-base-file-references-wrong-path binary:31
    +binary (binary): doc-base-file-references-wrong-path binary:25
    +binary (binary): doc-base-file-references-wrong-path binary:25
    Looks like you failed 1 test of 1.
    debian/test-out/tags/checks/menus/legacy-binary/generic.t ................................ Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/1 subtests
    
    Gbp-Dch: ignore
    ee239cdb
Name
Last commit
Last update
..
apache2.desc Loading commit data...
apache2.pm Loading commit data...
application-not-library.desc Loading commit data...
application-not-library.pm Loading commit data...
appstream-metadata.desc Loading commit data...
appstream-metadata.pm Loading commit data...
automake.desc Loading commit data...
automake.pm Loading commit data...
binaries.desc Loading commit data...
binaries.pm Loading commit data...
changelog-file.desc Loading commit data...
changelog-file.pm Loading commit data...
changes-file.desc Loading commit data...
changes-file.pm Loading commit data...
conffiles.desc Loading commit data...
conffiles.pm Loading commit data...
control-file.desc Loading commit data...
control-file.pm Loading commit data...
control-files.desc Loading commit data...
control-files.pm Loading commit data...
copyright-file.desc Loading commit data...
copyright-file.pm Loading commit data...
cruft.desc Loading commit data...
cruft.pm Loading commit data...
dbus.desc Loading commit data...
dbus.pm Loading commit data...
deb-format.desc Loading commit data...
deb-format.pm Loading commit data...
debconf.desc Loading commit data...
debconf.pm Loading commit data...
debhelper.desc Loading commit data...
debhelper.pm Loading commit data...
debian-readme.desc Loading commit data...
debian-readme.pm Loading commit data...
debian-source-dir.desc Loading commit data...
debian-source-dir.pm Loading commit data...
description.desc Loading commit data...
description.pm Loading commit data...
duplicate-files.desc Loading commit data...
duplicate-files.pm Loading commit data...
elpa.desc Loading commit data...
elpa.pm Loading commit data...
fields.desc Loading commit data...
fields.pm Loading commit data...
filename-length.desc Loading commit data...
filename-length.pm Loading commit data...
files.desc Loading commit data...
files.pm Loading commit data...
gir.desc Loading commit data...
gir.pm Loading commit data...
group-checks.desc Loading commit data...
group-checks.pm Loading commit data...
huge-usr-share.desc Loading commit data...
huge-usr-share.pm Loading commit data...
infofiles.desc Loading commit data...
infofiles.pm Loading commit data...
init.d.desc Loading commit data...
init.d.pm Loading commit data...
java.desc Loading commit data...
java.pm Loading commit data...
lintian.desc Loading commit data...
manpages.desc Loading commit data...
manpages.pm Loading commit data...
md5sums.desc Loading commit data...
md5sums.pm Loading commit data...
menu-format.desc Loading commit data...
menu-format.pm Loading commit data...
menus.desc Loading commit data...
menus.pm Loading commit data...
nmu.desc Loading commit data...
nmu.pm Loading commit data...
obsolete-sites.desc Loading commit data...
obsolete-sites.pm Loading commit data...
ocaml.desc Loading commit data...
ocaml.pm Loading commit data...
patch-systems.desc Loading commit data...
patch-systems.pm Loading commit data...
pe.desc Loading commit data...
pe.pm Loading commit data...
phppear.desc Loading commit data...
phppear.pm Loading commit data...
po-debconf.desc Loading commit data...
po-debconf.pm Loading commit data...
python.desc Loading commit data...
python.pm Loading commit data...
rules.desc Loading commit data...
rules.pm Loading commit data...
scripts.desc Loading commit data...
scripts.pm Loading commit data...
shared-libs.desc Loading commit data...
shared-libs.pm Loading commit data...
source-changelog.desc Loading commit data...
source-changelog.pm Loading commit data...
source-copyright.desc Loading commit data...
source-copyright.pm Loading commit data...
standards-version.desc Loading commit data...
standards-version.pm Loading commit data...
symlinks.desc Loading commit data...
symlinks.pm Loading commit data...
systemd.desc Loading commit data...
systemd.pm Loading commit data...
testsuite.desc Loading commit data...
testsuite.pm Loading commit data...
triggers.desc Loading commit data...
triggers.pm Loading commit data...
udev.desc Loading commit data...
udev.pm Loading commit data...
upstream-metadata.desc Loading commit data...
upstream-metadata.pm Loading commit data...
upstream-signing-key.desc Loading commit data...
upstream-signing-key.pm Loading commit data...
usrmerge.desc Loading commit data...
usrmerge.pm Loading commit data...
version-substvars.desc Loading commit data...
version-substvars.pm Loading commit data...
watch-file.desc Loading commit data...
watch-file.pm Loading commit data...