Prevent false-positives for files called (eg.) readMesh_off.m for the package-contains-documentation-outside-usr-share-doc tag. (Closes: #914500)

Apply a patch from Stephen Kitt to avoid false-positives for the package-does-not-use-debhelper-or-cdbs tag if the call to dh(1) is prefixed with "@", "+" or "-". (Closes: #914538)

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

The new templating system uses 'cp -rp' to copy files. 'rsync' is no longer needed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Since skeletons became the primary way to specify the file layouts for test cases
the directory names for template sets can be more description. The value 'default'
now designates the default skeleton in t/skeletons for a given Lintian suite, and
no longer refers to template sets stored in t/templates.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

These edits to the README explain the general use and mechanism of the flexible
templating system.

This commit also includes information on the discontinued substitution of TESTSET in
Lintian options and how to declare prequisites for a test by using Extra-Build-Depends:,
which adds the dependency to Build-Depends, or Test-Depends:, which does not. Both
features were committed previously.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

debian/control: Add Build-Depends: libfile-find-rule-perl, libpath-tiny-perl and libunicode-utf8-perl

In addition File::Find::Rule and Path::Tiny, we are adding Unicode:UTF8, which the
latter recommends for speed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

This patch implements a templating system that reuses the skeleton declarations similar
to 'Skeleton: default' in the test specifications to process more complex configuration
files.

Previously, the harness simply installed a template set with this name. Using
the new system, tests can utilize multiple template sets and declare their locations in
the filesystem. Test can also utilize multiple template whitelists, which allow the
automatic generation of some files. Whitelists are already the same for all suites;
template sets should be so in short order.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Consistently use (eg.) "DEP 5" over "DEP-5" to match the style used on dep.debian.net. (Closes: #914562)

Changes-by: make -C data/spelling sort

Add lintian itself to @ALLOWED_USES_DPKG_DATABASE to avoid false-positives when running against ourselves.

This reverts commit 09d86b2f as per discussion
on the bug itself.

Apply a patch from Felix Lechner to implement a new file hierarchy for test specifications.  (MR: !74)

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 22, 2018 and Chris Lamb committed Nov 22, 2018

This simplifies the file hierarchy for test specifications. Going forward, the
Debian packaging code will simply be located in ./debian instead of the more
cumbersome ./debian/debian. Please also see the README on 'diff'.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 22, 2018 and Chris Lamb committed Nov 22, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

Templates and a packaging files have been moved up one level. There is no more
need to copy the directory ./debian/debian.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

The template set no longer contains ./debian in the file paths. That path
portion needs to be added when filling templates in 'orig'. (The files in
./debian were moved up a level.)

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

This removes One level of 'debian' from the file locations.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

Eventually, this will simplify the directory structure in test specifications.
Files previously stored in ./debian/debian will just be in ./debian.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

Move packaging files from 'debian' to 'diff' when appropriate (for very few tests that rely on the diff).

This affects very few tests that specifically require a diff to be present.
For most tests, files in similar positions were instead moved to 'orig'.  The
purpose is to clear out ./debian, so that the confusing double directory
./debian/debian can eventually be collapsed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

The purpose is to clear out ./debian so that the confusing double directory
./debian/debian can be collapsed. Upstream files now go into 'orig'. Files for
any diff calculation go into 'diff'. Debian packaging files go into
'debian/debian'.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

This change allows a clean separation of upstream files from Debian packaging
files even for native packages, which are presently the default for tests. It
will help to eliminate the confusing ./debian/debian hierarchy. Also, the test
runner can now more easily swich through native and non-native package formats.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 22, 2018

Exercising caution, I concluded that these files were not needed. In the case
of watch-file-pubkey-missing, neither file was needed. In the other two cases
the files were duplicates of files in ./orig. They all may have been copied
unwittingly from elsewhere.

Signed-off-by: Chris Lamb <lamby@debian.org>

Excerpt from the long description of fonts-ibm-plex/1.1.6-1 which
triggered this addition:

  Support for Arabic, Devanagari, Thai and CJK is planned.

  t/scripts/check-descs.t .. 2165/?
  #   Failed test 'files has unknown collections in Needs-Info'
  #   at t/scripts/check-descs.t line 34.
  #          got: '\n strings'
  #     expected: ''
  # Looks like you failed 1 test of 17466.
  t/scripts/check-descs.t .. Dubious, test returned 1 (wstat 256, 0x100)
  Failed 1/17466 subtests
          (less 2 skipped subtests: 17463 okay)

Gbp-Dch: Ignore

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 21, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 21, 2018 and Chris Lamb committed Nov 21, 2018

t/runtests: Pass "Dh-Compat-Level" to test templates, which allows the parameterization of the debhelper compat level.