Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • galera-4 galera-4
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • MariaDB and MySQL Packaging TeamMariaDB and MySQL Packaging Team
  • galera-4galera-4
  • Merge requests
  • !4

Fix new CMake definitions to correctly use CMAKE_OBJDUMP (Closes: #981652)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Otto Kekäläinen requested to merge bugfix/981652-ftcbfs-objdump into master Feb 04, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Galera-4 fails to cross build from source, because it runs the build architecture objdump on a host architecture ELF object. This is due to hard coding the build architecture objdump in galera/src/CMakeLists.txt. The solution here is to use ${CMAKE_OBJDUMP}, which refers to the correctly detected objdump for the host architecture. Beyond this, it also uses ldd, which is bound to fail during cross compilation. Almost the same effect can be achieved with objdump -x though, so I propose using it here as well. Please consider applying the attached patch as it makes galera-4 cross buildable.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bugfix/981652-ftcbfs-objdump