Signed-off-by: Niels Thykier <niels@thykier.net>

Release debhelper/11.3.5 into unstable

Format: 1.8
Date: Sat, 30 Jun 2018 11:52:51 +0000
Source: debhelper
Binary: debhelper dh-systemd
Architecture: source
Version: 11.3.5
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper@packages.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 debhelper  - helper programs for debian/rules
 dh-systemd - debhelper add-on to handle systemd unit files - transitional pack
Closes: 902355 902748
Changes:
 debhelper (11.3.5) unstable; urgency=medium
 .
   * Dh_Lib.pm: Introduce a new glob_expand error handler to
     better emulate the old style glob code to fail when a
     non-glob entry in the config file is missing.
   * dh_installdocs: Use the new glob_expand error handler to
     restore the behaviour to that of debhelper/10.5.1 and older.
     Thanks to Christoph Berg for reporting the issue.
     (Closes: #902355)
   * dh_installexamples: Ditto.
   * dh_installinfo: Ditto.
   * dh_installman: Ditto.
   * Dh_Lib.pm: Fix a bug where ending debian/control on (what
     debhelper believed was) a comment line could cause debhelper
     to omit the last package listed in the file.  Thanks to
     Santiago Vila for reporting the bug. (Closes: #902748)
Checksums-Sha1:
 fb98a6eebd336cd837d7d549da746c3dbc3c0549 1689 debhelper_11.3.5.dsc
 7686e6f138cff705d5f4d55ad4c458c3d61b6b32 467732 debhelper_11.3.5.tar.xz
 90f8e76c1ea4ad850aae51dfb7820ab729fbb24e 4663 debhelper_11.3.5_source.buildinfo
Checksums-Sha256:
 d1a142e4c29a3394f7472e8621e6966ebaf9f465e93571695622e5fc949470b0 1689 debhelper_11.3.5.dsc
 34d7b4641757c1fbbb3497ff76fccd128409689cf8c7886a92d0c03621b69a95 467732 debhelper_11.3.5.tar.xz
 168b8430915d9e0437c948150598360f495e78722c276f5f456aa2836e8a3d4f 4663 debhelper_11.3.5_source.buildinfo
Files:
 d6d3877f0ae31653a5238ca1e8b53f7a 1689 devel optional debhelper_11.3.5.dsc
 82c28492f0b032e378c9819b1a40de80 467732 devel optional debhelper_11.3.5.tar.xz
 0b3298530249053e6bf68bbe853f15a0 4663 devel optional debhelper_11.3.5_source.buildinfo

Signed-off-by: Niels Thykier <niels@thykier.net>

A trivial work around for this bug is to add an empty line at the end
of the file.

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Apparently the exec-bit is set by default in WSL, so provide a more
helpful error message when debhelper encounters a config file with the
exec-bit that does not have a #!-line (and is not an ELF binary).

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

The last section of the helper generates maintainer scripts code
blocks for mount, path, service, socket, target, and timer units. The
filtering associated to the --name option incorrectly looks for file
names with a ".tmpfile" suffix and not for a ".timer" suffix. Fix it.

The --no-also option not only affected handling of the Also= directive
but also inhibited handling of the Alias= directive. Fix it. Add a few
comments.

Simplify and move to a function the code responsible to list all
installed units. It is much simpler to refer to unit files simply as
their file name without keeping track of their complete path as the
later can be readily computed because all unit files must be installed
into usr/lib/systemd/system.

This removes some confusion and highlight a bug where code blocks for
handling units installed at the wrong location would be emitted if
relative file paths were specified on the command line. Fix the tests
accordingly.

The intention was to carry on all possible work and report missing
unit files specified on the command line at the end of execution.
However, now the scripts fails immediately when it tries to read the
content of the unit filed and the late check is never executed. Remove
the late check.

Make code easier to grock by splitting operation into three phases.
The number of binary packages should be small. Iterating three times
through their names should not impact performances.

Extend the tests to verify that dh_installsystemd comand line
arguments handling works in the simplified form allowed by source
packages building only one binary package.

Signed-off-by: Niels Thykier <niels@thykier.net>

Roberto C. Sánchez authored May 28, 2018 and Niels Thykier committed Jun 10, 2018

This allows params in debian/rules of the form "-D FOO=BAR" instead of
only "-DFOO=BAR" (without quotes).  cmake permits both forms, but
mishandles the directory if any of the params contain a space between
the -D and the var/value.  If the directory is last, it always works.

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>

Signed-off-by: Niels Thykier <niels@thykier.net>