Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Fix autopkgtest that was failing due to missing test dependency on
fakeroot.

It would be cool to specify Rules-Requires-Root:no in the test fixtures,
but test_ppackage_lifecycle compares the dpkg-buildpacakge output, and
it's a pain to do now as we'd need to change the expected output for
stretch vs buster.  Just do it once we are not interested in stretch
anymore.

Closes: #910262
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

sadt: Ignore new restriction 'superficial'

See merge request debian/devscripts!50

In autopkgtest, superficial tests are the opposite of the 'flaky'
restriction: if the test fails, it is counted as a failure, but if it
succeeds, it is counted as though it had been skipped. This allows
autopkgtest to give a different exit status (8 rather than 0) if there
is no real evidence that the package works, because every test was
either skipped or superficial.

The intention is that trivial smoke tests, such as linking a
"hello, world" program to a library without exercising the
library's real functionality, can be marked as superficial.
See https://bugs.debian.org/904979

 for more details. The restriction
was originally proposed as "trivial" but was renamed to "superficial"
during review.

sadt is a simpler test runner and does not distinguish between
successful and skipped tests, so we can treat superficial and
non-superficial tests identically here.

Signed-off-by: Simon McVittie <smcv@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

d/tests: avoid using the deprecated needs-recomends option, and instead explicitly list all the required packages

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

one can't parse cli options after shunit2 already ran.  also, avoid
needlessly running perltidy even if it would be ignored.

and avoid changing directory, instead always using fully qualified
filenames.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

MR: debian/devscripts!48


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

main advantages:
 + move the temporary files to a temporary directory

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

MR: debian/devscripts!47


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Closes: #897382
MR: debian/devscripts!39


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

MR: debian/devscripts!46


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Bug introduced during MOO rewrite => no changelog

Cyril Brulebois authored Jan 15, 2018 and Mattia Rizzolo committed Sep 29, 2018

Closes: #887358
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Dima Kogan authored Apr 09, 2018 and Mattia Rizzolo committed Sep 29, 2018

Previously if the user hit Ctrl-c to terminate a child, debcheckout would treat
that as a "success"

Closes: #895307
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

MR: debian/devscripts!41


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

MR: debian/devscripts!44


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: James McCoy <jamessan@debian.org>

Signed-off-by: James McCoy <jamessan@debian.org>

Signed-off-by: James McCoy <jamessan@debian.org>