Build OCaml test input files on-demand rather than shipping them with the package in order to prevent test failures with OCaml 4.08 (Closes: Debian:#939386, reproducible-builds/diffoscope#67)

This is related to reproducible-builds/diffoscope#66

See also: a960c924

Gbp-Dch: ignore

MR: reproducible-builds/diffoscope!31


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

The compression column was added in October 2017 / v4.7 by
https://review.coreboot.org/c/coreboot/+/22196/

 (0c2f0c1d31)

Signed-off-by: Marc Herbert <Marc.Herbert@gmail.com>

Rebuild test squashfs images to exclude the character device as they requires root or fakeroot to extract, additionally reverting the changes made in reproducible-builds/diffoscope#63. (Closes: reproducible-builds/diffoscope#65

)

Signed-off-by: Chris Lamb <lamby@debian.org>

Update the "no progressbar" logging message to match the parallel "missing tlsh module" warning. (Re: Debian:#939085)

Gbp-Dch: ignore

Closes: #939085
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Ensure that all of our artificially-created subprocess.CalledProcessError instances have `output` instances that are bytes objects, not str.

Gbp-Dch: ignore

Skip calls to unsquashfs when we are not root or fakeroot. (Closes: reproducible-builds/diffoscope#63)

This is a little unfortunate but currently easier than recreating the
test1.squashfs and test2.squashfs test input files to remove the character
device.

See also 4689755d so this general issue is
visible to end-users.

Include either standard error or standard output (and not just the latter) when an external command fails.

Avoid a possible traceback caused by a str/bytes confusion when handling the output of failing external commands.

Gbp-Dch: ignore

Test for "4.4" in the output of "squashfs -version", even though the Debian package version is "1:4.3+git190823-1". Thanks, Mattia. (Re: reproducible-builds/diffoscope#62)

Gbp-Dch: ignore

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Apply patch from László Böszörményi to update the squashfs test output and additionally bump the required version for the test itself. (Closes: reproducible-builds/diffoscope#62, Debian:#935684)

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Correct/revert some in-process debugging code that was accidentally committed in d3c7ac8e.

Don't fallback to a (useless) raw hexdump when, for example, readelf(1) reports an minor issue in a section in an ELF binary. For example, when the "frames" section is of the "NOBITS" type its contents are apparently "unreliable" and thus readelf(1) returns 1). (Closes: reproducible-builds/diffoscope#58, Debian:#931962)

Add support to Difference.from_command_exc and friends to ignore specific returncodes from the called program and treat them as "no" difference.

No need to parse the section group from the class name; we can pass it via type(..)'s kwargs argument.

Gbp-Dch: ignore

Reposition a comment regarding an exception within the indented block. This seems the more-common way of documentation such things, at least in Python.

Gbp-Dch: ignore

I fail at shell, clearly.

Gbp-Dch: ignore

Add an "eg." to the comment on stripping "original size modulo..." text to emphasise that the actual numbers are not fixed.

Gbp-Dch: ignore