Gbp-Dch: ignore

Also conditionally skip the identification and "no differences" tests as we require the Ocaml compiler to be present when building the test files themselves. (Closes: #940471)

Closes: #939387
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Marc Herbert authored Sep 05, 2019 and Chris Lamb committed Sep 08, 2019

Now that StaticLibFile is out of the way, show off ArFile's recursive
ability to:

- not care about the .a suffix and not behave differently depending on
  filenames;
- not crash and lose everything when some archive members are not ELF;
- gracefully fall back and run the next best tool for a cross-compiled
  ELF and a sample of non-ELF members - including the corresponding .c
  source.

Tests issue #64, see more details there.

In addition to the .c source file, the regen_elfmix.sh script that generated
the .a files is embedded in the .a files themselves if ever needed. For
size considerations no cross-compiler is provided.

Signed-off-by: Chris Lamb <lamby@debian.org>

Gbp-Dch: ignore

Marc Herbert authored Sep 05, 2019 and Chris Lamb committed Sep 08, 2019

Remove StaticLibFile in the ELF comparator; ArFile.compare_details() is superior. (Closes: reproducible-builds/diffoscope#64

)

Remove the old code in the StaticLibFile class as it now duplicates the
recursion in ArFile.compare_details() in a much inferior way. Fixes issue #64,
see the multiple use cases there and in the next commit adding tests.

The patch header line in the test output is decremented one line because when
run on .a files readelf inserted headings like this:

  In archive test1.a:

Signed-off-by: Chris Lamb <lamby@debian.org>

Marc Herbert authored Sep 06, 2019 and Chris Lamb committed Sep 08, 2019

Revert "Don't assume all files called ".a" are ELF binaries because we specified a FILE_EXTENSION_SUFFIX. This prevents an "Unrecognized archive format" traceback when processing (for example) lie 2.2.2+dfsg-3. (Closes: #903446)"

This reverts commit cd4c6423

 in preparation for
fixing issue #64.

Signed-off-by: Chris Lamb <lamby@debian.org>

Gbp-Dch: ignore

Gbp-Dch: ignore

Build OCaml test input files on-demand rather than shipping them with the package in order to prevent test failures with OCaml 4.08 (Closes: Debian:#939386, reproducible-builds/diffoscope#67)

This is related to reproducible-builds/diffoscope#66

See also: a960c924

Gbp-Dch: ignore

MR: reproducible-builds/diffoscope!31


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

The compression column was added in October 2017 / v4.7 by
https://review.coreboot.org/c/coreboot/+/22196/

 (0c2f0c1d31)

Signed-off-by: Marc Herbert <Marc.Herbert@gmail.com>

Rebuild test squashfs images to exclude the character device as they requires root or fakeroot to extract, additionally reverting the changes made in reproducible-builds/diffoscope#63. (Closes: reproducible-builds/diffoscope#65

)

Signed-off-by: Chris Lamb <lamby@debian.org>

Update the "no progressbar" logging message to match the parallel "missing tlsh module" warning. (Re: Debian:#939085)

Gbp-Dch: ignore

Closes: #939085
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Ensure that all of our artificially-created subprocess.CalledProcessError instances have `output` instances that are bytes objects, not str.

Gbp-Dch: ignore

Skip calls to unsquashfs when we are not root or fakeroot. (Closes: reproducible-builds/diffoscope#63)

This is a little unfortunate but currently easier than recreating the
test1.squashfs and test2.squashfs test input files to remove the character
device.

See also 4689755d so this general issue is
visible to end-users.

Include either standard error or standard output (and not just the latter) when an external command fails.

Avoid a possible traceback caused by a str/bytes confusion when handling the output of failing external commands.

Gbp-Dch: ignore

Test for "4.4" in the output of "squashfs -version", even though the Debian package version is "1:4.3+git190823-1". Thanks, Mattia. (Re: reproducible-builds/diffoscope#62)

Gbp-Dch: ignore

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore