Extract resources.arsc files as well as classes.dex from Android .apk files to ensure that we at least show differences there. (Closes: Debian:#916359, reproducible-builds/diffoscope#27)

Marc Herbert authored Jan 09, 2020 and Chris Lamb committed Jan 10, 2020

Spotted by chance while looking at unrelated performance issue #84

This line was added by commit 509509e3



Signed-off-by: Chris Lamb <lamby@debian.org>

Gbp-Dch: ignore

Don't exhaustively output the entire HTML report when testing the regression for #875281; parsing the JSON and pruning the tree should be enough. (Closes: reproducible-builds/diffoscope#84)

Marc Herbert authored Jan 02, 2020 and Chris Lamb committed Jan 03, 2020

"Drive-through" contributor here. As in many other projects, one of the
most time-consuming step before starting to do any actual work is
finding in my bash history (!) the right tox/pytest/test_foo.sh
incantation. No surprise maintainers have to beg for test(s) all the
time ;-P

Signed-off-by: Chris Lamb <lamby@debian.org>

Always pass a filename with a ".zip" extension to zipnote, otherwise it will return with an exit code of 9 and revert to a binary diff for the entire file.

eg:

```
├── scrcpy-server_1.11+ds-1_all.deb
│ ├── data.tar.xz
│ │ ├── data.tar
│ │ │ ├── ./usr/share/scrcpy/scrcpy-server
│ │ │ │┄ Command `zipnote /srv/reproducible-results/rbuild-debian/tmp.nUXKuYqaZC/dbd-tmp-LUse4MQ/diffoscope_umwd1nq2/tmp0lwevy98/0/8` exited with exit code 9. Standard output:
│ │ │ │┄     zipnote error: Interrupted (aborting)
│ │ │ │ @@ -1,20 +1,20 @@
│ │ │ │ -00000000: 504b 0304 1400 0808 0800 a914 9b4f 0000  PK...........O..
│ │ │ │ +00000000: 504b 0304 1400 0808 0800 6558 3d52 0000  PK........eX=R..
│ │ │ │  00000010: 0000 0000 0000 0000 0000 0900 0400 4d45  ..............ME
```

Gbp-Dch: ignore

This reverts commit 8833cc8a.

We're trying to check whether the finished attribute has not yet been
defined to True, but in the case we're searching for, it hasn't been
defined at all and simply raises an AttributeError.

Since any case where it's undefined is by definition the False case
we're looking for, fall back to that.

Include the  libarchive file listing for ISO images to ensure that timestamps (and not just dates) are visible in any difference. (Closes: reproducible-builds/diffoscope#81)

Ensure that autopkgtests are run with our pyproject.toml present for the correct black source code formatter settings. (Closes: #945993)

Gbp-Dch: ignore

Correct the substitution/filtering of paths in ELF output to avoid unnecessary differences depending on the path name provided to diffoscope. (Closes: reproducible-builds/diffoscope#80, Debian:#945572)

Silence/correct a SyntaxWarning message due to incorrectly comparing an integer by identity vs. equality. Thanks, Boyuan Yang. (Closes: Debian:#945531, reproducible-builds/diffoscope#79)

Gbp-Dch: ignore

Allow all possible .zip variations to return with non-zero exit codes, not just known types we can identify (eg. Java .jmod and .jar files). (Closes: reproducible-builds/diffoscope#78)

Gbp-Dch: ignore

Update an Android manifest test to reflect that parsed XML attributes are returned in a new/sorted manner under Python 3.8.

Add a comment that the text_ascii{1,2} fixture files are used in multiple tests so is not trivial to remove/replace.

Limit .dsc and .buildinfo file matching to files in ASCII format. (Closes: reproducible-builds/diffoscope#77)

Revert "Drop two more test fixture fires for the directory tests." - need to fix some other tests too.

This reverts commit a0f7a11b.

Don't run our meta/self black source code reformatter test for versions earlier than 19.10b0 as it will generate different results.