Improve documentation of FILE_TYPE_HEADER_PREFIX and FALLBACK_FILE_TYPE_HEADER_PREFIX to remark that only the first 16 bytes are used.

Add "pdftotext" as a requirement to run the PDF test_metadata text. Special thanks to Chocimier/Piotr for the debugging work. (Closes: reproducible-builds/diffoscope#99)

Gbp-Dch: ignore

Gbp-Dch: ignore

Render multiline difference comments in a way to show indentation. (Closes: reproducible-builds/diffoscope#101)

The current description of the --exclude option only says that it
excludes files matching the glob.  It does not explicitly say whether
the file's base name or full name is used.  Document that the full
filename is used.

Gbp-Dch: ignore

Gbp-Dch: ignore

Gbp-Dch: ignore

Gbp-Dch: ignore

Michael Osipov authored Apr 15, 2020 and Chris Lamb committed Apr 15, 2020

Revert to using zipinfo(1) directly instead of piping input via /dev/stdin for BSD portability. (Closes: reproducible-builds/diffoscope#97)

I have noticed that 25fee28c

 [via #879011] uses a non-portable approach by
utilizing the /dev/stdin symlink. zipinfo exits with 9. I have described the
problem with /dev/stdin in detail here, and about its non-portability.  The
upshot is:

 * /dev/stdin is not POSIX
 * It may not behave the way you expect
 * unzip explicitly does not support pipe or character devices:

    Archives read from standard input are not yet supported, except with
    funzip (and then only the first member of the archive can be
    extracted).

When you read the source code you'll see that stat(2) output is not
checked for regular file and it queries the stat struct for st_size is
is 0 for streams like pipes or character devices.

It maybe some special feature of Linux/glibc to replace the stat
information of /dev/stdin of the file read, but that is, IMHO, highly
questionable.

Signed-off-by: Chris Lamb <lamby@debian.org>

Explicitly list python3-h5py in debian/tests/control.in to ensure that we have this module installed during an autopkgtest run to generate the test fixure.

Dalvik .dex files can also serve as APK containers so restrict the narrower identification of .dex files to files ending with this extension, and widen the identification of APK files to when file(1) discovers a Dalvik file. (Closes: Debian:#884095, reproducible-builds/diffoscope#28)

This is essentially functionally equivalent (yet superior to) always
identifying files named *.apk as APK containers or adding a command-line switch
to "force" identification.

This is not a bug in file(1) as the files do legitimately differ in their
magic numbers:

    $ xxd HelloWorld.apk | head -n1
    00000000: 504b 0304 0a00 0000 0800 c907 c37d 8dea  PK...........}..

    $ xxd helloworld-janus.apk | head -n1
    00000000: 6465 780a 3033 3500 b5f7 4441 c609 399e  dex.035...DA..9.

Jelle van der Waa authored Apr 12, 2020 and Holger Levsen committed Apr 13, 2020

Signed-off-by: Holger Levsen <holger@layer-acht.org>

Gbp-Dch: ignore

apktool 2.5.0 changed the handling of output of XML schemas, so update and restrict the corresponding test to match. (Closes: reproducible-builds/diffoscope#96)

Gbp-Dch: ignore

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Inject the supported file formats into the package long description. (Closes: reproducible-builds/diffoscope#90)

Ensure we only parse the recommended packages from --list-debian-substvars when we want them for debian/tests/control generation.