Jean-Romain Garnier authored May 29, 2020 and Chris Lamb committed May 30, 2020

Prevent an issue where (for example) LibarchiveMember's has_same_content method is called regardless of the actual type of file.

Signed-off-by: Chris Lamb <lamby@debian.org>

Normalise filesystem stat(2) "birth times" (ie. st_birthtime) in the same way we do with stat(1)'s "Access:" and "Change:" times to fix a nondetermistic build failure on GNU Guix. Thanks, Vagrant and Chocimier. (Closes: reproducible-builds/diffoscope#74)

Refactor .changes and .buildinfo handling to show all details (including the GPG header and footer components) even when referenced files are not present. (Closes: reproducible-builds/diffoscope#122)

Drop the (default) subprocess.Popen(shell=False) keyword argument so that the more unsafe shell=True is more obvious.

Closes: #949598
Fixes: #89


Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Gbp-Dch: ignore

Use a BuildinfoFile (etc.) regardless of whether the associated files such as the orig.tar.gz and the .deb are present. (Re: reproducible-builds/diffoscope#122)

Add matching comments to tie up a slightly abstraction-breaking bit of code in diffoscope.comparators.mising_file and the .dsc/.buildinfo file handling.

Don't leak the full path of the temporary directory in "Command [..] exited with 1". (Closes: reproducible-builds/diffoscope#126)

We retain it in the Python log/debug messages.

Clarify "Command [..] failed with exit code" to remove duplicate "exited with exit" but also to note that diffoscope is intepreting this as an error.

Fixes: lintian: debian-changelog-line-too-long
See-also: https://lintian.debian.org/tags/debian-changelog-line-too-long.html

Use SHA256 over MD5 when generating page names for the HTML directory presenter. (Closes: reproducible-builds/diffoscope#124)

Gbp-Dch: ignore

Validate checksums for files referenced in .changes files using SHA256 over SHA1. (Re: reproducible-builds/diffoscope#124)

Emanuel Bronshtein authored May 18, 2020 and Chris Lamb committed May 18, 2020

Avoid build-cache in building the released Docker image. (Closes: reproducible-builds/diffoscope#123)

Gbp-Dch: ignore

Prevent CI (and runtime) apksigner test failures due to lack of binfmt_misc on Salsa CI and elsewhere.

In Debian, the `apksigner` binary is a symbolic link to the .jar file itself,
requiring binfmt_misc support to execute directly. We therefore resolve its
location and pass that to `java -jar` instead

Add support for printing the signatures via apksigner(1). (Closes: reproducible-builds/diffoscope#121)

Gbp-Dch: ignore