Gbp-Dch: ignore

Collapse --acl and --xattr into --extended-filesystem-attributes to cover all of these extended attributes, defaulting the new option to false (ie. to not check these very expensive external calls).

Dimitrios Apostolou authored Jan 08, 2021 and Chris Lamb committed Jan 18, 2021

This offers a significant speedup to directory comparisons
by skipping invocation of utilities getfacl and lsattr.

Dimitrios Apostolou authored Jan 08, 2021 and Chris Lamb committed Jan 18, 2021

We compare (some fields at least) using python's os.lstat().
Only if we find differences, we call external stat command
so that we can generate a diff using its output.

This fixes some dpkg-gencontrol warnings:
dpkg-gencontrol: warning: package diffoscope: substitution variable ${diffoscope-minimal:Recommends} unused, but is defined
dpkg-gencontrol: warning: package diffoscope-minimal: substitution variable ${diffoscope:Recommends} unused, but is defined

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Ignore the DeprecationWarning regarding the `imp` module deprecation, as it comes from a 3rd party library

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

This saves a DeprecationWrning in jenkins.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Gbp-Dch: ignore

Commands with short outputs, like `stat`, `getfacl` and `lsattr`, now store
all their output in memory buffers and we run an in-memory comparison first.
We proceed to call `diff` only if the buffers are not identical.

* If the two sizes are different, files are different
* Else read the first SMALL_FILE_THRESHOLD bytes (64K)
  * If the first bytes are different, files are different
  * Else first bytes are identical, and if file size is
    <= SMALL_FILE_THRESHOLD then files are identical

Only if all these checks fail, spawn external command `cmp -s` to do the
comparison.

Conrad Ratschan authored Nov 28, 2020 and Chris Lamb committed Jan 05, 2021

Add comparator for U-Boot Flattened Image Tree files. Add required tools
and tests.

Dimitrios Apostolou authored Jan 04, 2021 and Chris Lamb committed Jan 05, 2021

Previously the temporary directories where all left in place until the
end of the process, when a massive cleanup was being run. The cause
was the _DIRS variable that was holding references to the
TemporaryDirectory objects, so their destructor was not running.

We now remove the _DIRS list completely (replacing it with _BASEDIR for
storing only the parent temporary directory). As a result, the temporary
directories and their contents are being cleaned up automatically when
the class destructor runs.

This in turn requires modifications to preexisting code:

1. Code that was directly using `get_temporary_directory().name`
   stopped working; the object from `get_temporary_directory()`
   needs to be referenced directly to keep it alive.
2. `get_temporary_directory()` is now starting a `with` block
   (context manager) where it was straightforward.

Dimitrios Apostolou authored Jan 04, 2021 and Chris Lamb committed Jan 05, 2021

These files can be seen in thousands, named "fifo1" and "fifo2", under the
temporary directory while diffoscope still runs. Instead of cleaning up
massively in the end, we now clean up while we go.

re-order tests so that the previous does-not-exist test doesn't influence the test_all_tools_are_listed

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Fixes: reproducible-builds/diffoscope#228



Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Normalise "ret" to "retq" in objdump output to support multiple versions of obdump(1). (Closes: reproducible-builds/diffoscope#227, Debian:#976760)

Jean-Romain Garnier authored Jul 03, 2020 and Chris Lamb committed Dec 09, 2020

Excepted output was missing checksum values

Update debian/copyright to match copyright notices in source-tree. (Closes: reproducible-builds/diffoscope#224)