Gbp-Dch: ignore

Strip newlines when determining Black version to avoid "requires black >= 20.8b1 (18.9b0\n detected)" in test output.

Fix tempfile/weakref handling in Python 3.7 (ie. Debian buster). (Closes: reproducible-builds/diffoscope#239)

Gbp-Dch: ignore

Mark test_apk.py::test_android_manifest as being allowed to fail for now. (Re: reproducible-builds/diffoscope#237)

Don't rely on magic.Magic(...) to have an identical API between file's magic.py and PyPI's python-magic library. (Closes: reproducible-builds/diffoscope#238)

May break with device-tree-compiler in buster.

This reverts commit cbb229f3.

This can happen during (for example) tests that call `main(...)`.

Ensure we cleanup our temporary directory by avoiding confusion between the TemporaryDirectory instance and underlying directory. (Closes: #981123)

We were calling shutil.rmtree on the TemporaryDirectory instance, rather
than its `.name` attribute. Also add a comment about why we can't store
the directory name and we need to keep the instance around.

Gbp-Dch: ignore

Prefer to use magic.Magic over the magic.open compatibility interface. (Closes: reproducible-builds/diffoscope#236)

See <https://github.com/ahupp/python-magic/blob/master/COMPAT.md> for more info.

Explicitly remove our top-level temporary directory. (Closes: reproducible-builds/diffoscope#234, Debian:#981123)

We cannot rely on __del__ being called determinstically, if at all, and
lets remove our top-level directory. Thanks to Dimitrios Apostolou and
Mattia Rizzolo.

This essentially reverts commit c645d403.

Gbp-Dch: ignore

Save sys.argv in our top-level temporary directory, in case it helps debug errant temporary directories.

Ref: reproducible-builds/diffoscope#234

Clarify in a comment that __del__ is not always called, so temporary directories are not neccessary removed the *moment* they go out of scope.

At least in CPython...

Ref: reproducible-builds/diffoscope#234

Conrad Ratschan authored Jan 27, 2021 and Chris Lamb committed Jan 28, 2021

Use manual magic comparison for FIT images (device tree blob) to work
around a bug in libmagic that results in device tree blob files not
correctly being identified when the structure section is larger than 1MB.

libmagic bug report: https://bugs.astron.com/view.php?id=232



Signed-off-by: Chris Lamb <lamby@debian.org>

Increase fuzzy matching threshold to ensure that we show more differences. (Closes: reproducible-builds/diffoscope#232)

The two files in this bug report had a score of 74, but another file had a
score of 106.

Gbp-Dch: ignore

Gbp-Dch: ignore

Collapse --acl and --xattr into --extended-filesystem-attributes to cover all of these extended attributes, defaulting the new option to false (ie. to not check these very expensive external calls).