If Config().parallel is True, uses comparison_pool's map method to run
file comparison asyncronously. Defaults to serial comparison.

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>

Checks if dill and multiprocess are importable. If they aren't,
Config().parallel flag will be set to false.

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>

ComparisonPool aims to centralize the logic behind pool and process
handling. It has a .map method, used to parallelize a given command
between its pools.

So far, ComparisonPool's pool size defaults to cpu_count().

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>

tempfiles: save a bunch of syscalls, by resetting the permissions only when we actually need to do it.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Recursively reset the permissions of temporary directories prior to deletion to ensure that non-writable permissions such as 0555 are removed and do not cause a traceback. (Closes: #891363)

Additionally extract the classes.dex file from .apk files; apktool does not do this by default which was was preventing us recursing into it to find differences. Thanks to Hans-Christoph Steiner <hans@eds.org> for the report. (Closes: #890904)

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Juliana Oliveira authored Jan 25, 2018 and Mattia Rizzolo committed Feb 28, 2018

There is no need for two stderr properties.

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>

Juliana Oliveira authored Feb 10, 2018 and Mattia Rizzolo committed Feb 28, 2018

Since wait() now only returns its process returncode, there is no need
to keep it. This patch adds a returncode property to Command and
replaces .wait when catching exit codes.

Juliana Oliveira authored Feb 10, 2018 and Mattia Rizzolo committed Feb 28, 2018

Popen requires thread/IO micromanaging, and locks some interactions
with multiprocess lib due to its combined behavior with subprocess.PIPE, being
unusable with .map function. Subprocess.run simplifies command execution
by managing threads/IO and is also recommended over Popen since Python
3.5.

As a result, stderr and stdout were also simplified.

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Add support for comparing Berkeley DB files. This is currently incomplete because the Berkeley DB libraries do not return the same uid/hash reliably (it returns "random" memory contents) so we must strip those from the human-readable output. (Closes: #890528)

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Juliana Oliveira authored Jan 31, 2018 and Mattia Rizzolo committed Feb 05, 2018

Uses procyon-decompiler as main option for ClassFiles and javap
as a fallback. (Closes: #849386)

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

FileNotFoundError is randomly found when spawning async processes

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>