Downgrade package-uses-vendor-specific-patch-series from "E:" to "W:" as they are not RC bugs until the release of buster.

Apply a patch series from Felix Lechner to implement a universal test runner with file-based default values. (MR: !76)

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 27, 2018 and Chris Lamb committed Dec 03, 2018

The way of reading the default file here (via
Lib::Test::Lintian::ConfigFile::read_config) eliminates any duplication when
hash keys contained hyphens. Previously, such hash keys had to be converted
manually. Now it is automatic. As an example, "Package-Architecture: any" is
converted to $testdata->{package_architecture} = 'any', which can now be used
directly in template substitutions.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 27, 2018 and Chris Lamb committed Dec 03, 2018

Add file with default values for 'desc' test descriptions; to be read when configuring and running tests.

The test runner hardcodes default values for various options, including the
template fill data. This commit adds a file with default values. Some values
remain dynamic. For the majority of values, however, the new mechanism offers a
simpler way to maintain them.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 26, 2018 and Chris Lamb committed Dec 03, 2018

Here the three test runners are combined into one. Now their behavior is
uniform. Going forward it will be much easier to implement new features. (They
will no longer exist in potentially three forms.) This is an important step
before advanced test features can be added.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 26, 2018 and Chris Lamb committed Dec 03, 2018

By reading a special file called 'builder' the test runner determines the build
command and the build product. The runner prefills this special file before any
other templates and reads it into the data structure used for the remaining
templates.

This commit is another step in decoupling the build process from each suite. It
will ultimately allow the unification of the three separate test runners.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 02, 2018 and Chris Lamb committed Dec 03, 2018

This commit causes the runner to use templates and skeletons updated for
make-based builders for the suite 'tests'. It will allow the unification of the
three test runners.

Extensive testing has not shown a speed disadvantage despite the overhead of
using 'make'. Should the need arise any other executable, including a compiled
binary, could serve as a builder. It would be configured solely via the
templating system, which can also be overridden by each test.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Dec 03, 2018

Here, the skeletons for each suite are extended to serve make-based templates
for each suite.  When the templates are filled, each will provide a make-based
build system.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Dec 03, 2018

These whitelists allow the automatic generation of Makefiles and associated
builder declarations.  They further decouple the runner from each Lintian test
suite. They will be helpful when implementing a universal/unified test runner
later on.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Dec 03, 2018

These builder declarations desribe how to (re-)build test cases. For now, they
are all based on 'make', but they are flexible. It could be any command that
produces the declared build product (and thus the subject of the Lintian
examination) for a particular suite.

Signed-off-by: Chris Lamb <lamby@debian.org>

Allow packages to define an RPATH under /usr/lib/ghc/ as the Haskell team have their own scheme for this. (Closes: #914873)

Drop the debian-rules-makemaker-prefix-is-deprecated tag as the transition was completed in 2015. (Closes: #914885)

Adam Conrad authored Nov 29, 2018 and Chris Lamb committed Dec 02, 2018

Fix two typos introduced when parameterising test architectures in 9e128d0f & fd01abbf

. (MR: !79) (Closes: #914952)

Signed-off-by: Chris Lamb <lamby@debian.org>

Jessica Clarke authored Nov 28, 2018 and Chris Lamb committed Dec 02, 2018

The current condition is bogus and always takes the else branch since
DEB_BUILD_ARCH is the Debian architecture not the multiarch triple. The test
almost looked like this originally, except (other than the technically
irrelevant build vs host architecture) it was using DEB_BUILD_GNU_TYPE, which
is i686-linux-gnu on i386, rather than DEB_BUILD_MULTIARCH, which is
i386-linux-gnu, so lintian ignored scanning the directory, leading to the
original bug report.

Signed-off-by: Chris Lamb <lamby@debian.org>

Apply a patch from Felix Lechner to fail tests with outdated specifications (ie. ./debian/debian exists). (MR: !77)

Felix Lechner authored Nov 29, 2018 and Chris Lamb committed Dec 02, 2018

The structure of test specifications changed with the commit series surrounding
abb6f414

. This commit causes a test to fail when an old directory is found in
its specification in t/tests.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 27, 2018 and Chris Lamb committed Dec 02, 2018

The structure of test specifications changed with the commit series surrounding
abb6f414

. This commit forces a rebuild of the work directory when an old
directory is found in ./debian/test-out/.

Signed-off-by: Chris Lamb <lamby@debian.org>

Prevent false-positives for files called (eg.) readMesh_off.m for the package-contains-documentation-outside-usr-share-doc tag. (Closes: #914500)

Apply a patch from Stephen Kitt to avoid false-positives for the package-does-not-use-debhelper-or-cdbs tag if the call to dh(1) is prefixed with "@", "+" or "-". (Closes: #914538)

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

The new templating system uses 'cp -rp' to copy files. 'rsync' is no longer needed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Since skeletons became the primary way to specify the file layouts for test cases
the directory names for template sets can be more description. The value 'default'
now designates the default skeleton in t/skeletons for a given Lintian suite, and
no longer refers to template sets stored in t/templates.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

These edits to the README explain the general use and mechanism of the flexible
templating system.

This commit also includes information on the discontinued substitution of TESTSET in
Lintian options and how to declare prequisites for a test by using Extra-Build-Depends:,
which adds the dependency to Build-Depends, or Test-Depends:, which does not. Both
features were committed previously.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

debian/control: Add Build-Depends: libfile-find-rule-perl, libpath-tiny-perl and libunicode-utf8-perl

In addition File::Find::Rule and Path::Tiny, we are adding Unicode:UTF8, which the
latter recommends for speed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

This patch implements a templating system that reuses the skeleton declarations similar
to 'Skeleton: default' in the test specifications to process more complex configuration
files.

Previously, the harness simply installed a template set with this name. Using
the new system, tests can utilize multiple template sets and declare their locations in
the filesystem. Test can also utilize multiple template whitelists, which allow the
automatic generation of some files. Whitelists are already the same for all suites;
template sets should be so in short order.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Nov 23, 2018 and Chris Lamb committed Nov 25, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Consistently use (eg.) "DEP 5" over "DEP-5" to match the style used on dep.debian.net. (Closes: #914562)

Changes-by: make -C data/spelling sort