- 07 Dec, 2018 2 commits
-
-
Chris Lamb authored -
Chris Lamb authored
-
- 05 Dec, 2018 17 commits
-
-
Chris Lamb authored
-
This change completes the transformation to suite-independent templates. The next step is to consolidate duplicated sets. Signed-off-by:
Chris Lamb <lamby@debian.org> -
Adjust the name of the template sets in each skeleton to point to the correct name. Signed-off-by:Chris Lamb <lamby@debian.org> -
Some template sets are very similar between suites. In an effort to make them easier to maintain, suites will share templates going forward. This commit removes the template sets out of their suite-specific paths and makes the suite part of their name. Signed-off-by:Chris Lamb <lamby@debian.org> -
Chris Lamb authored
Apply a patch series from Felix Lechner to make "pedantic" templates the default for all tests. (MR: !87)
-
The changelogs were outdated, unmaintained, over nine years old and quite short. With modern version control systems, there may not be a need for such changelogs. These two will probably not be needed anymore. This commit removes both. Signed-off-by:Chris Lamb <lamby@debian.org> -
There are no tests that use the 'default' template set for Debian files. This commit removes the set. Signed-off-by:Chris Lamb <lamby@debian.org> -
There are no tests that use the 'pedantic' template set for upstream files. This commit removes the set. Signed-off-by:Chris Lamb <lamby@debian.org> -
There are no tests that use the 'default' skeleton. This commit removes it. Signed-off-by:Chris Lamb <lamby@debian.org> -
The default skeleton provides all the features of the pedantic skeleton, except it provides no upstream files. This commit switches all tests that used the pedantic skeleton over to "default." Signed-off-by:Chris Lamb <lamby@debian.org> -
Four tests check if the Changes file supplied by a skeleton was overridden in the package, but that did not generate the desired tag when the file was removed from the skeleton, because the overriding file was empty. A non-empty file is a better choice. This commit provides one each for four tests. Signed-off-by:Chris Lamb <lamby@debian.org> -
With the planned retirement of the 'default' template set, the default skeleton was switched to use the files from 'pedantic' instead. Signed-off-by:Chris Lamb <lamby@debian.org> -
The copyright file in the 'pedantic' template set had no newline at the end of the file. This commit adds one. Signed-off-by:Chris Lamb <lamby@debian.org> -
After combining files from both template sets, the copyright for 'pedantic' was amended to also include the information for 'default' as well. The latter may be dropped in the near future. With the most recent entry going back more than nine years, an additional entry was made for derivative work. Signed-off-by:Chris Lamb <lamby@debian.org> -
The control file template in the 'pedantic' template set was missing automatic dependencies for shared libraries. In order to use the template more widely in the future, missing placeholders were copied from the 'default' template set. Signed-off-by:Chris Lamb <lamby@debian.org> -
The 'pedantic' template set had a hardcoded distribution. The changelog file from the 'default' set was instead imported for further use. Signed-off-by:Chris Lamb <lamby@debian.org> -
The test cruft-obsolete-upstream-metadata attempts to create a plain file in a place where modern Debian policy requires a directory (debian/upstream/metadata). The operation fails when a template set, such as the 'pedantic' Debian packaging files, have already installed a directory. This commit checks for such file/directory conflicts and removes offending paths before copying anything. Signed-off-by:Chris Lamb <lamby@debian.org>
-
- 04 Dec, 2018 18 commits
-
-
The fix to #912292 (in commit f48c9236) makes several updates to the known Java class file versions but appears to require, in addition, an upward adjustment of 'max-bytecode-existing-version'. Otherwise, the test 'java-class-format' produces the following regression: @@ -1,2 +1,2 @@ -W: libtest-java: incompatible-java-bytecode-format Java12 version (Class format: 56) W: libtest-java: unknown-java-class-version usr/share/java/testa-1.0.jar (org/debian/lintian/TestA.class -> 42) +W: libtest-java: unknown-java-class-version usr/share/java/testb-1.0.jar (org/debian/lintian/TestB.class -> 56) fail tests::java-class-format: output differs! An inspection of 'TestB.class' shows that the major version is being read correctly. It is just not interpreted right. This commit causes the test to pass without errors. Last modified Dec 4, 2018; size 278 bytes MD5 checksum d41318995b87081fd003c4da42f3562d Compiled from "TestB.java" public class org...
-
Chris Lamb authored
-
In this instance, it may not be any safer but it is probably good practice. Signed-off-by:Chris Lamb <lamby@debian.org> -
Chris Lamb authored
Apply a patch series from Felix Lechner to provide a generalised facility to make any test template set independent of the package format. (MR: !82)
-
The test 'cruft-empty-diff' replicated all standard templates in ./orig. Here we instead use the script ./pre_upstream to copy all filled Debian files into the package directory before the orig.tar.gz is created. It also renders the diff empty, but is probably more fool- and future-proof. Signed-off-by:Chris Lamb <lamby@debian.org> -
test to remain undisturbed "as a test of Lintian's handling of old ... template packages". This commit stops the use of standard templates, which in the past provided missing files. During the build process, dh_clean is called. It errors out when no compat file is present. To get the test to run, a compat file is now generated through the pre_build script. This is done dynamically so that the set of static files is not modified, as requested by the original author. Some tags appeared when the use of default templates was discontinued. Those tags were added. Signed-off-by:Chris Lamb <lamby@debian.org> -
Judging from the file orig/README the original author intended this test to remain undisturbed "as a test of Lintian's handling of old ... template packages". This commit stops the use of standard templates, which in the past provided missing files. During the build process, dh_clean is called. It errors out when no compat file is present. To get the test to run, a compat file is now generated through the pre_build script. This is done dynamically so that the set of static files is not modified, as requested by the original author. Some tags appeared when the use of default templates was discontinued. Those tags were added. Signed-off-by:Chris Lamb <lamby@debian.org> -
This skeleton only installs (and fills) build files, but it does not supply any Debian templates (although it will fill them). Tests like generic-dh-make-* were meant to be snapshots in time. In the past, they were seeded with standard template sets like other tests. That may conflict with the intentions of their original authors. This commit creates a more suitable skeleton for their use. This skeleton also allows the script pre_build to be generated from a template. That functionality is needed to supply debian/compat to both tests mentioned above without modifying any of their static Debian files. Signed-off-by:Chris Lamb <lamby@debian.org> -
This commit will execute a post-template script, if present. It is part of a new mechanism to ensure that native packages are not supplied with watch files. With this commit, we can restore the two tests generic-dh-make-2005 and generic-dh-make-2008 to their original functionality: when they were conceived, dh-make did not create watch files. Until now, neither test showed the associated warnings because a template set supplied the missing file. Very soon the two tests will no longer draw on external Debian template sets. Instead they will trigger all the warnings their original authors intended. Signed-off-by:Chris Lamb <lamby@debian.org> -
For a long time, the Lintian test suite automatically created watch files for non-native packages. That worked well, except in some corner cases. Some tests compensated by removing the file in the pre_build script. This commit is part of a series that changes that mechanism. The watch file is now supplied by a template set and removed right after the templates are copied into a test's work directory. The processing takes place earlier. It allows tests deal with watch files like they do with any other file that is (or is not) supplied by template sets. Signed-off-by:Chris Lamb <lamby@debian.org> -
Watch files were previously created in builder Makefiles. For some tests, that was too late in the process. Now they are supplied as part of template sets. For native packages, the watch files supplied herein will be removed by post-template scripts. That script is supplied elsewhere. Signed-off-by:Chris Lamb <lamby@debian.org> -
Some templates require adjustment after they were copied to a test's work directory. For native packages, a post-template script will remove any watch files that may have been shipped as part of a template. This commit only sets the name of the script. The script is provided by a template set. Signed-off-by:Chris Lamb <lamby@debian.org> -
This script causes any watch file (or its template) that was shipped as part of other template sets to be deleted, if a package is native. Signed-off-by:Chris Lamb <lamby@debian.org> -
The templating system does not preserve file permissions, but scripts must be executable to run. This commit applies the file permissions of the template to any generated file. Going forward, scripts generated from templates can also run. This change is important for a new mechanism to generate debian/watch and is also used to supply compat files to the tests generic-dh-make-*, which were created without it. Modern Debian tools require compat. The script was a way to add it without modifying the debian files originally created by dh-make. Signed-off-by:Chris Lamb <lamby@debian.org> -
The test does not remove debian/upstream/metadata before generating it as a FIFO. That causes an error if the file exists, for example when it is supplied by a template like 'pedantic'. Here the file is removed before the FIFO is created. Signed-off-by:Chris Lamb <lamby@debian.org> -
Chris Lamb authored
Apply a patch from Felix Lechner to remove an incorrect line number in the output of the fields-bugs-field-does-not-refer-to-debian-infrastructure tag. (MR: !83)
-
The expected tags for the test fields-bugs-field-does-not-refer-to-debian-infrastructure changed as a result of a previous commit. This is the adjustment. Signed-off-by:Chris Lamb <lamby@debian.org> -
The tag fields-bugs-field-does-not-refer-to-debian-infrastructure includes a line number as a hint, but that number is incorrect. In the test fields-bugs-field-does-not-refer-to-debian-infrastructure, the offending field was located in line 9 of the generated control file and not in line 11, as the tag said. The line number appeared unrelated. It was removed. At the time of writing, the tag did not appear in the wild. The error could not be corroborated outside the Lintian test suite. Signed-off-by:Chris Lamb <lamby@debian.org>
-
- 03 Dec, 2018 3 commits
-
-
The whitelist for Debian packaging templates used in tests does not include debian/rules. In the test suite, these files occasionally hardcode the name of the test. This commit makes it possible to provide instead debian/rules.in that is filled with the correct value via a declaration like "pkg={$source}". Signed-off-by:Chris Lamb <lamby@debian.org> -
The build stamp ./runtests is no longer used. This commit removes the file name from .gitignore. Signed-off-by:Chris Lamb <lamby@debian.org> -
Using its Makefile semantics, debian/rules implements a build stamp when tests are run without the option 'onlyrun'. It prevents needless re-runs, but also blocks runs that should be allowed, for example when only the test runner has changed. (The target 'runtests' depends on many files, but not on the t/runtest executable or any of its imports.) The mechanism is a complete obstacle to runner development. This commit disables the mechanism. The build stamp is no longer written, and the 'runtest' target is declared PHONY. Signed-off-by:Chris Lamb <lamby@debian.org>
-
