1. 09 Dec, 2018 2 commits
    • Chris Lamb's avatar
      Rebuild for stretch-backports. · 0184fc19
      Chris Lamb authored
      0184fc19
    • Chris Lamb's avatar
      Merge tag '2.5.116' into stretch-backports · b3b184e1
      Chris Lamb authored
      
      
      Release lintian/2.5.116 into unstable.
      
      Format: 1.8
      Date: Fri, 07 Dec 2018 08:59:39 +0000
      Source: lintian
      Binary: lintian
      Architecture: source all
      Version: 2.5.116
      Distribution: unstable
      Urgency: medium
      Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
      Changed-By: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      Description:
       lintian    - Debian package checker
      Changes:
       lintian (2.5.116) unstable; urgency=medium
       .
         * checks/fields.pm:
           + [CL] Apply a patch from Felix Lechner to remove the incorrect line in
             the fields-bugs-field-does-not-refer-to-debian-infrastructure tag's
             output.  (MR: !83)
       .
         * data/fields/perl-provides:
           + [CL] Update for Perl 5.028001.
         * data/java/constants:
           + [CL] Apply a patch from Felix Lechner to fix the "maximum existing
       .
         * debian/rules:
           + [CL] Apply a patch from Felix Lechner to remove the "runtests" build
             stamp mechanism as it blocks runs that should be allowed such as
             when only the test runner itself has changed.  (MR: !80)
       .
         * t/*:
           + [CL] Apply a patch series from Felix Lechner to make "pedantic"
             templates the default for all tests.  (MR: !87)
           + [CL] Apply a patch from Felix Lechner to allow debian/rules to be
             generated from templates in tests.  (MR: !81)
           + [CL] Apply a patch from Felix Lechner to remove pre-existing metadata
             in the upstream-metadata-is-not-a-file test.  (MR: !84)
           + [CL] Apply a patch series from Felix Lechner to provide a generalised
             facility to make any test template set independent of the package
             format.  (MR: !82)
           + [CL] Apply a patch series from Felix Lechner to support
             suite-independent test templates.  (MR: !88)
      Checksums-Sha1:
       88ad672969d118a09ff6b8a8d5137c78f9ac3b85 2704 lintian_2.5.116.dsc
       95bc6636aeacf012ff3a195aadf7c0dbc4d738ed 1613032 lintian_2.5.116.tar.xz
       9e495ace9c09cdb1824cf26014e82b7319d86a62 1157076 lintian_2.5.116_all.deb
       4b84a29a4ccda6563b8cea2a452dc34893b798ae 16749 lintian_2.5.116_amd64.buildinfo
      Checksums-Sha256:
       9296101ef4acd8aff371526595c14906f21b4d03cfc0179953cd60703a12ebb1 2704 lintian_2.5.116.dsc
       2e1e901d927d338cbe4ffefe8be5329b328079c314f2dc9707e3060a50b4d372 1613032 lintian_2.5.116.tar.xz
       37178c1365081627763033432875b61b429b53923752dbfe9d2be697e17be4d6 1157076 lintian_2.5.116_all.deb
       a5ab12e286bfacd14ad52bf300a59da305073717980567d32995e4afe9aa434a 16749 lintian_2.5.116_amd64.buildinfo
      Files:
       a931249f12da5e70ed330fca7a6db08d 2704 devel optional lintian_2.5.116.dsc
       0e549437cf4c2dd6bd54ce974428b94a 1613032 devel optional lintian_2.5.116.tar.xz
       ea00227d4f3a32ab598ddbf5c5a87218 1157076 devel optional lintian_2.5.116_all.deb
       8289c7e7a8d7b6083338e37aa10db5dd 16749 devel optional lintian_2.5.116_amd64.buildinfo
      
      * tag '2.5.116': (41 commits)
        Release lintian/2.5.116 into unstable.
        Update data/fields/perl-provides for Perl 5.028001.
        Apply a patch series from Felix Lechner to support suite-independent test templates. (MR: !88)
        In the test runner, remove suite as a component of the template search path.
        Change names of template sets in test skeletons to incorporate the suite.
        Move template sets; remove suite from path and make part of name.
        Apply a patch series from Felix Lechner to make "pedantic" templates the default for all tests. (MR: !87)
        Delete two outdated changelogs that describe historical template sets.
        Delete "default" template set for Debian files (no longer needed).
        Delete "pedantic" template set for upstream files; no longer used.
        Delete the "pedantic" skeleton (no longer needed).
        Remove the line "Skeleton: pedantic" from all test descriptions.
        Provide non-empty diff/Changes files for four tests.
        Use the "pedantic" Debian files in the default skeleton.
        Add a missing newline character.
        Update copyright information for the "pedantic" template set.
        Add ${shlibs:Depends} to the "pedantic" control file template.
        Parameterise the distribution in the 'pedantic' changelog template.
        Remove file/directory conflicts before copying templates.
        Fix maximum existing version of Java class file format. (MR: !86)
        ...
      b3b184e1
  2. 07 Dec, 2018 4 commits
    • Chris Lamb's avatar
      Release lintian/2.5.116 into unstable. · 7fff018d
      Chris Lamb authored
      7fff018d
    • Chris Lamb's avatar
      87358003
    • Chris Lamb's avatar
      Rebuild for stretch-backports. · c2b9c4f8
      Chris Lamb authored
      c2b9c4f8
    • Chris Lamb's avatar
      Merge tag '2.5.115' into stretch-backports · a04787cf
      Chris Lamb authored
      
      
      Release lintian/2.5.115 into unstable.
      
      Format: 1.8
      Date: Mon, 03 Dec 2018 13:33:49 +0000
      Source: lintian
      Binary: lintian
      Architecture: source all
      Version: 2.5.115
      Distribution: unstable
      Urgency: medium
      Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
      Changed-By: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      Description:
       lintian    - Debian package checker
      Closes: 914873 914885 914952
      Changes:
       lintian (2.5.115) unstable; urgency=medium
       .
         * Summary of tag changes:
           + Removed:
             - debian-rules-makemaker-prefix-is-deprecated
       .
         * checks/binaries.pm:
           + [CL] Allow packages to define an RPATH under /usr/lib/ghc/ as the
             Haskell team have their own scheme for this.  (Closes: #914873)
         * checks/rules.{desc,pm}:
           + [CL] Drop the debian-rules-makemaker-prefix-is-deprecated tag as the
             transition was completed in 2015.  Thanks to Niko Tyni for the
             update.  (Closes: #914885)
         * checks/patch-systems.desc:
           + [CL] Downgrade package-uses-vendor-specific-patch-series from "E:" to
             "W:" as they are not RC bugs until the release of buster.
       .
         * data/spelling/corrections:
           + [PW] Add a number of corrections.
       .
         * t/*:
           + [CL] Apply a patch series from Felix Lechner to implement a universal
             test runner with file-based default values.  (MR: !76)
         * t/runtests:
           + [CL] Apply a patch from Felix Lechner to fail tests with outdated
             specifications (ie. ./debian/debian exists).  (MR: !77)
         * t/tests/{binaries-missing-lfs,deb-format-udeb-compression}:
           + [CL] Apply a patch from Adam Conrad to fix two typos introduced
             when parameterising test architectures.  (Closes: #914952)
         * t/tests/files-multiarch-foreign-files:
           + [CL] Apply a patch from James Clarke to fix this test on non-amd64
             architectures.  (MR: !78)
      Checksums-Sha1:
       502b1734d39feb202680958728eabef1f1547181 2704 lintian_2.5.115.dsc
       8b0994e12e7ed411f0128566ff8d1dab2679246c 1613240 lintian_2.5.115.tar.xz
       5f966cc6c6134429cdd0a2ef8fc995f0333bbd34 1156240 lintian_2.5.115_all.deb
       87977bfe0450aeb311ac9923ddf469c20ccdb6de 16744 lintian_2.5.115_amd64.buildinfo
      Checksums-Sha256:
       1c691e1d22b1a83d52be229b938745142e4787a0c77c85c4397682048e2e3294 2704 lintian_2.5.115.dsc
       49eefcf9ed64d162e9fba6e2cd2f9eb12307227c422ba951f1d271d701adcad7 1613240 lintian_2.5.115.tar.xz
       f8d98cc40d3511a508314d1f1d46a0b476ef8edbd606e76da755c640d32fe3b8 1156240 lintian_2.5.115_all.deb
       b9a1beca2110dfebf48d0eefdb1679cc84f89b7eca385eb0dd1d136a06154054 16744 lintian_2.5.115_amd64.buildinfo
      Files:
       30a5640f0ec04e40c6626fddae22876a 2704 devel optional lintian_2.5.115.dsc
       1d1a8ea84c4e4ca9c3fa396c07b1ea9b 1613240 devel optional lintian_2.5.115.tar.xz
       576d22df407d5390f90d36432fe8ea6f 1156240 devel optional lintian_2.5.115_all.deb
       a3db39ba74c5827b9aa85753740c63da 16744 devel optional lintian_2.5.115_amd64.buildinfo
      
      * tag '2.5.115': (22 commits)
        Release lintian/2.5.115 into unstable.
        debian/changelog: Drop duplicate "on".
        Downgrade package-uses-vendor-specific-patch-series from "E:" to "W:" as they are not RC bugs until the release of buster.
        Apply a patch series from Felix Lechner to implement a universal test runner with file-based default values. (MR: !76)
        Read default values for test specifications from t/defaults/desc instead of hardcoding them.
        Add file with default values for 'desc' test descriptions; to be read when configuring and running tests.
        Unify the test runners for all suites; use a universal runner instead.
        Use parameterized builder definitions according to suite when running tests.
        Use the make-based builder for suite tests, which was previously coded in Perl.
        Add the make-based builder templates to the skeleton definitions, when appropriate.
        Add fill whitelist 'make-builder' for make-based build systems in tests.
        Add builder templates for test cases; used for automatic rebuilding.
        Allow packages to define an RPATH under /usr/lib/ghc/ as the Haskell team have their own scheme for this. (Closes: #914873)
        Drop the debian-rules-makemaker-prefix-is-deprecated tag as the transition was completed in 2015. (Closes: #914885)
        Re-add accidentally-removed changelog entry for package-contains-file-in-usr-share-hal.
        Fix two typos introduced when parameterising test architectures in 9e128d0f & fd01abbf. (MR: !79) (Closes: #914952)
        t/tests/files-multiarch-foreign-files: Fix on non-amd64 architectures. (MR: !78)
        Apply a patch from Felix Lechner to fail tests with outdated specifications (ie. ./debian/debian exists). (MR: !77)
        Fail tests with outdated specifications (ie. ./debian/debian exists).
        Rebuild work directories for tests when old artifacts related to ./debian/debian are found.
        ...
      a04787cf
  3. 05 Dec, 2018 17 commits
  4. 04 Dec, 2018 17 commits
    • Felix Lechner's avatar
      Fix maximum existing version of Java class file format. (MR: !86) · a18093bf
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      The fix to #912292 (in commit f48c9236) makes several updates to the
      known Java class file versions but appears to require, in addition, an
      upward adjustment of 'max-bytecode-existing-version'. Otherwise, the
      test 'java-class-format' produces the following regression:
      
      @@ -1,2 +1,2 @@
      -W: libtest-java: incompatible-java-bytecode-format Java12 version (Class format: 56)
       W: libtest-java: unknown-java-class-version usr/share/java/testa-1.0.jar (org/debian/lintian/TestA.class -> 42)
      +W: libtest-java: unknown-java-class-version usr/share/java/testb-1.0.jar (org/debian/lintian/TestB.class -> 56)
      fail tests::java-class-format: output differs!
      
      An inspection of 'TestB.class' shows that the major version is being
      read correctly. It is just not interpreted right. This commit causes
      the test to pass without errors.
      
        Last modified Dec 4, 2018; size 278 bytes
        MD5 checksum d41318995b87081fd003c4da42f3562d
        Compiled from "TestB.java"
      public class org...
      a18093bf
    • Chris Lamb's avatar
      Replace FIXME with MR reference. · 51832812
      Chris Lamb authored
      51832812
    • Felix Lechner's avatar
      Use safe_qx() instead of qx{} in test runner. (MR: !85) · cc6e3e24
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      In this instance, it may not be any safer but it is probably good
      practice.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      cc6e3e24
    • Chris Lamb's avatar
      Apply a patch series from Felix Lechner to provide a generalised facility to... · 143e08ea
      Chris Lamb authored
      Apply a patch series from Felix Lechner to provide a generalised facility to make any test template set independent of the package format. (MR: !82)
      143e08ea
    • Felix Lechner's avatar
      Simplify test cruft-empty-diff; use only templates; no copies in ./orig. · c92295b0
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      The test 'cruft-empty-diff' replicated all standard templates in
      ./orig. Here we instead use the script ./pre_upstream to copy all
      filled Debian files into the package directory before the orig.tar.gz
      is created. It also renders the diff empty, but is probably more fool-
      and future-proof.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      c92295b0
    • Felix Lechner's avatar
      Fix test generic-dh-make-2005 to work without external templates. · ac89c5fc
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      test to remain undisturbed "as a test of Lintian's handling of old ...
      template packages". This commit stops the use of standard templates,
      which in the past provided missing files.
      
      During the build process, dh_clean is called. It errors out when no
      compat file is present. To get the test to run, a compat file is now
      generated through the pre_build script. This is done dynamically so
      that the set of static files is not modified, as requested by the
      original author.
      
      Some tags appeared when the use of default templates was discontinued.
      Those tags were added.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      ac89c5fc
    • Felix Lechner's avatar
      Fix test generic-dh-make-2008 to work without external templates. · bf735013
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      Judging from the file orig/README the original author intended this
      test to remain undisturbed "as a test of Lintian's handling of old ...
      template packages". This commit stops the use of standard templates,
      which in the past provided missing files.
      
      During the build process, dh_clean is called. It errors out when no
      compat file is present. To get the test to run, a compat file is now
      generated through the pre_build script. This is done dynamically so
      that the set of static files is not modified, as requested by the
      original author.
      
      Some tags appeared when the use of default templates was discontinued.
      Those tags were added.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      bf735013
    • Felix Lechner's avatar
      Add a builder-only skeleton; does not supply any Debian templates. · aad4a2db
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      This skeleton only installs (and fills) build files, but it does not
      supply any Debian templates (although it will fill them).  Tests like
      generic-dh-make-* were meant to be snapshots in time. In the past,
      they were seeded with standard template sets like other tests. That
      may conflict with the intentions of their original authors. This
      commit creates a more suitable skeleton for their use.
      
      This skeleton also allows the script pre_build to be generated from a
      template. That functionality is needed to supply debian/compat to both
      tests mentioned above without modifying any of their static Debian
      files.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      aad4a2db
    • Felix Lechner's avatar
      Execute post-template adjustment script in t/runtests. · eaa9032e
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      This commit will execute a post-template script, if present. It is
      part of a new mechanism to ensure that native packages are not
      supplied with watch files.
      
      With this commit, we can restore the two tests generic-dh-make-2005
      and generic-dh-make-2008 to their original functionality: when they
      were conceived, dh-make did not create watch files. Until now, neither
      test showed the associated warnings because a template set supplied
      the missing file. Very soon the two tests will no longer draw on
      external Debian template sets. Instead they will trigger all the
      warnings their original authors intended.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      eaa9032e
    • Felix Lechner's avatar
      Remove dynamic generation of watch file from builder Makefile. · b499aaf9
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      For a long time, the Lintian test suite automatically created watch
      files for non-native packages. That worked well, except in some corner
      cases. Some tests compensated by removing the file in the pre_build
      script.
      
      This commit is part of a series that changes that mechanism. The watch
      file is now supplied by a template set and removed right after the
      templates are copied into a test's work directory.  The processing
      takes place earlier. It allows tests deal with watch files like they
      do with any other file that is (or is not) supplied by template sets.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      b499aaf9
    • Felix Lechner's avatar
      Add empty watch files to the template sets for tests. · 5717411e
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      Watch files were previously created in builder Makefiles. For some
      tests, that was too late in the process. Now they are supplied as part
      of template sets. For native packages, the watch files supplied herein
      will be removed by post-template scripts. That script is supplied
      elsewhere.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      5717411e
    • Felix Lechner's avatar
      Add a default post-template command; it is post_template. · d60498b1
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      Some templates require adjustment after they were copied to a test's
      work directory. For native packages, a post-template script will
      remove any watch files that may have been shipped as part of a
      template. This commit only sets the name of the script. The script is
      provided by a template set.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      d60498b1
    • Felix Lechner's avatar
      Add post-template script to the template set 'make-builder' for tests. · c9d4838c
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      This script causes any watch file (or its template) that was shipped
      as part of other template sets to be deleted, if a package is native.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      c9d4838c
    • Felix Lechner's avatar
      Transfer file permissions from templates to generated files. · c7d30038
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      The templating system does not preserve file permissions, but scripts
      must be executable to run. This commit applies the file permissions of
      the template to any generated file. Going forward, scripts generated
      from templates can also run.
      
      This change is important for a new mechanism to generate debian/watch
      and is also used to supply compat files to the tests
      generic-dh-make-*, which were created without it. Modern Debian tools
      require compat. The script was a way to add it without modifying the
      debian files originally created by dh-make.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      c7d30038
    • Felix Lechner's avatar
      Remove pre-existing metadata in the upstream-metadata-is-not-a-file test. (MR: !84) · 4a2880af
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      The test does not remove debian/upstream/metadata before generating it
      as a FIFO. That causes an error if the file exists, for example when
      it is supplied by a template like 'pedantic'. Here the file is removed
      before the FIFO is created.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      4a2880af
    • Chris Lamb's avatar
      Apply a patch from Felix Lechner to remove an incorrect line number in the... · 2b4ac946
      Chris Lamb authored
      Apply a patch from Felix Lechner to remove an incorrect line number in the output of the fields-bugs-field-does-not-refer-to-debian-infrastructure tag. (MR: !83)
      2b4ac946
    • Felix Lechner's avatar
      Adjust test tags to new emitted format. · 420323d8
      Felix Lechner authored and Chris Lamb's avatar Chris Lamb committed
      
      
      The expected tags for the test
      fields-bugs-field-does-not-refer-to-debian-infrastructure changed as a
      result of a previous commit. This is the adjustment.
      
      Signed-off-by: Chris Lamb's avatarChris Lamb <lamby@debian.org>
      420323d8