Release lintian/2.5.117 into unstable.

Format: 1.8
Date: Fri, 14 Dec 2018 17:56:27 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.117
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 916021 916023 916087 916207
Changes:
 lintian (2.5.117) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - file-references-package-build-path
 .
   * checks/files.pm:
     + [CL] Don't emit uses-dpkg-database-directly for d-i components; they
       likely know what they are doing with no alternatives.
     + [CL] Use the output from file(1) when determining whether to emit
       the package-contains-no-arch-dependent-files tag to catch packages
       that ship (for example) just a Python script under /usr/bin in an
       architecture-dependent package.  This reverts 6f4bd2fe in order to
       distinguish between "data" and such scripts.  Thanks to Dmitry
       Bogatov for investigating.  (Closes: #916023)
     + [CL] Refactor, tidy and optimise various checks for the contents of
       files.
     + [CL] Check files for references to the build path if specified in a
       .buildinfo.  (Closes: #916021
   * checks/shared-libs.desc:
     + [CL] Clarify that symbols-file-missing-build-depends-package-field is
       emitted per-package in its long description, not based on a file.
   * checks/systemd.pm:
     + [CL] Don't emit systemd-service-file-missing-hardening-features for
       Type=oneshot "services" such as mdadm(8).
   * checks/watch-file.desc:
     + [CL] Correct grammar of the debian-watch-does-not-check-gpg-signature
       tag description.
     + [CL] Mark debian-watch-does-not-check-gpg-signature as "experimental"
       as it is not actionable in the vast majority of cases and is in
       danger of diluting the output of Lintian.  (Closes: #916207)
 .
   * data/spelling/corrections:
     + [PW] Add a number of corrections.
 .
   * t/*:
     + [CL] Apply a patch series from Felix Lechner to use "skeletons" as
       test templates, fixing a "exec failed: Text file busy" regression
       when running tests by tag name.  (Closes: #916087)
     + [CL] Apply a patch series from Felix Lechner to improve the
       "onlyrun=" test selection feature.  One can now select all tests
       connected to particular Lintian check with "check:foo".  (MR: !90)
     + [CL] Apply a patch set from Felix Lechner to sign test packages.
       when a upstream/private-key.asc is present.  (MR: !93)
Checksums-Sha1:
 df680b9458d843f0ef3ce71fa73147e9420f62cf 2742 lintian_2.5.117.dsc
 25d25b87771aae7d6f944e75f3cc75e4271f2202 1622804 lintian_2.5.117.tar.xz
 407107338c832d83f875f62881b065d317d8d7b8 1170904 lintian_2.5.117_all.deb
 3af2219ca123086f5ff91759f206222fa56b4ea1 16717 lintian_2.5.117_amd64.buildinfo
Checksums-Sha256:
 d111ea450623c2746229280338c2c2c243b5a87b748f3d5296daa81b673dece5 2742 lintian_2.5.117.dsc
 9dd665703c6af57557447dcf5a9e8aa5acd159eeb7cd6f3de49b0d72d7a884b7 1622804 lintian_2.5.117.tar.xz
 51057fecea6ab6896d7b25ceb37eca596d3ad32ea0ed84aef7d707a348ae9096 1170904 lintian_2.5.117_all.deb
 4491a67d0e60011823411752037e195aeb1698cd54f74b772af091f042d06417 16717 lintian_2.5.117_amd64.buildinfo
Files:
 035e65c0abd1cfd3896999f156b03ab8 2742 devel optional lintian_2.5.117.dsc
 6ba7b8521f344c3c45c7a098adbbfd77 1622804 devel optional lintian_2.5.117.tar.xz
 ec10d9e6b8c66d5a0cfed78e1a68b3ad 1170904 devel optional lintian_2.5.117_all.deb
 487ffc9064ea19aed1e9a9bb85e83efe 16717 devel optional lintian_2.5.117_amd64.buildinfo

* tag '2.5.117': (56 commits)
  Release lintian/2.5.117 into unstable.
  Add basic POD for Test::State. (Closes: #916444)
  Remove unnecessary Debian diffs from two tests.
  Export 'ARCHITECTURE' as 'ENV{DEB_HOST_ARCH}' in test runner.
  Export 'RUNNER_TS' as 'ENV{HARNESS_EPOCH}' in test runner.
  Export 'STANDARDS_VERSION' as 'ENV{POLICY_VERSION}' in test runner.
  Replace a number of variables in the test runner.
  Move runner functionality to Test::Lintian::Run.
  Move prepare functionality to Test::Lintian::Prepare.
  Split test runner into two phases; prepare and run.
  Move Test::State into a separate module.
  debian/changelog: Fix order.
  Clarify that symbols-file-missing-build-depends-package-field is emitted per-package in its long description, not based on a file.
  Add missing argument $build_path to function.
  Adjust expected tags for debian-watch-does-not-check-gpg-signature.
  Don't emit systemd-service-file-missing-hardening-features for Type=oneshot "services" such as mdadm(8).
  Check files for references to the build path if specified in a .buildinfo. (Closes: #916021
  Refactor, tidy and optimise various checks for the contents of files.
  Fix a test definition/output from previous commit.
  Mark debian-watch-does-not-check-gpg-signature as "experimental". (Closes: #916207)
  ...

Felix Lechner authored Dec 14, 2018 and Chris Lamb committed Dec 14, 2018

This is not enforced by code quality scripts but needed for release.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 13, 2018 and Chris Lamb committed Dec 14, 2018

The test set contains two tests that are designed to test the
performance of file sets produced by historical versions of dh-make.
Both tests use a special feature designed to excercise debian diff
performance, or the related patch that is automatically generated for
package format 3.0 (quilt). In both cases, however, the files in
./diff and ./orig are identical. There is no diff. Furthermore,
dh-make never dealt with such diff sets. The files were probably
duplicated by accident at some point. All such files in ./diff were
removed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 13, 2018 and Chris Lamb committed Dec 13, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 13, 2018 and Chris Lamb committed Dec 13, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 13, 2018 and Chris Lamb committed Dec 13, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 12, 2018 and Chris Lamb committed Dec 13, 2018

  'testdata' -> 'testcase'
  'test_data' -> 'testcase'
  'testdir' -> 'specpath'
  'targetdir' -> 'runpath'
  'TESTSET' -> 'testset'
  'RUNDIR' -> 'outpath'
  'test_filter' -> 'onlyrun'
  'ALWAYS_REBUILD' -> 'force_rebuild'
  'JOBS' -> 'numjobs'
  'DUMP_LOGS' -> 'dump_logs'
  'VERBOSE' -> 'verbose'

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 07, 2018 and Chris Lamb committed Dec 13, 2018

This commit moves the actual test phase (i.e. the package building and
the all-important call to Lintian) into a separate module.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 06, 2018 and Chris Lamb committed Dec 13, 2018

This commit makes the runner more modular by splitting the preparation
phase into its own module.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 12, 2018 and Chris Lamb committed Dec 13, 2018

This commit splits the test runner into two phases. The preparation
phase copies all necessary files to the work directory in
debian/test-out and fills the templates. The run phase builds packages
and runs the test.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 05, 2018 and Chris Lamb committed Dec 13, 2018

This module was previously attached to the bottom of t/runtests. It is
now separate.

Signed-off-by: Chris Lamb <lamby@debian.org>

Clarify that symbols-file-missing-build-depends-package-field is emitted per-package in its long description, not based on a file.

Felix Lechner authored Dec 13, 2018 and Chris Lamb committed Dec 13, 2018

The variable $build_path introduced in commit 4aaab6b1

 is being passed
as an argument but not being processed as such.  This commit adds the
variable as an argument in the function declaration.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 13, 2018 and Chris Lamb committed Dec 13, 2018

This commit adjusts the expected tags for tests after tag
'debian-watch-does-not-check-gpg-signature' was marked experimental
(in commit 69d31855).

Don't emit systemd-service-file-missing-hardening-features for Type=oneshot "services" such as mdadm(8).

Felix Lechner authored Dec 12, 2018 and Chris Lamb committed Dec 13, 2018

The test results were produced independent messages, and this one was
missed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Apply a patch set from Felix Lechner to sign test packages. when a upstream/private-key.asc is present. (MR: !93)

Felix Lechner authored Dec 07, 2018 and Chris Lamb committed Dec 12, 2018

This is a test to verify orig tarball signing. It is thus also a test
for false positives of 'orig-tarball-missing-upstream-signature'

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

This commit causes upstream packages of the form orig.tar.gz to be
signed if a private key is found at upstream/private-key.asc. For now,
this works only in suite 'tests'.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

Both are available in stretch-backports. /usr/bin/gpg-agent was also
available in the original stretch. Both package names have changed
since then but the present names were already available in stretch via
virtual packages. This commit uses the current package name from
unstable.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

The detection of arch-dependent files in checks/files.pm now excludes
executable ASCII files. For these tests, changing the Architecture to
'all' resulted in the tag 'not-binnmuable-all-depends-any'. A trade
off was made to add the tag instead.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

The detection of arch-dependent files in checks/files.pm now excludes
executable ASCII files. For this test package holding an app, it
seemed appropriate to change the Architecture to 'all'.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

In accordance with the author's wishes as received in orig/README,
this tag is added without modifications to other files.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

Sometimes file_info is unsafe to call. The recommended call to
is_open_ok did not solve the issue, so checking directly.

Signed-off-by: Chris Lamb <lamby@debian.org>

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Oct 05, 2018 and Chris Lamb committed Dec 12, 2018

This commit adjusts the autopkgtest command to the new way commas in
'onlyrun' now separate fully styled selectors.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 10, 2018 and Chris Lamb committed Dec 12, 2018

This commit uses the new test selection mechanism in favor over the
present one.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 10, 2018 and Chris Lamb committed Dec 12, 2018

This module provides an alternative way to select tests to run. The
syntax is very similar except for one detail: Commas now separate
fully styled selectors such as "tag:some-tag,suite:changes" (which are
combined via a logical OR). It is no longer advisable to use something
like "suite:tests,changes".

As a new feature, one can now select all tests connected to particular
Lintian check with 'check:'. It is designed to more or less make the
tag selector 'tag:' obsolete in everyday use, although it will remain
available.

Otherwise, tests are selected very much the way they were before,
except one may find it useful to specify the desired category in
onlyrun=.  (Reasonable attempts are made to guess what was meant.)
Please choose from:

* test: runs the named test (or tests) in any of the suites
* suite: runs all tests in the named suite
* tag: runs all tests regarding the named tag
* check: runs all tests regarding the named Lintian check

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 10, 2018 and Chris Lamb committed Dec 12, 2018

This commit provides a direct way for a test to infer its suite from
its own path. A test no longer has to rely on a variable that was
passed down from the test selection mechanism.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 10, 2018 and Chris Lamb committed Dec 12, 2018

An absolute reference to the testset is needed to safely calculate the
suite from a test's specification path.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 10, 2018 and Chris Lamb committed Dec 12, 2018

This enviroment variable is needed in Test::Lintian::Filter.pm and is
also useful when running tests via TAP::Harness.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 11, 2018 and Chris Lamb committed Dec 12, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>