Release lintian/2.5.118 into unstable.

Format: 1.8
Date: Sun, 23 Dec 2018 16:42:08 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.118
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 833608 916095 916497 916877 916901 917028 917120
Changes:
 lintian (2.5.118) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - changelog-file-missing-explicit-entry
       - debian-tests-control-and-control-autodep8
       - debian-tests-control-autodep8-is-obsolete
 .
   * checks/*.desc:
     + [CL] Consistently use a single space after a full-stop/period.
   * checks/changelog-file.{desc,pm}:
     + [CL] Check that 1.2-3~debXuY stanzas follow a 1.2-3 one. Thanks to
       Andreas Beckmann for the suggestion.  (Closes: #916877)
   * checks/cruft.pm:
     + [CL] Allow some alternatives in the "invariant sections" regular
       expressions as some upstream's have modified the official wording.
       Thanks to Dmitry Bogatov for the patch.  (Closes: #916095)
   * checks/files.pm:
     + [CL] The package-contains-documentation-outside-usr-share-doc tag
       should accept files under "/usr/share/help"; these are being
       installed by a number of GNOME packages.  Thanks to Jeremy Bicha for
       the report.  (Closes: #916497)
     + [CL] Avoid a number of false-positives in documentation files when
       processing the uses-dpkg-database-directly tag as these are
       invariably legitimate.
     + [CL] Prevent package-contains-no-arch-dependent-files false-positives
       regarding files under /usr/lib/<gnu-triplet>.  Thanks to Andreas
       Beckmann.  (Closes: #916901, #917028)
   * checks/systemd.pm:
     + [CL] Don't emit systemd-service-file-missing-hardening-features for
       WantedBy=sleep.target "services" such as autosuspend.
   * checks/testsuite.{desc,pm}:
     + [CL] Apply a patch series from Paul Gevers to warn about obsolete
       debian/tests/control.autodep8 files.  (MR: !95)
   * checks/version-substvars.pm:
     + [CL] Apply a patch from Matt Kraai (via MR !101) to make the
       version-substvar-for-external-package tag require versioned provides.
       (Closes: #833608)
 .
   * CONTRIBUTING.md:
     + [CL] Update a number of references to Salsa, recommending merge
       requests, etc.
 .
   * data/output/manual-references:
     + [CL] Refresh.
   * data/spelling/corrections:
     + [PW] Add a number of corrections.
   * data/standards-version/release-dates:
     + [CL] Add 4.3.0 as a known Standards-Version.
   * data/systemd/wantedby-whitelist:
     + [CL] Add default, network-online and sleep' to the list of valid
       WantedBy systemd targets.
     + [PW] Add a number of corrections.
 .
   * debian/{docs,lintian.install}:
     + [CL] Order lines.
       to Salvo Tomaselli for the report.  (Closes: #917120)
 .
   * doc/lintianrc.example:
     + [CL] Clarify that spaces are valid in variable assignments.  Thanks
 .
   * private/refresh-manual-refs:
     + [CL] Update location of the Python policy; it is now shipped in the
       "python3" binary package.
 .
   * t/*:
     + [CL] Apply a patch series from Felix Lechner to capture log output in
       tests using Capture::Tiny as it works better in a multi-threaded
       environment.  (MR: !102)
     + [CL] Apply a patch from Felix Lechner to remove the "diff" directory
       and contents for two tests.  (MR: !103)
Checksums-Sha1:
 edcf2fbca9f43dc780297c9ef988bba472e67ee4 2805 lintian_2.5.118.dsc
 95d2259cfff51bdde32b107574378b62d5f43a8f 1624760 lintian_2.5.118.tar.xz
 811d482eaf51cc5aa26e22d0110d4e9273247d40 1172112 lintian_2.5.118_all.deb
 bdc09a55fe1ceab909d6de5a75a6ebff51701ce4 17340 lintian_2.5.118_amd64.buildinfo
Checksums-Sha256:
 e3ffb952971a5b5235efe1690fb7f34b25d9c0ed63cab30c4eb48d582810ade7 2805 lintian_2.5.118.dsc
 cd15e46385d00d413324a64dfd388475b0f12223a0fbe6e166deb3a3bb02a7b0 1624760 lintian_2.5.118.tar.xz
 67388a55f51b94fe96ad5f12e9f1241facefc3a8f80ef222dee261dd9e9a8659 1172112 lintian_2.5.118_all.deb
 175f1f8be0fcb9a79642b6781ed7c1028a9b81c201e36199166a957525655b3c 17340 lintian_2.5.118_amd64.buildinfo
Files:
 71085f73aa93209670967d42cd27dd6d 2805 devel optional lintian_2.5.118.dsc
 a24954a5ea0a07664d74b843f7345328 1624760 devel optional lintian_2.5.118.tar.xz
 e56f519719b073f0c79612d392e8d21c 1172112 devel optional lintian_2.5.118_all.deb
 19b89b1d2169ea99539803104fd6f2d5 17340 devel optional lintian_2.5.118_amd64.buildinfo

* tag '2.5.118': (85 commits)
  Release lintian/2.5.118 into unstable.
  Refresh data/output/manual-references.
  Update location of the Python policy; it is now shipped in the "python3" binary package.
  Fixup the description of the non-standard-apache2-module-package-name tag.
  Fix path to expected tags when those tags were calibrated.
  Remove import Test::Lintian::Harness.
  Remove all references to runsystem_ok.
  Add 4.3.0 as a known Standards-Version.
  Correct ordering of debian/changelog sub-entries.
  Clarify that spaces are valid in variable assignments. (Closes: #917120)
  spelling: Add several corrections
  Sort the dictionary
  debian/changelog: Correct "environment" typo.
  Correct logic of package-contains-no-arch-dependent-files detection (found via Perl::Critic).
  Allow some alternatives in the "invariant sections" regular expressions as some upstream's have modified the official wording. (Closes: #916095)
  Run diff against tags in specification instead of copy in debian-out. (MR: !105)
  Record path to test specification in test working directory.
  Check that 1.2-3~debXuY stanzas follow a 1.2-3 one. (Closes: #916877)
  Print diff output for failed tests. (MR: !105)
  Check for GNU triplet when testing for package-contains-no-arch-dependent-files. (re. #916901)
  ...

Felix Lechner authored Dec 22, 2018 and Chris Lamb committed Dec 23, 2018

Two tests use a "calibration" script that adjusts the expected tags.
In that particular circumstance, commit b81de6ce

 causes the displayed
diff to be incorrect (although the test result itself is reliable).
Here we fix the path if the test was calibrated. Now the diff is
correct again.

Possible long-term solutions are: (1) reversal of the "calibration"
logic in that it modifies the actual tags rather than the expected
tags; (2) a more powerful tag parts that compares only invariant
parts.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 22, 2018 and Chris Lamb committed Dec 23, 2018

The actual module was already removed earlier.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 22, 2018 and Chris Lamb committed Dec 23, 2018

The moduled Test::Lintian::Harness that provides this function was
removed earlier.

Signed-off-by: Chris Lamb <lamby@debian.org>

Changes-by: make -C data/spelling sort

Allow some alternatives in the "invariant sections" regular expressions as some upstream's have modified the official wording. (Closes: #916095)

Felix Lechner authored Dec 21, 2018 and Chris Lamb committed Dec 22, 2018

The test result is checked against the copy of tags in $runpath, but
the diff command is now run on the tags in $specpath. It provides
users who rely on it a reference to the original tags.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 21, 2018 and Chris Lamb committed Dec 22, 2018

This data structure is written to $runpath/desc and thus survives
between preparation stage and runner.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 21, 2018 and Chris Lamb committed Dec 21, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Apply a patch series from Felix Lechner to capture log output in tests using Capture::Tiny as it works better in a multi-threaded environent. (MR: !102)

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This commit removes a file that is no longer being used.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This commit removes unused imports in the test runner.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

The function runsystem_ok was a custom way to call executables that
was no longer used. This commit replaces the last such use before that
module is removed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

A test runner should probably minimize its own untested use of
facilities from the subject under test. In this instance, the function
internal_error was provided by Lintian proper, but its use was not
necessary. It was replaced.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This exit codes may not have worked properly before, and are not
working now. The description is removed.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This commit updates the README with better information on the new test
selection mechanism.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This commit updates the help text to conform to the expanded test
selection mechanism.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This commit integrates the function parse_args, which used many global
variables, into main program.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

The usage function will simply print the usage information. It will no
longer cause the program to exit with any particular value.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This commit positionally moves the following assigments or
declarations:

$ENV{HARNESS_EPOCH}
$output_is_tty
$IO_LOOP

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 18, 2018 and Chris Lamb committed Dec 21, 2018

This option is likely to be most effective at the beginning of any
program.

Signed-off-by: Chris Lamb <lamby@debian.org>