Ondřej Nový authored Jan 07, 2019 and Chris Lamb committed Jan 07, 2019

Fix false-positives in the unnecessary-testsuite-autopkgtest-field tag with non-"autopkgtest" values in the Testsuite control field. (Closes: #918621)

Signed-off-by: Chris Lamb <lamby@debian.org>

If libperl-critic-pulp-perl is installed, several tests under
t/scripts/01-critic/ fail due to its additional perlcritic rules:

t/scripts/01-critic/checks.t:    Failed 1/58 subtests
t/scripts/01-critic/commands.t:  Failed  8/8 subtests
t/scripts/01-critic/lib.t:       Failed 3/52 subtests

Replace misleading "profile" with "option" in long description of the
tag override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.

See https://lists.debian.org/debian-devel/2019/01/msg00039.html ff.,
especially https://lists.debian.org/debian-devel/2019/01/msg00047.html
for context as well as https://bugs.debian.org/889746 for the original
intent.

Guile object files do not objdump/strip correctly so exclude them from a number of tests. (Closes: #918444)

Add "brightness" to the list of initscripts that do not need a corresponding service file. (Closes: #918459)

Robin Jarry authored Jan 03, 2019 and Chris Lamb committed Jan 05, 2019

Do not emit the following errors when a systemd service template (a
NAME@.service file) matches a similar init script (a /etc/init.d/NAME):

 missing-systemd-service-for-init.d-script
 omitted-systemd-service-for-init.d-script

Assume that the systemd service template goes with the init script.

Signed-off-by: Chris Lamb <lamby@debian.org>

Add optional support for stripping comments at EOL in read_dpkg_control via DCTRL_COMMENTS_AT_EOL. (Closes: #917964)

Apply a patch series from Felix Lechner to ensure the tests pass under groff 1.22.4-1. (Closes: #917752, #917844)

Felix Lechner authored Dec 31, 2018 and Chris Lamb committed Jan 01, 2019

New versions of groff-base have changed their output format. One test
required adjustment, but will not pass with older versions. Imposes a
minimum version of groff-base for this test as a prerequisite.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Jan 01, 2019

The man page that triggers the tag is included by another man page.
Such errors were apparently not detected before groff-base 1.22.4-1.
Adding tag here.

The tag format is a bit longer. It includes a partial path to the
included file. This test should be split up into several smaller
tests.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Jan 01, 2019

groff-base 1.22.4-1 prepends the name of the input file to any error
output. In Lintian, the messages look like '<standard input>:' for
regular man pages, and 'man/man3/XXX.3.gz:' if the error occurs in a
file included from elsewhere. For standard input, skip the information
to match the old tag output. For files included from elsewhere, the
extra information may be useful; it is retained.

If a file included from elsewhere causes an error but is also tested
on its own, the new behavior results in two similar tags being issued
that point out the same error (it would not be a duplicate).  Perhaps
the tag should not be skipped for included files.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Jan 01, 2019

In its error output, groff-base 1.22.4-1 seems to delimit the left
side of macro names with a single quote instead of an apostrophe,
which was used until now.  Adjust the expected tags in the test
'manpage-general' and a line in check/manpages.pm that skips some such
lines.

It may be worthwhile to send a note to all maintainers of packages
that override such a tag. The change is hard to see and can be
frustrating to find.

Felix Lechner authored Dec 31, 2018 and Chris Lamb committed Dec 31, 2018

When running Lintian under sbuild or pbuilder, the call to gpg errors
out with:

gpg: Fatal: can't create directory '/sbuild-nonexistent/.gnupg': No such file or directory

Provides a writable temporary home directory to gpg to avoid the error.

Signed-off-by: Chris Lamb <lamby@debian.org>

Apply a patch series from Felix Lechner to update the Debhelper compatibility level in tests. (MR: !111)

Felix Lechner authored Dec 29, 2018 and Chris Lamb committed Dec 30, 2018

Someone with more gcc experience may be able to correct the debug
format for the two tests. For now, dwz was non-essential. It was
disabled.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 28, 2018 and Chris Lamb committed Dec 30, 2018

Parameterizes the custom debian/control.in and updates a tag.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 28, 2018 and Chris Lamb committed Dec 30, 2018

The functionality of debian/conffiles was disabled in debhelper 12.
Moves the file into DEBIAN manually before building the deb.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

A python-related test now requires the explicit declaration of a
build system.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Increases the compat level in the test for debhelper's experimental
version to 13, which is a level above the one currently recommended.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

The option dh_clean -k was completely removed in compat 12.  The test
warning about its obsolescence requires compat 11 or lower. The
alternative would be to remove the test.

For another test, the command passing with '--' to dh_installdebs
fails. This likewise seems to be a new debhelper restriction. It also
requires compat 11.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Some tags issue compat levels as part of their message. Those tags
are fixed here.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Some tests do not use templates and also require this change to avoid
the tag 'skip-systemd-native-flag-missing-pre-depends'.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Many tests throw 'skip-systemd-native-flag-missing-pre-depends'
without this.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

With some luck, this component will not have to be updated again when
the debhelper compat level changes.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

An enviroment variable allows the use of the value in separate test
runners and spawned executables.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Works better than the two other routines nearby, which determine
either the debhelper version required in Lintian's own debian/control
or the debhelper version installed on the system.

Signed-off-by: Chris Lamb <lamby@debian.org>

Was a premature attempt at releasing but I left this commit locally which I
then accidentally pushed in e0871779.

This reverts commit b9f9ad46.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Dec 30, 2018

Together with Dh-Compat-Level: 12 in 'desc', the default builder
supplies the correct dependency via:

Default-Build-Depends: debhelper (>= {$dh_compat_level}~)

The tag complaining about lack of a version is no longer issued.
Removing it from the list of expected tags.

Signed-off-by: Chris Lamb <lamby@debian.org>

Include the debhelper-compat method of setting the compatibility level in a number of tag descriptions. (Closes: #917345)

Bastien ROUCARIÈS authored Dec 28, 2018 and Chris Lamb committed Dec 28, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>

Bastien ROUCARIÈS authored Dec 28, 2018 and Chris Lamb committed Dec 28, 2018

Signed-off-by: Chris Lamb <lamby@debian.org>