Release lintian/2.5.120 into unstable.

Format: 1.8
Date: Mon, 07 Jan 2019 22:19:07 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.120
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 917964 917967 918444 918459 918621
Changes:
 lintian (2.5.120) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Removed:
       - versioned-dependency-satisfied-by-perl
 .
   * checks/binaries.pm:
     + [CL] Guile object files do not objdump/strip correctly so exclude
       them from a number of tests.  (Closes: #918444)
   * checks/fields.{desc,pm}:
     + [CL] Drop versioned-dependency-satisfied-by-perl; Perl now provides
       its dual-lived module packages with versions.  (Closes: #917967)
   * checks/{menus,patch-systems}.desc:
     + [CL] Clarify that spelling-* tags also correct various grammatical
       errors too.
   * checks/rules.desc:
     + [AB] override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS: Replace
       misleading "profile" with "option" in long description. See #889746
       and https://lists.debian.org/debian-devel/2019/01/msg00047.html
   * checks/systemd.pm:
     + [CL] Apply a patch from Robin Jarry to handle service
       templates for missing init scripts.  (MR: !115)
   * checks/testsuite.pm:
     + [CL] Apply a patch from Ondřej Nový fix false-positives in the
       unnecessary-testsuite-autopkgtest-field tag with non-"autopkgtest"
       values in the Testsuite control field.  (Closes: #918621)
 .
   * data/systemd/init-whitelist:
     + [CL] Add "brightness" to the list of initscripts that do not need a
       corresponding service file.  (Closes: #918459)
 .
   * debian/control:
     + [AB] Build-conflict with libperl-critic-pulp-perl (except with
       nocheck build profile) as it adds additional perlcritic rules which
       cause several checks under t/scripts/01-critic/ to fail.
 .
   * lib/Lintian/Util.pm:
     + [CL] Add optional support for stripping comments at EOL in
       read_dpkg_control via DCTRL_COMMENTS_AT_EOL.  (Closes: #917964)
Checksums-Sha1:
 835de358a60580f2b7111ff5dfa6e85571cae0a0 2863 lintian_2.5.120.dsc
 dae8b17fb39f846c23b07c5082c11b2d90778300 1626980 lintian_2.5.120.tar.xz
 46f5b24c3c39d1c5a8aa4e6ea297e16af55b4fc6 1174552 lintian_2.5.120_all.deb
 8b5f6ae852c398085c9287903bb56a5d4628e010 16699 lintian_2.5.120_amd64.buildinfo
Checksums-Sha256:
 54ae858ea5a4d715969d40990fa334f17871888eeab987d45ea8557ca8c0e502 2863 lintian_2.5.120.dsc
 c8bacad6d4ac54d14db579a8738d480133de4c8fabd330c85217703d47b6f64e 1626980 lintian_2.5.120.tar.xz
 fcf9a875555068529a0b3f46a8ec367e1ba940bb54585344e0f240b8be1a2286 1174552 lintian_2.5.120_all.deb
 5cd2335a7910f5224bd5b87d69d9a1c9de6c70f568ebd771224cc5598925f268 16699 lintian_2.5.120_amd64.buildinfo
Files:
 115c13232e70ab3444e3045b77675f9b 2863 devel optional lintian_2.5.120.dsc
 ed8114001fec9cd6886a03edcde087f9 1626980 devel optional lintian_2.5.120.tar.xz
 1f72bcedd72acbac759d68d5f35feab1 1174552 devel optional lintian_2.5.120_all.deb
 3e845d7da42d8da01649d5742619d574 16699 devel optional lintian_2.5.120_amd64.buildinfo

* tag '2.5.120':
  Release lintian/2.5.120 into unstable.
  Fix false-positives in the unnecessary-testsuite-autopkgtest-field tag with non-"autopkgtest" values in the Testsuite control field. (Closes: #918621)
  Build-conflict with libperl-critic-pulp-perl <!nocheck>
  override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS: s/profile/option/
  Guile object files do not objdump/strip correctly so exclude them from a number of tests. (Closes: #918444)
  Add "brightness" to the list of initscripts that do not need a corresponding service file. (Closes: #918459)
  Correct grammar.
  Handle systemd service templates for missing init scripts
  Clarify that spelling-* tags also correct various grammatical errors too.
  Drop versioned-dependency-satisfied-by-perl. (Closes: #917967)
  Add optional support for stripping comments at EOL in read_dpkg_control via DCTRL_COMMENTS_AT_EOL. (Closes: #917964)
  Open new changelog entry for 2.5.120.

Ondřej Nový authored Jan 07, 2019 and Chris Lamb committed Jan 07, 2019

Fix false-positives in the unnecessary-testsuite-autopkgtest-field tag with non-"autopkgtest" values in the Testsuite control field. (Closes: #918621)

Signed-off-by: Chris Lamb <lamby@debian.org>

If libperl-critic-pulp-perl is installed, several tests under
t/scripts/01-critic/ fail due to its additional perlcritic rules:

t/scripts/01-critic/checks.t:    Failed 1/58 subtests
t/scripts/01-critic/commands.t:  Failed  8/8 subtests
t/scripts/01-critic/lib.t:       Failed 3/52 subtests

Replace misleading "profile" with "option" in long description of the
tag override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.

See https://lists.debian.org/debian-devel/2019/01/msg00039.html ff.,
especially https://lists.debian.org/debian-devel/2019/01/msg00047.html
for context as well as https://bugs.debian.org/889746 for the original
intent.

Guile object files do not objdump/strip correctly so exclude them from a number of tests. (Closes: #918444)

Add "brightness" to the list of initscripts that do not need a corresponding service file. (Closes: #918459)

Robin Jarry authored Jan 03, 2019 and Chris Lamb committed Jan 05, 2019

Do not emit the following errors when a systemd service template (a
NAME@.service file) matches a similar init script (a /etc/init.d/NAME):

 missing-systemd-service-for-init.d-script
 omitted-systemd-service-for-init.d-script

Assume that the systemd service template goes with the init script.

Signed-off-by: Chris Lamb <lamby@debian.org>

Release lintian/2.5.119 into unstable.

Format: 1.8
Date: Tue, 01 Jan 2019 14:55:01 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.119
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 913930 917264 917344 917345 917752 917844
Changes:
 lintian (2.5.119) unstable; urgency=medium
 .
   * checks/changelog-file.pm:
     + [CL] Avoid false-positives in changelog-file-missing-explicit-entry
       when uploading updates to updates such as "1.2-3+nmu2" or
       "1.2-3deb8u2".
   * checks/cruft.pm:
     + [BR] Following #916095, tag "invariant sections" modified by upstream
       versions as non official.
   * checks/debhelper.desc:
     + [CL] Include the debhelper-compat method of setting the compatibility
       level in a number of tag descriptions.  Thanks to Jeremy Bicha for
       the idea.  (Closes: #917345)
   * checks/python.desc:
     + [CL] Update the dependency-on-python-version-marked-for-end-of-life
       tag's description to mention that a commented override would be
       useful in order to document that the package will not ported to
       Python 3.x.  Thanks to Scott Kitterman.  (Closes: #917264)
   * checks/shared-libs.desc:
     + [CL] Clarify that "Build-Depends-Package" lines should start in
       column 1 of the file and not be indented to align with the symbols
       themselves.
   * checks/upstream-signing-key.pm:
     + [CL] Apply a patch from Felix Lechner to provide writable temporary
       home directory for GPG.  (Closes: #913930)
 .
   * data/debhelper/compat-level:
     + [CL] Bump the recommended and experimental debhelper compat levels to
       12 and 13 respectfully.  (Closes: #917344)
   * data/files/js-libraries:
     + [BR] Detect the html5shiv library. This library is the de facto way
       to enable the use of HTML5 "sectioning" elements in legacy Internet
       Explorer.
     + [BR] Detect the mocha testing framework and recommend libjs-mocha.
     + [BR] Detect the "chai" testing framework, recommending libjs-chai.
   * data/files/privacy-breaker-websites:
     + [BR] Suggest using libjs-html5shiv over linking to an external
       version.
     + [BR] Detect the libjs-chai package.
     + [BR] Detect the libjs-expect.js package.
   * data/spelling/corrections:
     + [PW] Add a number of corrections.
 .
   * debian/control:
     + [CL] Move to debhelper compatibility level 12.
 .
   * t/tests/*:
     + [CL] Apply a patch eries from Felix Lechner to ensure the tests pass
       under groff 1.22.4-1.  (Closes: #917752, #917844)
     + [CL] Apply a patch series from Felix Lechner to update the Debhelper
       compatibility level in tests.  The value is now read from
       Lintian::Data and no longer hardcoded.  (MR: !111)
   * t/tests/debhelper-compat-experimental/tags:
     + [CL] Apply a patch from Felix Lechner to remove a tag that is no
       longer emitted.  (MR: !112)
Checksums-Sha1:
 9b6f6e8e80471ddb4e0cdaa3942bd32f414fb28c 2810 lintian_2.5.119.dsc
 f9072696bd2af78d0f712ffe53e51db9f5edf890 1626668 lintian_2.5.119.tar.xz
 cb6e214ae3b62808bd42c64e280d3c0404eb979c 1172988 lintian_2.5.119_all.deb
 73990f8dde4a8cde1755edbe6cadac024fbb7072 16707 lintian_2.5.119_amd64.buildinfo
Checksums-Sha256:
 6110b32383dc2b371011ae4ae6251f9fbb0a16cf03923a38c10f259ddce90c5b 2810 lintian_2.5.119.dsc
 b13783bd49f4899e16d870591dc85a888c545d1c02b3c46fc1a1feebdfdb1ca7 1626668 lintian_2.5.119.tar.xz
 b9218ccadb8c99f7eb4c8e9a14688724fa5c0243077aa94cf15089ee3ae3dd02 1172988 lintian_2.5.119_all.deb
 caaad54e7a450ccf77f085b52d6fd634d86b047ec4aa2301907eec24ea4d40dc 16707 lintian_2.5.119_amd64.buildinfo
Files:
 cc7e71c51d0c084bab6540413cffbc5a 2810 devel optional lintian_2.5.119.dsc
 8228d7e40f7fc74b0d040d6c1db51179 1626668 devel optional lintian_2.5.119.tar.xz
 7c4b9b6e9e4eb9f6bd9c9c000aa9c7c2 1172988 devel optional lintian_2.5.119_all.deb
 6649eb02b623baebe27195064ff48b73 16707 devel optional lintian_2.5.119_amd64.buildinfo

* tag '2.5.119': (41 commits)
  Release lintian/2.5.119 into unstable.
  Move to debhelper compat level 12.
  Apply a patch series from Felix Lechner to ensure the tests pass under groff 1.22.4-1. (Closes: #917752, #917844)
  Limit test 'manpage-general' to groff-base >= 1.22.4.
  Add new tag for man errors in included material. (Closes: #917844)
  Skip some input file information prepended by groff-base.
  Adjust to groff output using left single quote instead of apostrophe.
  Provide writable temporary home directory for GPG. (Closes: #913930)
  Apply a patch series from Felix Lechner to update the Debhelper compatibility level in tests. (MR: !111)
  Override dh_dwz in two tests that fail because of it.
  Fix test fields-mua for debhelper 12.
  Fix test conffiles-general for debhelper 12.
  Fix a python-related test after debhelper bump.
  Bump debhelper versions in experimental test.
  Require compat 11 for tests that needs it.
  Update test tags for debhelper compat bump to 12.
  Add Pre-Depends: ${misc:Pre-Depends} to tests that need it.
  Add Pre-Depends: ${misc:Pre-Depends} to control.in in templates.
  Use DEFAULT_DEBHELPER_COMPAT from env instead of hardcoded value.
  Export recommended dh compat to env as DEFAULT_DEBHELPER_COMPAT.
  ...

Add optional support for stripping comments at EOL in read_dpkg_control via DCTRL_COMMENTS_AT_EOL. (Closes: #917964)

Apply a patch series from Felix Lechner to ensure the tests pass under groff 1.22.4-1. (Closes: #917752, #917844)

Felix Lechner authored Dec 31, 2018 and Chris Lamb committed Jan 01, 2019

New versions of groff-base have changed their output format. One test
required adjustment, but will not pass with older versions. Imposes a
minimum version of groff-base for this test as a prerequisite.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Jan 01, 2019

The man page that triggers the tag is included by another man page.
Such errors were apparently not detected before groff-base 1.22.4-1.
Adding tag here.

The tag format is a bit longer. It includes a partial path to the
included file. This test should be split up into several smaller
tests.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Jan 01, 2019

groff-base 1.22.4-1 prepends the name of the input file to any error
output. In Lintian, the messages look like '<standard input>:' for
regular man pages, and 'man/man3/XXX.3.gz:' if the error occurs in a
file included from elsewhere. For standard input, skip the information
to match the old tag output. For files included from elsewhere, the
extra information may be useful; it is retained.

If a file included from elsewhere causes an error but is also tested
on its own, the new behavior results in two similar tags being issued
that point out the same error (it would not be a duplicate).  Perhaps
the tag should not be skipped for included files.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Jan 01, 2019

In its error output, groff-base 1.22.4-1 seems to delimit the left
side of macro names with a single quote instead of an apostrophe,
which was used until now.  Adjust the expected tags in the test
'manpage-general' and a line in check/manpages.pm that skips some such
lines.

It may be worthwhile to send a note to all maintainers of packages
that override such a tag. The change is hard to see and can be
frustrating to find.

Felix Lechner authored Dec 31, 2018 and Chris Lamb committed Dec 31, 2018

When running Lintian under sbuild or pbuilder, the call to gpg errors
out with:

gpg: Fatal: can't create directory '/sbuild-nonexistent/.gnupg': No such file or directory

Provides a writable temporary home directory to gpg to avoid the error.

Signed-off-by: Chris Lamb <lamby@debian.org>

Apply a patch series from Felix Lechner to update the Debhelper compatibility level in tests. (MR: !111)

Felix Lechner authored Dec 29, 2018 and Chris Lamb committed Dec 30, 2018

Someone with more gcc experience may be able to correct the debug
format for the two tests. For now, dwz was non-essential. It was
disabled.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 28, 2018 and Chris Lamb committed Dec 30, 2018

Parameterizes the custom debian/control.in and updates a tag.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 28, 2018 and Chris Lamb committed Dec 30, 2018

The functionality of debian/conffiles was disabled in debhelper 12.
Moves the file into DEBIAN manually before building the deb.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

A python-related test now requires the explicit declaration of a
build system.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Increases the compat level in the test for debhelper's experimental
version to 13, which is a level above the one currently recommended.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

The option dh_clean -k was completely removed in compat 12.  The test
warning about its obsolescence requires compat 11 or lower. The
alternative would be to remove the test.

For another test, the command passing with '--' to dh_installdebs
fails. This likewise seems to be a new debhelper restriction. It also
requires compat 11.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Some tags issue compat levels as part of their message. Those tags
are fixed here.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Some tests do not use templates and also require this change to avoid
the tag 'skip-systemd-native-flag-missing-pre-depends'.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Many tests throw 'skip-systemd-native-flag-missing-pre-depends'
without this.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

With some luck, this component will not have to be updated again when
the debhelper compat level changes.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

An enviroment variable allows the use of the value in separate test
runners and spawned executables.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Dec 27, 2018 and Chris Lamb committed Dec 30, 2018

Works better than the two other routines nearby, which determine
either the debhelper version required in Lintian's own debian/control
or the debhelper version installed on the system.

Signed-off-by: Chris Lamb <lamby@debian.org>

Was a premature attempt at releasing but I left this commit locally which I
then accidentally pushed in e0871779.

This reverts commit b9f9ad46.

Felix Lechner authored Dec 30, 2018 and Chris Lamb committed Dec 30, 2018

Together with Dh-Compat-Level: 12 in 'desc', the default builder
supplies the correct dependency via:

Default-Build-Depends: debhelper (>= {$dh_compat_level}~)

The tag complaining about lack of a version is no longer issued.
Removing it from the list of expected tags.

Signed-off-by: Chris Lamb <lamby@debian.org>