Release lintian/2.5.122 into unstable.

Format: 1.8
Date: Thu, 17 Jan 2019 15:52:23 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.122
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 917567 917790 918963 919096 919458
Changes:
 lintian (2.5.122) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - example-incorrect-path-for-interpreter
       - incorrect-path-for-interpreter
       - package-contains-real-file-outside-usr
       - zero-byte-executable-in-path
 .
   [ Chris Lamb ]
   * Add a check for empty executable files in PATH; these files do not do
     anything and produce no error message. (Closes: #919458)
   * Prevent false-positives in the
     maintainer-script-should-not-use-dpkg-maintscript-helper tag by adding
     optional support for ignoring sections automatically added by
     debhelper. (Closes: #917567)
   * Split the wrong-path-for-interpreter tag into "wrong" and "incorrect"
     variants, the latter with a reduced severity and capturing incorrect
     (but working) shebangs such as "#!/usr/bin/env perl". Thanks to Ivo De
     Decker for the report. (Closes: #917790)
   * Update Debian Policy regex and manual references since this document
     moved to Sphinx. (Closes: #918963)
   * Also update the Java policy references as a new version of Docbook
     generates different HTML links.
   * Tests:
     - Tidy "sorry" message in t/runtests.
     - Drop changelog-format.t tests now we are trialling using gbp-dch.
     - Add a note that using a "maintainer-script-should-not-" tag prefix
       ensures that the tag will automatically pass the internal coverage
       tests.
   * debian/control:
     - Clarify some grammar in the package long description.
     - Prune Uploaders field to the current members of the "lintian" LDAP
       group. With thanks to all who have contributed in the past.
 .
   [ Felix Lechner ]
   * Always use the extracted testing code in autopkgtests. (Closes: #919096)
   * Exit test runner with error code after parsing errors on the command line.
   * Convert test modules to the "Test Anything Protocol" (TAP).
     - Run TAP scripts for all tests through TAP::Harness. (MR: !124)
     - Add a generic test script for TAP::Harness.
     - Add name of the generic TAP script to the default settings.
     - Install generic TAP script into work directories during preparation.
   * Make harness timestamp calculation more robust for non-existent files.
   * Always use the installed "dplint" in autopkgtests.
 .
   [ Josh Triplett ]
   * Add a pedantic-level package-contains-real-file-outside-usr tag to
     detect files installed to /. (MR: !128)
 .
   [ Paul Wise ]
   * Add several spelling corrections.
Checksums-Sha1:
 2fd3ae829c2bb96bb806abb6b9e89e2ed02d38e3 2696 lintian_2.5.122.dsc
 d4c995b815215fc1e9572adb1b92c919a029cf8c 1633416 lintian_2.5.122.tar.xz
 e157def037ef79688473b348645e328d26b09732 1185228 lintian_2.5.122_all.deb
 fac1793a2a715fbd5d576692a6559ddc7c47453f 16662 lintian_2.5.122_amd64.buildinfo
Checksums-Sha256:
 6fa4f28c4a405a7ca14ca8a8237b3c15d240e35d0314a50c4a6f705992ec5407 2696 lintian_2.5.122.dsc
 ab930e07005e48e883c4d3983c5cad651719709e3e43749b87e0fb21efe51fb7 1633416 lintian_2.5.122.tar.xz
 b4b09e3eb9500318fbb6ffa23a4fad17b44495b433e36285d2b880cff1e6ff54 1185228 lintian_2.5.122_all.deb
 3d120eab79bc43d915a222506ea85bed3444177ed5e7c227133c63d7b0882ea0 16662 lintian_2.5.122_amd64.buildinfo
Files:
 50f624797b30c8b10519df0c4af01687 2696 devel optional lintian_2.5.122.dsc
 0eb877c8821492db40fd78bc27ee3e7e 1633416 devel optional lintian_2.5.122.tar.xz
 453b5dc8d02028f192e898bd9546804c 1185228 devel optional lintian_2.5.122_all.deb
 a5cc95e7ac7f61e75f81e2da705cdb7a 16662 devel optional lintian_2.5.122_amd64.buildinfo

* tag '2.5.122': (76 commits)
  Release lintian/2.5.122 into unstable.
  Update tests for new tags.
  Drop trailing full-stop when parsing new DocBook headers to fix broken java-policy references.
  Drop changelog-format.t tests now we are trialling using gbp-dch.
  Also allow for "... & fill in with gbp dch" when generating tag summaries.
  Actually check that the executable file is empty.
  Don't emit "uninitialized variable" when $link is undefined.
  Also add package-contains-real-file-outside-usr to files-foo-in-bar.
  Exit test runner with error code after parsing errors on the command line.
  Add a check for empty executable files in PATH; these files do not do anything and produce no error message. (Closes: #919458)
  Add a pedantic-only check to help detect files installed to /. (MR: !128)
  t/runtests: Tidy "sorry" message.
  Clarify some grammar in the package long description.
  Prune Uploaders field to the members of the "lintian" LDAP group with thanks to all who have contributed in the past.
  Always use the installed dplint in autopkgtests.
  Make harness timestamp calculation more robust for non-existent files.
  For autopkgtests, always use the extracted testing code. (Closes: #919096)
  spelling: Add several corrections
  Split the wrong-path-for-interpreter into "wrong" and "incorrect" variants, the latter with a reduced severity and capturing incorrect (but working) shebangs such as "#!/usr/bin/env perl". Thanks to Ivo De Decker for the report. (Closes: #917790)
  perltidy refresh-manual-refs.
  ...

Gbp-Dch: ignore

Gbp-Dch: ignore

Gbp-Dch: ignore

Gbp-Dch: ignore

Felix Lechner authored Jan 16, 2019 and Chris Lamb committed Jan 17, 2019

The test runner terminated with exit code 0 when a tag listed in the 'onlyrun'
option could not be found. This issue is mentioned in #919531, but does not
close the bug.

Signed-off-by: Chris Lamb <lamby@debian.org>

Add a check for empty executable files in PATH; these files do not do anything and produce no error message. (Closes: #919458)

Josh Triplett authored Jan 15, 2019 and Chris Lamb committed Jan 16, 2019

As a way to help gather data and aid in future migration to /usr, as
well as a means of detecting packages that installed files to / to help
mount /usr that no longer need to, add an experimental pedantic-only
check for files in / (/bin, /sbin, /lib*) that are not compatibility
symlinks to the corresponding file in /usr.

Note that this is a pedantic-only check, with no plans to migrate it to
a warning or error in the near future and should not be used as the
basis for any form of mass bug filing.

Signed-off-by: Chris Lamb <lamby@debian.org>

Prune Uploaders field to the members of the "lintian" LDAP group with thanks to all who have contributed in the past.

(We do respect Niels explicit removal in 15118c1c)

Felix Lechner authored Jan 12, 2019 and Chris Lamb committed Jan 13, 2019

Previously we used the extracted version of 'dplint' under autopkgtests.  We
correct the path so that the installed version is used in compliance with
autopkgtest requirements.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Jan 12, 2019 and Chris Lamb committed Jan 13, 2019

Improves on the previous commit if none of the paths in File::Find::Rule exist.
In that case, the call to stat could fail. Substitutes 'time' instead. This
would also triage #919096 but set HARNESS_EPOCH to a value more recent than
necessary.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Jan 12, 2019 and Chris Lamb committed Jan 13, 2019

The harness files are not installed into /usr/share/lintian so they
were not found at testing time. Use the untarred testing code (but the
installed version of Lintian).

Signed-off-by: Chris Lamb <lamby@debian.org>

Split the wrong-path-for-interpreter into "wrong" and "incorrect" variants, the latter with a reduced severity and capturing incorrect (but working) shebangs such as "#!/usr/bin/env perl". Thanks to Ivo De Decker for the report. (Closes: #917790)

Gbp-Dch: ignore

Update Debian Policy regex and manual references since this document moved to Sphinx. (Closes: #918963)

Prevent false-positives in maintainer-script-should-not-use-dpkg-maintscript-helper by adding optional support for ignoring sections automatically added by debhelper. (Closes: #917567)

Add a note that using a maintainer-script-should-not- prefix ensures that the tag will automatically pass the internal coverage tests.

Felix Lechner authored Jan 10, 2019 and Chris Lamb committed Jan 11, 2019

Use TAP::Harness to run all Lintian tests. This unifies all tests. It
has the advantage that all results appear at the bottom. It is
therefore unlikely to miss a failure in the code quality scripts or in
the internal harness tests. Previously, those results tended to be
obscured by long output from the package tests.

The short output shown when building via 'debuild' (presumably for
lack of a tty) is no longer available. There may be a way to customize
TAP::Harness, if that is important.

Also, the command line setting $keep_going does not have any effect
currently. Somewhat surprisingly, such a "bail-on-fail" setting is not
available in Perl's standard TAP::Harness. It only requires a trivial
subclass available on CPAN, but was not used for now to avoid adding
another dependency. This can be addressed, if necessary.

As for speed, running all tests through TAP::Harness is currently
slower than the old runner. The difference is about 8 percent.  This
comes as a surprise since previous tests showed them about the same.
Perplexingly, the parallel test preparation seems responsible. It is
the only recent feature.

Other more modern harness implementations such as Test2::Harness offer
pre-loaded persistent runners. They could bring a speed gain that
should be investigated in time.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Jan 10, 2019 and Chris Lamb committed Jan 11, 2019

Test evaluated with Perl's 'prove' or with TAP::Harness must
communicate their results and other status information using the "Test
Anything Protocol" (TAP).

TAP is a text-based protocol that works differently from the way
information is conveyed by the existing persistent runners in Lintian,
which use IO::Async::Channel.

Converts the test modules to emit TAP messages using Test::More.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Jan 10, 2019 and Chris Lamb committed Jan 11, 2019

Deletes old test scripts and installs the current generic TAP script
into test working directories.

The scripts can be evaluated using 'prove' or TAP::Harness.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Jan 10, 2019 and Chris Lamb committed Jan 11, 2019

A generic test scripts that can be used for Lintian with TAP::Harness
is available at t/runners/generic.t. The default setting allows the
test preparation routines to find it. Then it is copied into each
test's work directory before it is run.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Oct 18, 2018 and Chris Lamb committed Jan 11, 2019

Adds a generic test script that can be installed in test working
directories. It is then invoked via 'prove' or TAP::Harness.

Requires that modules reporting results switch from a properly
initialized Test::State to the "Test Anything Protocol", which is
available from various modules such as Test::More.

Signed-off-by: Chris Lamb <lamby@debian.org>

Felix Lechner authored Jan 10, 2019 and Chris Lamb committed Jan 10, 2019

A recent commit series to split the test preparation from the test runner
causes the following error:

    not a reference at /usr/share/perl5/IO/Async/Channel.pm line 197.

The problem was likely added in commit 6ffd137a

. This now passes (and
also resolves) an explicit reference to the path that identifies each
test.

Signed-off-by: Chris Lamb <lamby@debian.org>

 Apply a patch series from Felix Lechner to split the preparation of tests from the test runner itself. (MR: !122)