Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

modules: use `mount|grep` instead of `mountpoint` to detect whether /dev/ptmx and /dev/console are still mounted

mountpoint(1) from initscripts as found in Debian jessie doesn't detect
mounts over regular files as the version in util-linux (present in
Debian stretch); this means those two checks could fail when run with
initscripts' mountpoint(1).

/dev/ptmx and /dev/console are the only mounts done by pbuilder over a
regular file instead of a directory.

Closes: #859766
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

it's not useful to debug this function every time it gets called..

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Specifying --extrapackages multiple times will now add packages to the
list.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Reported-By: Unit193
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Jessica Clarke authored Mar 06, 2017 and Mattia Rizzolo committed Mar 12, 2017

This allows for better isolation as the build process is no longer able
to see the host's PTYs, other than the controlling terminal (if there is
one). By using a new instance, we can also control the permissions of
/dev/pts/ptmx, ensuring that the build process is always able to create
new PTYs, even if the host's has the default 000 mode.

Since the mountpoint binary moved from initscripts to util-linux, the
extra alternative versioned dependencies are needed to ensure that one
of them provides it. Both jessie and stretch have the providing package
as (transitively) essential, but we should guard against FrankenDebians.

Closes: #841935
Thanks: Simon McVittie <smcv@debian.org> for the thorough investigation
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Jessica Clarke authored Mar 06, 2017 and Mattia Rizzolo committed Mar 12, 2017

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

mirabilos authored Mar 02, 2017 and Jessica Clarke committed Mar 02, 2017

Closes: #856475

Gbp-Dch: Ignore

Gbp-Dch: Ignore

normal people are not supposed to know of such possibility

Gbp-Dch: Ignore

Gbp-Dch: Ignore

pbuilderrc.5: document what will happen inside BUILDDIR, and where the unpacked source will be (by default).

pbuilderrc.5: remove stale information: BUILDDIR is not (by default) the HOME of the build user anymore

Closes: #854255

saves one line

Gbp-Dch: Ignore

Closes: #852442

pbuilder-modules: Add get_source_options function to extract options for dpkg-source from DEBBUILDOPTS