test_removeolduploads.py 10.8 KB
Newer Older
1
2
3
4
5
#   test_removeolduploads.py - Test the removeolduploads cronjob
#
#   This file is part of debexpo
#   https://salsa.debian.org/mentors.debian.net-team/debexpo
#
6
#   Copyright © 2019-2020 Baptiste Beauplat <lyknode@cilg.org>
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
#
#   Permission is hereby granted, free of charge, to any person
#   obtaining a copy of this software and associated documentation
#   files (the "Software"), to deal in the Software without
#   restriction, including without limitation the rights to use,
#   copy, modify, merge, publish, distribute, sublicense, and/or sell
#   copies of the Software, and to permit persons to whom the
#   Software is furnished to do so, subject to the following
#   conditions:
#
#   The above copyright notice and this permission notice shall be
#   included in all copies or substantial portions of the Software.
#
#   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
#   EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
#   OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
#   NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
#   HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
#   WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
#   FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
#   OTHER DEALINGS IN THE SOFTWARE.
import datetime
import logging
30
from email import message_from_string
31
from http.server import BaseHTTPRequestHandler
32

33
34
35
from django.conf import settings
from django.test import override_settings

36
37
38
39
# from debexpo.lib.email import Email
from debexpo.accounts.models import User
from debexpo.packages.models import Package, PackageUpload, Distribution, \
                                    Component
40
from tests import TestController, TestingHTTPServer
41
42
from debexpo.packages.tasks import remove_old_uploads, remove_uploaded_packages
from debexpo.tools.email import Email
43
44

log = logging.getLogger(__name__)
45
46
47
48
49
PACKAGE_IN_NEW = '''Source: tmux
Version: 1.0.0
Distribution: unstable

Source: Missing-other-fields'''
50
51


52
class TestCronjobRemoveOldUploads(TestController):
53
    def setUp(self):
54
        self._setup_example_user()
55
56
57
        self.state = []

    def tearDown(self):
58
59
        Package.objects.all().delete()
        self._remove_example_user()
60
61
62
63
64
65
66

    def _setup_packages(self, include_expired=False):
        packages = [
                # (package, version, distrib, expired),
                ('htop', '1.0.0', 'unstable', False),
                ('htop', '0.9.0', 'unstable', False),
                ('htop', '0.8.0', 'buster-backports', False),
67
                ('tmux', '1.1.0', 'unstable', False),
68
69
70
71
                ('tmux', '1.0.0', 'unstable', False),
                ('tmux', '1.0.0', 'UNRELEASED', False),
                ('zsh', '1.0.0', 'unstable', False),
                ('zsh', '1.0.0', 'unstable', False),
72
                ('zsh', '1.0.0', 'experimental', False),
73
74
75
76
77
78
79
80
81
82
83
84
85
                ('hello', '1.0.0', 'unstable', True),
                ('hello', '0.9.0', 'unstable', True),
            ]

        for (package, version, distrib, expired) in packages:
            if not expired or (expired and include_expired):
                self._create_package(package, version, distrib, expired)

            if not expired:
                self.state.append((package, version, distrib))

    def _create_package(self, name, version_number, distrib, is_expired):
        date = datetime.datetime.now()
86
        user = User.objects.first()
87
88

        try:
89
90
91
            package = Package.objects.get(name=name)
        except Package.DoesNotExist:
            package = Package(name=name)
92
93
94
95

        if is_expired:
            date -= datetime.timedelta(days=365)

96
97
        package.full_clean()
        package.save()
98

99
100
101
102
103
104
105
        upload = PackageUpload(
            package=package,
            version=version_number,
            uploader=user,
            changes='changes',
            distribution=Distribution.objects.get(name=distrib),
            component=Component.objects.get_or_create(name='tools')[0])
106

107
108
        upload.full_clean()
        upload.save()
109

110
111
        PackageUpload.objects.filter(id=upload.id).update(
            uploaded=date.replace(tzinfo=datetime.timezone.utc))
112
113

    def _assert_cronjob_success(self):
114
        packages = Package.objects.all()
115
116
117
118
        count = 0

        # Each package exists in state
        for package in packages:
119
120
121
122
123
124
125
            for upload in package.packageupload_set.all():
                log.info('validating {}-{}/{}'.format(package.name,
                                                      upload.version,
                                                      upload.distribution.name))
                self.assertIn((package.name,
                               upload.version,
                               upload.distribution.name), self.state)
126
127
128
129
130
131
132
133
134
135
136
137
138
139
                count += 1

        # Each state exists in package
        self.assertEquals(len(self.state), count)

    def _expect_package_removal(self, package_to_remove):
        new_state = []

        for package in self.state:
            if package not in package_to_remove:
                new_state.append(package)

        self.state = new_state

140
    def remove_upload_accepted(self, uploaded, down=False, garbage=False,
141
142
                               handler=None,
                               template='test-upload-accepted.html'):
143
144
145
146
147
        removed_packages = (
            ('tmux', '1.0.0', 'unstable'),
            ('tmux', '1.0.0', 'UNRELEASED'),
        )

148
149
150
        if not handler:
            handler = FTPMasterPackageInNewHTTPHandler

151
        self._expect_package_removal(removed_packages)
152
        with TestingHTTPServer(handler) as httpd:
153
154
155
156
            with self.settings(
                    FTP_MASTER_NEW_PACKAGES_URL='http://localhost:'
                                                f'{httpd.port}'):
                remove_uploaded_packages(FakeNNTPClient(uploaded, down,
157
                                                        garbage, template))
158
159

    def test_package_in_new_server_error(self):
160
161
        self._setup_packages()

162
163
164
165
166
167
        with TestingHTTPServer(FTPMasterPackageInNewErrorHTTPHandler) as httpd:
            with self.settings(
                    FTP_MASTER_NEW_PACKAGES_URL='http://localhost:'
                                                f'{httpd.port}'):
                remove_uploaded_packages(FakeNNTPClient([]))
        self._assert_cronjob_success()
168

169
170
171
172
173
174
175
176
177
    def test_package_in_new_double_version(self):
        self._setup_packages()

        self.remove_upload_accepted(
            [],
            handler=FTPMasterPackageInNewDoubleVersionHTTPHandler
        )
        self._assert_cronjob_success()

178
    def test_remove_uploads_noop_no_packages(self):
179
180
181
        remove_old_uploads()
        self._assert_cronjob_success()

182
183
184
185
186
187
188
189
190
191
192
193
194
195
    def test_remove_uploads_multipart(self):
        removed_packages = [
                ('zsh', '1.0.0', 'unstable'),
                ('zsh', '1.0.0', 'experimental'),
            ]

        self._setup_packages()
        self.remove_upload_accepted(
            [('zsh', '1.0.0', 'unstable')],
            template='test-upload-accepted-multipart.html'
        )
        self._expect_package_removal(removed_packages)
        self._assert_cronjob_success()

196
    def test_remove_uploads_server_down(self):
197
        self._setup_packages()
198
        self.remove_upload_accepted([], True)
199
200
        self._assert_cronjob_success()

201
    def test_remove_uploads_server_garbage(self):
202
        self._setup_packages()
203
204
205
206
207
208
209
        self.remove_upload_accepted([], False, True)
        self._assert_cronjob_success()

    def test_remove_uploads_inexistant_package(self):
        self.remove_upload_accepted([('inexistant_package', '1.0.0',
                                      'unstable')])
        self._assert_cronjob_success()
210
211
212

    def test_remove_uploads_noop_with_packages(self):
        self._setup_packages()
213
        remove_old_uploads()
214
215
        self._assert_cronjob_success()

216
217
218
219
    @override_settings()
    def test_remove_uploads_expired_no_gistorage(self):
        del settings.GIT_STORAGE

220
        self._setup_packages(include_expired=True)
221
        remove_old_uploads()
222
223
        self._assert_cronjob_success()

224
225
226
227
228
229
230
231
232
233
234
235
236
237
    def test_remove_uploads_keep_other_dists(self):
        removed_packages = [
                ('htop', '1.0.0', 'unstable'),
                ('htop', '0.9.0', 'unstable'),
            ]

        self._setup_packages()
        self.remove_upload_accepted([('htop', '1.0.0', 'unstable')])
        self._expect_package_removal(removed_packages)
        self._assert_cronjob_success()

    def test_remove_uploads_same_version(self):
        removed_packages = [
                ('zsh', '1.0.0', 'unstable'),
238
                ('zsh', '1.0.0', 'experimental'),
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
            ]

        self._setup_packages()
        self.remove_upload_accepted([('zsh', '1.0.0', 'unstable')])
        self._expect_package_removal(removed_packages)
        self._assert_cronjob_success()

    def test_remove_uploads_keep_newer(self):
        removed_packages = [
                ('htop', '0.9.0', 'unstable'),
            ]

        self._setup_packages()
        self.remove_upload_accepted([('htop', '0.9.0', 'unstable')])
        self._expect_package_removal(removed_packages)
        self._assert_cronjob_success()


257
258
259
260
261
262
263
264
class FTPMasterPackageInNewDoubleVersionHTTPHandler(BaseHTTPRequestHandler):
    def do_GET(self):
        self.send_response(200, 'OK')
        self.end_headers()
        self.wfile.write(bytes(PACKAGE_IN_NEW.replace('1.0.0', '0.9.0 1.0.0'),
                               'UTF-8'))


265
266
267
268
269
270
271
272
273
274
275
276
277
class FTPMasterPackageInNewHTTPHandler(BaseHTTPRequestHandler):
    def do_GET(self):
        self.send_response(200, 'OK')
        self.end_headers()
        self.wfile.write(bytes(PACKAGE_IN_NEW, 'UTF-8'))


class FTPMasterPackageInNewErrorHTTPHandler(BaseHTTPRequestHandler):
    def do_GET(self):
        self.send_response(500, 'Internal Server Error')
        self.end_headers()


278
class FakeNNTPClient():
279
280
    def __init__(self, uploads, down=False, garbage=False,
                 template='test-upload-accepted.html'):
281
282
283
284
        self.uploads = uploads
        self.iter = 0
        self.down = down
        self.garbage = garbage
285
        self.template = template
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305

    def connect_to_server(self):
        return not self.down

    def disconnect_from_server(self):
        return True

    def unread_messages(self, name, last):
        self.iter += 1

        if self.iter == 1:
            if self.garbage:
                for item in [None,
                             message_from_string('Subject: test\n\ntest')]:
                    yield item
            else:
                for upload in self.uploads:
                    yield self._build_nntp_response(upload)

    def _build_nntp_response(self, upload):
306
        email = Email(self.template)
307
308
309
310
311
312
313
314
        body = message_from_string(email._render_content([], **{
            'name': upload[0],
            'version': upload[1],
            'distrib': upload[2],
        }))
        body['X-Debexpo-Message-Number'] = 42

        return body