Verified Commit 0e0dc145 authored by Baptiste Beauplat's avatar Baptiste Beauplat
Browse files

Remove packageupload count check in Package method

A package should not be able to exist without any uploads
associated and removal should be done atomically. If not, better catch
and fix than having extraneous checks.
parent c997bd09
......@@ -141,25 +141,22 @@ class Package(models.Model):
return self.name
def get_description(self):
if self.packageupload_set.count():
upload = self.packageupload_set.latest('uploaded')
upload = self.packageupload_set.latest('uploaded')
if upload.binarypackage_set.count():
binary = upload.binarypackage_set.filter(name=self.name)
if upload.binarypackage_set.count():
binary = upload.binarypackage_set.filter(name=self.name)
if not binary:
binary = upload.binarypackage_set.last()
return binary.description
else:
return binary.get().description
if not binary:
binary = upload.binarypackage_set.last()
return binary.description
else:
return binary.get().description
return ''
def get_full_description(self):
description = []
if self.packageupload_set.count():
upload = self.packageupload_set.latest('uploaded')
upload = self.packageupload_set.latest('uploaded')
for binary in upload.binarypackage_set.all():
description.append('{} - {}'.format(binary.name,
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment